From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 1F50A5689 for ; Sun, 5 Feb 2017 13:10:54 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 05 Feb 2017 04:10:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,338,1477983600"; d="scan'208";a="930344654" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga003.jf.intel.com with ESMTP; 05 Feb 2017 04:10:52 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.38]) by IRSMSX152.ger.corp.intel.com ([169.254.6.191]) with mapi id 14.03.0248.002; Sun, 5 Feb 2017 12:10:52 +0000 From: "Ananyev, Konstantin" To: "Ananyev, Konstantin" , "Wu, Jingjing" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 3/5] net/ixgbe: fix bitmask of supported Tx flags Thread-Index: AQHSf6dn0w0KUl2CgUG4bhSpGCevDqFaUKRw Date: Sun, 5 Feb 2017 12:10:51 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772583F111017@irsmsx105.ger.corp.intel.com> References: <1485258650-86193-1-git-send-email-jingjing.wu@intel.com> <1486179375-133509-1-git-send-email-jingjing.wu@intel.com> <1486179375-133509-4-git-send-email-jingjing.wu@intel.com> <2601191342CEEE43887BDE71AB9772583F110FFC@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB9772583F110FFC@irsmsx105.ger.corp.intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 3/5] net/ixgbe: fix bitmask of supported Tx flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Feb 2017 12:10:55 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ananyev, Konstantin > Sent: Sunday, February 5, 2017 11:59 AM > To: Wu, Jingjing ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 3/5] net/ixgbe: fix bitmask of supporte= d Tx flags >=20 > Hi Jingjing, >=20 >=20 > > -----Original Message----- > > From: Wu, Jingjing > > Sent: Saturday, February 4, 2017 3:36 AM > > To: dev@dpdk.org > > Cc: Wu, Jingjing ; Ananyev, Konstantin > > Subject: [PATCH v2 3/5] net/ixgbe: fix bitmask of supported Tx flags > > > > Add missed flags to bitmask of all supported packet Tx flags. > > > > CC: konstantin.ananyev@intel.com > > Fixes: 7829b8d52be0 ("net/ixgbe: add Tx preparation") > > Signed-off-by: Jingjing Wu > > --- > > drivers/net/ixgbe/ixgbe_rxtx.c | 17 ++++++++++++++++- > > 1 file changed, 16 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_r= xtx.c > > index 36f1c02..8454581 100644 > > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > > @@ -81,13 +81,28 @@ > > #include "ixgbe_rxtx.h" > > > > /* Bit Mask to indicate what bits required for building TX context */ > > +#ifdef RTE_LIBRTE_IEEE1588 > > #define IXGBE_TX_OFFLOAD_MASK ( \ > > PKT_TX_VLAN_PKT | \ > > PKT_TX_IP_CKSUM | \ > > + PKT_TX_IPV4 | \ > > PKT_TX_L4_MASK | \ > > + PKT_TX_IEEE1588_TMST | \ > > PKT_TX_TCP_SEG | \ > > PKT_TX_MACSEC | \ > > - PKT_TX_OUTER_IP_CKSUM) > > + PKT_TX_OUTER_IP_CKSUM | \ > > + PKT_TX_OUTER_IPV4) > > +#else > > +#define IXGBE_TX_OFFLOAD_MASK ( \ > > + PKT_TX_VLAN_PKT | \ > > + PKT_TX_IP_CKSUM | \ > > + PKT_TX_IPV4 | \ >=20 > Wonder why ixgbe doesn't have PKT_TX_IPV6? Same question for e1000 and fm10k. Also if you decided to go that way, you'll probably need to update TX_OFFLO= AD_MASK for enic and vmxnet3. That's why I still think it would be much less hassle not to include these flags (PKT_TX_IPV4 and PKT_TX_IPV6) into TX_OFFLOAD_MASK at all. Konstantin >=20 > > + PKT_TX_L4_MASK | \ > > + PKT_TX_TCP_SEG | \ > > + PKT_TX_MACSEC | \ > > + PKT_TX_OUTER_IP_CKSUM | \ > > + PKT_TX_OUTER_IPV4) > > +#endif > > > > #define IXGBE_TX_OFFLOAD_NOTSUP_MASK \ > > (PKT_TX_OFFLOAD_MASK ^ IXGBE_TX_OFFLOAD_MASK) > > -- > > 2.4.11