From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id C6C1510FF8 for ; Thu, 30 Mar 2017 13:31:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490873517; x=1522409517; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=F0UNUTOCxmfX8NnemH0GwsIvxMY+Z7rmsW2ezW8J5/k=; b=DvnbInrTQLifgfRsUiQZWgqFrNLes8vkcDWrBjHnYwgqhlkKbTx+5JpP NJPmi/xorcJkzS5i1ZOqvnb31vxE0g==; Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Mar 2017 04:31:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,246,1486454400"; d="scan'208";a="80943255" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga005.jf.intel.com with ESMTP; 30 Mar 2017 04:31:55 -0700 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.12]) by IRSMSX151.ger.corp.intel.com ([169.254.4.123]) with mapi id 14.03.0319.002; Thu, 30 Mar 2017 12:31:55 +0100 From: "Ananyev, Konstantin" To: "Singh, Jasvinder" , "dev@dpdk.org" CC: "olivier.matz@6wind.com" , "Doherty, Declan" , "De Lara Guarch, Pablo" Thread-Topic: [dpdk-dev] [PATCH v8 1/2] librte_net: add crc compute APIs Thread-Index: AQHSqUe9GaRlgcC7fUyukBW9vm6GmqGtPyQQ Date: Thu, 30 Mar 2017 11:31:54 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772583FAE243B@IRSMSX109.ger.corp.intel.com> References: <1490807704-211859-2-git-send-email-jasvinder.singh@intel.com> <1490873422-13734-1-git-send-email-jasvinder.singh@intel.com> <1490873422-13734-2-git-send-email-jasvinder.singh@intel.com> In-Reply-To: <1490873422-13734-2-git-send-email-jasvinder.singh@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v8 1/2] librte_net: add crc compute APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2017 11:31:57 -0000 Hi Jasvinder, > diff --git a/lib/librte_net/rte_net_crc.h b/lib/librte_net/rte_net_crc.h > new file mode 100644 > index 0000000..dd6c110 > --- /dev/null > +++ b/lib/librte_net/rte_net_crc.h > @@ -0,0 +1,104 @@ > +/*- > + * BSD LICENSE > + * > + * Copyright(c) 2017 Intel Corporation. > + * All rights reserved. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions > + * are met: > + * > + * * Redistributions of source code must retain the above copyright > + * notice, this list of conditions and the following disclaimer. > + * * Redistributions in binary form must reproduce the above copyrig= ht > + * notice, this list of conditions and the following disclaimer in > + * the documentation and/or other materials provided with the > + * distribution. > + * * Neither the name of Intel Corporation nor the names of its > + * contributors may be used to endorse or promote products derived > + * from this software without specific prior written permission. > + * > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS F= OR > + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGH= T > + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTA= L, > + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF US= E, > + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON A= NY > + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE U= SE > + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE= . > + */ > + > +#ifndef _RTE_NET_CRC_H_ > +#define _RTE_NET_CRC_H_ > + > +#ifdef __cplusplus > +extern "C" { > +#endif > + > +#include > + > +#include As a nit: you probably don't need that include. Konstantin > + > +/** CRC polynomials */ > +#define CRC32_ETH_POLYNOMIAL 0x04c11db7UL > +#define CRC16_CCITT_POLYNOMIAL 0x1021U > + > +#define CRC_LUT_SIZE 256 > + > +/** CRC types */ > +enum rte_net_crc_type { > + RTE_NET_CRC16_CCITT =3D 0, > + RTE_NET_CRC32_ETH, > + RTE_NET_CRC_REQS > +}; > + > +/** CRC compute algorithm */ > +enum rte_net_crc_alg { > + RTE_NET_CRC_SCALAR =3D 0, > + RTE_NET_CRC_SSE42, > +}; > + > +/** > + * This API set the CRC computation algorithm (i.e. scalar version, > + * x86 64-bit sse4.2 intrinsic version, etc.) and internal data > + * structure. > + * > + * @param alg > + * This parameter is used to select the CRC implementation version. > + * - RTE_NET_CRC_SCALAR > + * - RTE_NET_CRC_SSE42 (Use 64-bit SSE4.2 intrinsic) > + */ > +void > +rte_net_crc_set_alg(enum rte_net_crc_alg alg); > + > +/** > + * CRC compute API > + * > + * @param data > + * Pointer to the packet data for CRC computation > + * @param data_len > + * Data length for CRC computation > + * @param type > + * CRC type (enum rte_net_crc_type) > + * > + * @return > + * CRC value > + */ > +uint32_t > +rte_net_crc_calc(const void *data, > + uint32_t data_len, > + enum rte_net_crc_type type); > + > +#if defined(RTE_ARCH_X86_64) && defined(RTE_MACHINE_CPUFLAG_SSE4_2) > +#include > +#endif > + > +#ifdef __cplusplus > +} > +#endif > + > +