From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 646CB9E3 for ; Thu, 30 Mar 2017 20:06:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490897205; x=1522433205; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=OcFbF2z6yKdWBNkgNxXe9CF/vsVc66ulDm06TigamDI=; b=nQFL1iw/rON+rbJjKBSp8g/r8NMEex9A7UzgCqF3JTodePRbo/V7irq8 DKCGQ+OTYNg6TRZGV11SfufAZRzVTg==; Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Mar 2017 11:06:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,247,1486454400"; d="scan'208";a="71988224" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga004.jf.intel.com with ESMTP; 30 Mar 2017 11:06:38 -0700 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by irsmsx105.ger.corp.intel.com (163.33.3.28) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 30 Mar 2017 19:06:37 +0100 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.12]) by irsmsx111.ger.corp.intel.com ([169.254.2.58]) with mapi id 14.03.0319.002; Thu, 30 Mar 2017 19:06:37 +0100 From: "Ananyev, Konstantin" To: "Richardson, Bruce" , Olivier Matz CC: "dev@dpdk.org" , "mb@smartsharesystems.com" , "Chilikin, Andrey" , "jblunck@infradead.org" , "nelio.laranjeiro@6wind.com" , "arybchenko@solarflare.com" Thread-Topic: [dpdk-dev] [PATCH 0/9] mbuf: structure reorganization Thread-Index: AQHSl/BM96NM/aKG30C3i/t54/q6k6GsCWqAgABGqICAAOACAIAAKlIAgAAFugCAAFkDYIAAAV1QgAAS2dA= Date: Thu, 30 Mar 2017 18:06:35 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772583FAE2B2F@IRSMSX109.ger.corp.intel.com> References: <1485271173-13408-1-git-send-email-olivier.matz@6wind.com> <1488966121-22853-1-git-send-email-olivier.matz@6wind.com> <20170329175629.68810924@platinum> <20170329200923.GA11516@bricha3-MOBL3.ger.corp.intel.com> <20170330093108.GA10652@bricha3-MOBL3.ger.corp.intel.com> <20170330140236.0d2ebac8@platinum> <20170330122305.GA14272@bricha3-MOBL3.ger.corp.intel.com> <2601191342CEEE43887BDE71AB9772583FAE2A51@IRSMSX109.ger.corp.intel.com> <2601191342CEEE43887BDE71AB9772583FAE2A6E@IRSMSX109.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB9772583FAE2A6E@IRSMSX109.ger.corp.intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/9] mbuf: structure reorganization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2017 18:06:46 -0000 > -----Original Message----- > From: Ananyev, Konstantin > Sent: Thursday, March 30, 2017 5:48 PM > To: Ananyev, Konstantin ; Richardson, Bruce= ; Olivier Matz > > Cc: dev@dpdk.org; mb@smartsharesystems.com; Chilikin, Andrey ; jblunck@infradead.org; > nelio.laranjeiro@6wind.com; arybchenko@solarflare.com > Subject: RE: [dpdk-dev] [PATCH 0/9] mbuf: structure reorganization >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ananyev, Konstanti= n > > Sent: Thursday, March 30, 2017 5:45 PM > > To: Richardson, Bruce ; Olivier Matz > > Cc: dev@dpdk.org; mb@smartsharesystems.com; Chilikin, Andrey ; jblunck@infradead.org; > > nelio.laranjeiro@6wind.com; arybchenko@solarflare.com > > Subject: Re: [dpdk-dev] [PATCH 0/9] mbuf: structure reorganization > > > > > > > > > -----Original Message----- > > > From: Richardson, Bruce > > > Sent: Thursday, March 30, 2017 1:23 PM > > > To: Olivier Matz > > > Cc: dev@dpdk.org; Ananyev, Konstantin ;= mb@smartsharesystems.com; Chilikin, Andrey > > > ; jblunck@infradead.org; nelio.laranjeiro@= 6wind.com; arybchenko@solarflare.com > > > Subject: Re: [dpdk-dev] [PATCH 0/9] mbuf: structure reorganization > > > > > > On Thu, Mar 30, 2017 at 02:02:36PM +0200, Olivier Matz wrote: > > > > On Thu, 30 Mar 2017 10:31:08 +0100, Bruce Richardson wrote: > > > > > On Wed, Mar 29, 2017 at 09:09:23PM +0100, Bruce Richardson wrote: > > > > > > On Wed, Mar 29, 2017 at 05:56:29PM +0200, Olivier Matz wrote: > > > > > > > Hi, > > > > > > > > > > > > > > Does anyone have any other comment on this series? > > > > > > > Can it be applied? > > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > Olivier > > > > > > > > > > > > > > > > > > > I assume all driver maintainers have done performance analysis = to check > > > > > > for regressions. Perhaps they can confirm this is the case. > > > > > > > > > > > > /Bruce > > > > > > > > > > > > In the absence, of anyone else reporting performance numbers with= this > > > > > patchset, I ran a single-thread testpmd test using 2 x 40G ports = (i40e) > > > > > driver. With RX & TX descriptor ring sizes of 512 or above, I'm s= eeing a > > > > > fairly noticable performance drop. I still need to dig in more, e= .g. do > > > > > an RFC2544 zero-loss test, and also bisect the patchset to see wh= at > > > > > parts may be causing the problem. > > > > > > > > > > Has anyone else tried any other drivers or systems to see what th= e perf > > > > > impact of this set may be? > > > > > > > > I did, of course. I didn't see any noticeable performance drop on > > > > ixgbe (4 NICs, one port per NIC, 1 core). I can replay the test wit= h > > > > current version. > > > > > > > I had no doubt you did some perf testing! :-) > > > > > > Perhaps the regression I see is limited to i40e driver. I've confirme= d I > > > still see it with that driver in zero-loss tests, so next step is to = try > > > and localise what change in the patchset is causing it. > > > > > > Ideally, though, I think we should see acks or other comments from > > > driver maintainers at least confirming that they have tested. You can= not > > > be held responsible for testing every DPDK driver before you submit w= ork > > > like this. > > > > > > > Unfortunately I also see a regression. > > Did a quick flood test on 2.8 GHZ IVB with 4x10Gb. >=20 > Sorry, forgot to mention - it is on ixgbe. > So it doesn't look like i40e specific. >=20 > > Observed a drop even with default testpmd RXD/TXD numbers (128/512): > > from 50.8 Mpps down to 47.8 Mpps. > > From what I am seeing the particular patch that causing it: > > [dpdk-dev,3/9] mbuf: set mbuf fields while in pool > > > > cc version 5.3.1 20160406 (Red Hat 5.3.1-6) (GCC) > > cmdline: > > ./dpdk.org-1705-mbuf1/x86_64-native-linuxapp-gcc/app/testpmd --lcores= =3D'7,8' -n 4 --socket-mem=3D'1024,0' -w 04:00.1 -w 07:00.1 -w > > 0b:00.1 -w 0e:00.1 -- -i > > Actually one more question regarding: [dpdk-dev,9/9] mbuf: reorder VLAN tci and buffer len fields diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index fd97bd3..ada98d5 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/rte_mbuf.h @@ -449,8 +449,7 @@ struct rte_mbuf { =20 uint32_t pkt_len; /**< Total pkt len: sum of all segments. */ uint16_t data_len; /**< Amount of data in segment buffer. */ - /** VLAN TCI (CPU order), valid if PKT_RX_VLAN_STRIPPED is set. */ - uint16_t vlan_tci; + uint16_t buf_len; /**< Size of segment buffer. */ =20 union { uint32_t rss; /**< RSS hash result if RSS enabled */ @@ -475,11 +474,11 @@ struct rte_mbuf { uint32_t usr; /**< User defined tags. See rte_distributor_process() */ } hash; /**< hash information */ =20 + /** VLAN TCI (CPU order), valid if PKT_RX_VLAN_STRIPPED is set. */ + uint16_t vlan_tci; /** Outer VLAN TCI (CPU order), valid if PKT_RX_QINQ_STRIPPED is set. */ uint16_t vlan_tci_outer; =20 - uint16_t buf_len; /**< Length of segment buffer. */ - /** Valid if PKT_RX_TIMESTAMP is set. The unit and time reference * are not normalized but are always the same for a given port. */ How ixgbe and i40e SSE version supposed to work correctly after that chang= e? As I remember both of them sets vlan_tci as part of 16B shuffle operation. Something like that: pkt_mb4 =3D _mm_shuffle_epi8(descs[3], shuf_msk); ... mm_storeu_si128((void *)&rx_pkts[pos+3]->rx_descriptor_fields1, pkt_mb4); But now vlan_tci is swapped with buf_len. Which means 2 things to me: It is more than 16B away from rx_descriptor_fields1 and can't be updated in= one go anymore, and instead of vlan_tci we are updating buf_len.