From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 9FB802C5 for ; Thu, 6 Apr 2017 11:03:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491469386; x=1523005386; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=d7wPAdX4CXBbtbQyGNEDHvODSnm+pcJejqOoVN7AYoY=; b=uC0/JcR9mR8cQuGSkRCWCN7fMXmX45Y5MiAML1/ugB4Yf0Irboy366ck a1ZcLahYmgh4FsMGnsrsSShTr9T6Gg==; Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Apr 2017 02:02:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,283,1488873600"; d="scan'208";a="85146596" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga005.fm.intel.com with ESMTP; 06 Apr 2017 02:02:40 -0700 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.12]) by IRSMSX106.ger.corp.intel.com ([169.254.8.202]) with mapi id 14.03.0319.002; Thu, 6 Apr 2017 10:02:39 +0100 From: "Ananyev, Konstantin" To: "Zhao1, Wei" , Thomas Monjalon CC: "Mcnamara, John" , "dev@dpdk.org" , "Lu, Wenzhuo" Thread-Topic: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for port reset Thread-Index: AQHSrrNiO8YXQ3WeEE6IcJDuBUiyCqG4C3bQ Date: Thu, 6 Apr 2017 09:02:39 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772583FAE5871@IRSMSX109.ger.corp.intel.com> References: <1490866456-52241-1-git-send-email-wei.zhao1@intel.com> <2969664.trJitADFWx@xps13> <2978037.PdPlo8nOdn@xps13> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for port reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Apr 2017 09:03:07 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhao1, Wei > Sent: Thursday, April 6, 2017 9:53 AM > To: Thomas Monjalon > Cc: Mcnamara, John ; dev@dpdk.org; Lu, Wenzhuo <= wenzhuo.lu@intel.com> > Subject: Re: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for = port reset >=20 > Hi, Thomas >=20 > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Thursday, April 6, 2017 3:11 PM > > To: Zhao1, Wei > > Cc: Mcnamara, John ; dev@dpdk.org; Lu, > > Wenzhuo > > Subject: Re: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support fo= r port > > reset > > > > 2017-04-06 02:57, Zhao1, Wei: > > > > /** > > > > > + * Reset an ethernet device when it's not working. One scenario > > > > > + is, after PF > > > > > + * port is down and up, the related VF port should be reset. > > > > > + * The API will stop the port, clear the rx/tx queues, re-setup > > > > > + the rx/tx > > > > > + * queues, restart the port. > > > > > > > > s/The API/This function/ > > > > > > > > Please explain exactly the responsibility of this function, and how > > > > it is different from calling stop/configure/start. > > > > > > In this reset feature, reset function can do the calling > > > stop/configure/start process, but also It can also do some restore > > > work for the port, for example, it can restore the added parameters = of > > vlan, mac_addrs, promisc_unicast_enabled falg and > > promisc_multicast_enabled flag. Ok, but why start/stop can't do these things? Konstantin > > > Maybe , I should add this explanation in the patch comments or functi= on > > comments? > > > > Yes it must be explain in the doxygen part of the function. >=20 > Yes, I have add that explanation in v5 which has been commit to dpdk.org.