From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <konstantin.ananyev@intel.com> Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 1E76268C1 for <dev@dpdk.org>; Tue, 9 May 2017 20:09:39 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2017 11:09:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,315,1491289200"; d="scan'208";a="99370954" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga005.fm.intel.com with ESMTP; 09 May 2017 11:09:37 -0700 Received: from irsmsx109.ger.corp.intel.com ([169.254.13.12]) by IRSMSX101.ger.corp.intel.com ([163.33.3.153]) with mapi id 14.03.0319.002; Tue, 9 May 2017 19:09:37 +0100 From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com> To: Shahaf Shuler <shahafs@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [dpdk-dev] [PATCH] doc: announce ABI change on ethdev Thread-Index: AQHSwkhikR+coX9/fk+wOHyOmxBF+qHsS1Ug Date: Tue, 9 May 2017 18:09:35 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772583FAF3AA1@IRSMSX109.ger.corp.intel.com> References: <20170501065812.5185-1-shahafs@mellanox.com> In-Reply-To: <20170501065812.5185-1-shahafs@mellanox.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change on ethdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 09 May 2017 18:09:40 -0000 >=20 > This is an ABI change notice for DPDK 17.08 in librte_ether > about changes in rte_eth_txmode structure. >=20 > Currently Tx offloads are enabled by default, and can be disabled > using ETH_TXQ_FLAGS_NO* flags. This behaviour is not consistent with > the Rx side where the Rx offloads are disabled by default and enabled > according to bit field in rte_eth_rxmode structure. >=20 > The proposal is to disable the Tx offloads by default, and provide > a way for the application to enable them in rte_eth_txmode structure. > Besides of making the Tx configuration API more consistent for > applications, PMDs will be able to provide a better out of the > box performance. > Finally, as part of the work, the ETH_TXQ_FLAGS_NO* will > be superseded as well. >=20 > Signed-off-by: Shahaf Shuler <shahafs@mellanox.com> > --- > looks like this patch has arrived to everyone > besides dev@dpdk.org resending it again. sorry for > the noise. > --- > doc/guides/rel_notes/deprecation.rst | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/= deprecation.rst > index a3e7c720c..0920b4766 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -81,3 +81,11 @@ Deprecation Notices >=20 > - ``rte_crpytodev_scheduler_mode_get``, replaced by ``rte_cryptodev_sc= heduler_mode_get`` > - ``rte_crpytodev_scheduler_mode_set``, replaced by ``rte_cryptodev_sc= heduler_mode_set`` > + > +* ethdev: in 17.08 ABI changes are planned: > + Tx offloads will no longer be enabled by default. > + Instead, the ``rte_eth_txmode`` structure will be extended with bit fi= eld to enable > + each Tx offload. > + Besides of making the Rx/Tx configuration API more consistent for the > + application, PMDs will be able to provide a better out of the box perf= ormance. > + as part of the work, ``ETH_TXQ_FLAGS_NO*`` will be superseded as well. Seems ok to me, the only extra suggestion I have: instead of introducing new bit-fields can we make txmode (and rxmode) to use DEV_TX_OFFLOAD_(DEV_RX_OFFLOAD_)* values to specify desired tx(/rx) offloads. Konstantin > -- > 2.12.0