From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 6E84F7D36 for ; Wed, 23 Aug 2017 12:31:36 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP; 23 Aug 2017 03:31:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,416,1498546800"; d="scan'208";a="1209351522" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by fmsmga002.fm.intel.com with ESMTP; 23 Aug 2017 03:31:33 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by irsmsx110.ger.corp.intel.com (163.33.3.25) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 23 Aug 2017 11:31:32 +0100 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.25]) by irsmsx155.ger.corp.intel.com ([169.254.14.86]) with mapi id 14.03.0319.002; Wed, 23 Aug 2017 11:31:32 +0100 From: "Ananyev, Konstantin" To: David Harton , "wenzhuo.lu@intel.co" CC: "dev@dpdk.org" Thread-Topic: [PATCH] ixgbe: initialize scattered_rx during dev_configure Thread-Index: AQHTG6/bIBjqpcbPNEGUx7Y5b9b3KaKRvbSQ Date: Wed, 23 Aug 2017 10:31:31 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258489B4F98@irsmsx105.ger.corp.intel.com> References: <20170823013333.40576-1-dharton@cisco.com> In-Reply-To: <20170823013333.40576-1-dharton@cisco.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] ixgbe: initialize scattered_rx during dev_configure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Aug 2017 10:31:36 -0000 Hi David, >=20 > An application may want to manipulate the MTU settings of > a device without having to start the device first. > In order to remove the need to start the device the > ixgbe/ixgbevf drivers need to initialize the scattered_rx > value during dev_configure. Not sure how that would help? As I can see ixgbe_dev_mtu_set() uses rx_conf->enable_scatter=20 to check is multiseg RX allowed or not. Konstantin >=20 > Signed-off-by: David Harton > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_e= thdev.c > index 22171d8..e85bdb4 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -2372,6 +2372,13 @@ static int eth_ixgbevf_pci_remove(struct rte_pci_d= evice *pci_dev) > intr->flags |=3D IXGBE_FLAG_NEED_LINK_UPDATE; >=20 > /* > + * Update scattered_rx so we can update MTU immediately > + * following configure without having to start the device > + */ > + if (dev->data->dev_conf.rxmode.enable_scatter) > + dev->data->scattered_rx =3D 1; > + > + /* > * Initialize to TRUE. If any of Rx queues doesn't meet the bulk > * allocation or vector Rx preconditions we will reset it. > */ > @@ -4949,6 +4956,13 @@ static int ixgbevf_dev_xstats_get_names(__rte_unus= ed struct rte_eth_dev *dev, > #endif >=20 > /* > + * Update scattered_rx so we can update MTU immediately > + * following configure without having to start the device > + */ > + if (dev->data->dev_conf.rxmode.enable_scatter) > + dev->data->scattered_rx =3D 1; > + > + /* > * Initialize to TRUE. If any of Rx queues doesn't meet the bulk > * allocation or vector Rx preconditions we will reset it. > */ > -- > 1.8.3.1