From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 2A9651B5F1 for ; Thu, 2 Nov 2017 15:05:51 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP; 02 Nov 2017 07:05:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,334,1505804400"; d="scan'208";a="1238741819" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by fmsmga002.fm.intel.com with ESMTP; 02 Nov 2017 07:05:48 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.67]) by IRSMSX154.ger.corp.intel.com ([169.254.12.83]) with mapi id 14.03.0319.002; Thu, 2 Nov 2017 14:05:47 +0000 From: "Ananyev, Konstantin" To: "Wu, Yanglong" , "dev@dpdk.org" CC: "Wu, Yanglong" Thread-Topic: [dpdk-dev] [PATCH 2/2] net/ixgbe: fix l3fwd start failed on PF Thread-Index: AQHTU7u/MZdOQ4QDgkGdbU7zn+ZIbaMBHNOg Date: Thu, 2 Nov 2017 14:05:47 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772585FAB87A3@irsmsx105.ger.corp.intel.com> References: <20171102170432.168194-1-yanglong.wu@intel.com> <20171102170432.168194-2-yanglong.wu@intel.com> In-Reply-To: <20171102170432.168194-2-yanglong.wu@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDA4Y2MzY2EtODEwMy00YmViLTllYzYtNDNjYzdlMTEwMzNhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkFcL1g1cmtZaThSRTNtQjJWdEpRSzM1SVlhanFoWldybXlGMldIK1o0TERrPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/2] net/ixgbe: fix l3fwd start failed on PF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Nov 2017 14:05:52 -0000 Hi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yanglong Wu > Sent: Thursday, November 2, 2017 5:05 PM > To: dev@dpdk.org > Cc: Wu, Yanglong > Subject: [dpdk-dev] [PATCH 2/2] net/ixgbe: fix l3fwd start failed on PF >=20 > which occurred when the SRIOV is active and tx_q > rx_q. > The number of nb_q_per_pool should equeal to max number > of queues supported by HW not nb_rx_q. >=20 > Fixes: 27b609cbd1c6 (ethdev: move the multi-queue mode > check to specific drivers) >=20 > Signed-off-by: Yanglong Wu > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_e= thdev.c > index ae9c44421..0f0641da1 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -2180,7 +2180,7 @@ ixgbe_check_vf_rss_rxq_num(struct rte_eth_dev *dev,= uint16_t nb_rx_q) > return -EINVAL; > } >=20 > - RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool =3D nb_rx_q; > + RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool =3D 128/RTE_ETH_DEV_SRIOV(dev).act= ive; > RTE_ETH_DEV_SRIOV(dev).def_pool_q_idx =3D pci_dev->max_vfs * nb_rx_q; >=20 > return 0; > -- > 2.11.0 Not sure I understand what is the purpose of that patch... Do you want to prevent RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool =3D 1? =20 Konstantin =20