From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 8A4F51B334 for ; Wed, 8 Nov 2017 10:49:15 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Nov 2017 01:49:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,363,1505804400"; d="scan'208";a="333736533" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga004.fm.intel.com with ESMTP; 08 Nov 2017 01:49:12 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.67]) by IRSMSX151.ger.corp.intel.com ([169.254.4.108]) with mapi id 14.03.0319.002; Wed, 8 Nov 2017 09:49:11 +0000 From: "Ananyev, Konstantin" To: Jia He , "jerin.jacob@caviumnetworks.com" , "dev@dpdk.org" , "olivier.matz@6wind.com" CC: "Richardson, Bruce" , "jianbo.liu@arm.com" , "hemant.agrawal@nxp.com" , "jie2.liu@hxt-semitech.com" , "bing.zhao@hxt-semitech.com" , "jia.he@hxt-semitech.com" Thread-Topic: [PATCH 2/3] ring: guarantee load ordering of cons/prod when doing enqueue/dequeue Thread-Index: AQHTWFmFbZ8BWIhVukaR+PPDvkDB0aMKPJtA Date: Wed, 8 Nov 2017 09:49:11 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772585FABAC40@irsmsx105.ger.corp.intel.com> References: <1510121832-16439-1-git-send-email-hejianet@gmail.com> <1510121832-16439-2-git-send-email-hejianet@gmail.com> In-Reply-To: <1510121832-16439-2-git-send-email-hejianet@gmail.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTYyNjk0YjItMzg3MC00ODFjLWJiN2EtNDc5YWVjYTIzYzM2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImVDb1hsN2dvMmF1cFZTNkVwVk9aWUNqS01IQXpzNDBCSVZwMHlsWkF2NGM9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/3] ring: guarantee load ordering of cons/prod when doing enqueue/dequeue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Nov 2017 09:49:16 -0000 > + > +#define UNUSED_PARAMETER(x) ((void)(x)) > +static __rte_always_inline void > +update_tail(struct rte_ring_headtail *ht, uint32_t old_val, uint32_t new= _val, > + uint32_t single, uint32_t enqueue) > +{ > + UNUSED_PARAMETER(enqueue); As a nit you can use __rte_unused parameter attribute or RTE_SET_USED() macro here. Konstantin