From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id A165E2C54 for ; Mon, 20 Nov 2017 12:32:28 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Nov 2017 03:32:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,426,1505804400"; d="scan'208";a="3830570" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga004.fm.intel.com with ESMTP; 20 Nov 2017 03:32:25 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.67]) by IRSMSX101.ger.corp.intel.com ([169.254.1.22]) with mapi id 14.03.0319.002; Mon, 20 Nov 2017 11:32:25 +0000 From: "Ananyev, Konstantin" To: "Dai, Wei" , "Wu, Jingjing" , "Xing, Beilei" CC: "dev@dpdk.org" , "Dai, Wei" Thread-Topic: [dpdk-dev] [PATCH v3] net/i40e: determine number of queues per VF during run time Thread-Index: AQHTYT//3qPIDuv80kKDMtlrDilH16MdH/lw Date: Mon, 20 Nov 2017 11:32:24 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772585FABEAC3@irsmsx105.ger.corp.intel.com> References: <1511077425-27468-1-git-send-email-wei.dai@intel.com> <1511100484-42264-1-git-send-email-wei.dai@intel.com> In-Reply-To: <1511100484-42264-1-git-send-email-wei.dai@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzkzODU2NmItZGQyNi00ZjBmLTg4MzctMDYwZDlmOGMzNzc2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlJxcjY2bzZPREZnbWRHVWx2clVtdHRoZGNJNVFIcTh1bGl1bmpzRXFXWGM9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: determine number of queues per VF during run time X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Nov 2017 11:32:29 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Dai > Sent: Sunday, November 19, 2017 2:08 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Dai, Wei > Subject: [dpdk-dev] [PATCH v3] net/i40e: determine number of queues per V= F during run time >=20 > Without this patch, the number of queues per i40e VF is defined as 4 > by CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF=3D4 in config/common_base. > It is fixed value determined in building time and can't be changed > during run time. > With this patch, the number of queues per i40e VF can be determinated > during run time. For example, if the PCI address of an i40e VF is > aaaa:bb.cc, with the EAL parameter -w aaaa:bb.cc,i40e-queue-num-per-vf=3D= 8 > , the number of queues per VF is 8. > If there is no "i40e-queue-num-per-vf" setting in EAL parameters, > it is 4 by default as before. And if the value after the > "i40e-queue-num-per-vf" is invalid, it is set as 4 forcibly. > The valid values include 1, 2, 4, 8, 16 . >=20 > Signed-off-by: Wei Dai >=20 > --- > v3: fix WARNING of coding style issues from checkpatch@dpdk.org > v2: fix WARNING of coding style issues from checkpatch@dpdk.org > --- > config/common_base | 1 - > drivers/net/i40e/i40e_ethdev.c | 67 ++++++++++++++++++++++++++++++++++++= ++++-- > 2 files changed, 65 insertions(+), 3 deletions(-) >=20 > diff --git a/config/common_base b/config/common_base > index e74febe..4e20389 100644 > --- a/config/common_base > +++ b/config/common_base > @@ -208,7 +208,6 @@ CONFIG_RTE_LIBRTE_I40E_RX_ALLOW_BULK_ALLOC=3Dy > CONFIG_RTE_LIBRTE_I40E_INC_VECTOR=3Dy > CONFIG_RTE_LIBRTE_I40E_16BYTE_RX_DESC=3Dn > CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_PF=3D64 > -CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF=3D4 > CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_VM=3D4 > # interval up to 8160 us, aligned to 2 (or default value) > CONFIG_RTE_LIBRTE_I40E_ITR_INTERVAL=3D-1 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index 811cc9f..b23a39e 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -3971,6 +3971,67 @@ i40e_get_cap(struct i40e_hw *hw) > return ret; > } >=20 > +static int i40e_pf_config_vf_rxq_number(struct rte_eth_dev *dev) > +{ > +#define RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF 4 > +#define I40E_QUEUE_NUM_PER_VF_ARG "i40e-queue-num-per-vf" Does it need to have i40e prefix? Provably other HW type would support similar devarg? > + > + struct i40e_pf *pf =3D I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private); > + char *s; > + char *ps0, *ps1, *pv; > + char *end; > + unsigned long value; > + > + if (!is_i40e_supported(dev)) > + return -ENOTSUP; Not a big deal - but that function is static, so I suppose the check is red= undant. > + > + /* set default queue number per VF as 4 */ > + pf->vf_nb_qp_max =3D RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF; > + > + if (dev->device->devargs =3D=3D NULL) > + return 0; > + > + s =3D rte_zmalloc(__func__, strlen(dev->device->devargs->args) + 1, 0); No need to allocate temp memory from hugepages here. Normal malloc, or even alloca() would do, I think. > + if (s =3D=3D NULL) > + return -(ENOMEM); > + strcpy(s, dev->device->devargs->args); > + What is the point to write your own parsing function from scratch? Why just not use rte_kvargs API as most other PMDs do? BTW, i40e does the same in few other places. > + ps0 =3D s; > + do { > + while (isblank(*ps0)) > + ps0++; > + pv =3D strchr(ps0, '=3D'); > + if (pv =3D=3D NULL) > + break; > + ps1 =3D pv - 1; > + *pv++ =3D 0; > + > + while (isblank(*ps1)) > + *ps1-- =3D 0; > + > + if (!strcmp(ps0, I40E_QUEUE_NUM_PER_VF_ARG)) { > + errno =3D 0; > + value =3D strtoul(pv, &end, 0); > + if (errno !=3D 0 || end =3D=3D pv) That wouldn't catch something like ...=3D1blah, Should be *end !=3D '0' (or whatever your stop-character is). Anyway would be much better to use kvargs. Even better to have a common function, something like: int devargs_get_uint(const struct rte_devargs *devargs, const char *name,ui= nt64_t *value); and use it in all appropriate places. Konstantin > + break; > + if (value <=3D 16 && rte_is_power_of_2(value)) > + pf->vf_nb_qp_max =3D (uint16_t)value; > + else > + PMD_DRV_LOG(ERR, "Wrong VF queue number =3D %lu," > + " it must be power of 2 and equal or" > + " less than 16 !", value); > + break; > + } > + ps0 =3D strchr(pv, ','); > + if (ps0 =3D=3D NULL) > + break; > + ps0++; > + } while (1); > + > + rte_free(s); > + return 0; > +} > + > static int > i40e_pf_parameter_init(struct rte_eth_dev *dev) > { > @@ -3983,6 +4044,9 @@ i40e_pf_parameter_init(struct rte_eth_dev *dev) > PMD_INIT_LOG(ERR, "HW configuration doesn't support SRIOV"); > return -EINVAL; > } > + > + i40e_pf_config_vf_rxq_number(dev); > + > /* Add the parameter init for LFC */ > pf->fc_conf.pause_time =3D I40E_DEFAULT_PAUSE_TIME; > pf->fc_conf.high_water[I40E_MAX_TRAFFIC_CLASS] =3D I40E_DEFAULT_HIGH_WA= TER; > @@ -3992,7 +4056,6 @@ i40e_pf_parameter_init(struct rte_eth_dev *dev) > pf->max_num_vsi =3D hw->func_caps.num_vsis; > pf->lan_nb_qp_max =3D RTE_LIBRTE_I40E_QUEUE_NUM_PER_PF; > pf->vmdq_nb_qp_max =3D RTE_LIBRTE_I40E_QUEUE_NUM_PER_VM; > - pf->vf_nb_qp_max =3D RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF; >=20 > /* FDir queue/VSI allocation */ > pf->fdir_qp_offset =3D 0; > @@ -4022,7 +4085,7 @@ i40e_pf_parameter_init(struct rte_eth_dev *dev) > pf->vf_qp_offset =3D pf->lan_qp_offset + pf->lan_nb_qps; > if (hw->func_caps.sr_iov_1_1 && pci_dev->max_vfs) { > pf->flags |=3D I40E_FLAG_SRIOV; > - pf->vf_nb_qps =3D RTE_LIBRTE_I40E_QUEUE_NUM_PER_VF; > + pf->vf_nb_qps =3D pf->vf_nb_qp_max; > pf->vf_num =3D pci_dev->max_vfs; > PMD_DRV_LOG(DEBUG, > "%u VF VSIs, %u queues per VF VSI, in total %u queues", > -- > 2.7.5