From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id D0CD29FE for ; Tue, 12 Dec 2017 12:03:28 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Dec 2017 03:03:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,394,1508828400"; d="scan'208";a="15311657" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga001.jf.intel.com with ESMTP; 12 Dec 2017 03:03:26 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.67]) by IRSMSX153.ger.corp.intel.com ([169.254.9.34]) with mapi id 14.03.0319.002; Tue, 12 Dec 2017 11:03:25 +0000 From: "Ananyev, Konstantin" To: Matan Azrad , Nikhil Agarwal , "dev@dpdk.org" CC: "Hunt, David" , "nikhil.agarwal@nxp.com" , "hemant.agrawal@nxp.com" , "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [PATCH 1/3] ethdev: add max burst size to device info Thread-Index: AQHTczFaMkIQuwnzV0mmnzV+yu3+C6M/hlMAgAAD6DA= Date: Tue, 12 Dec 2017 11:03:24 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772585FAC8785@irsmsx105.ger.corp.intel.com> References: <20171212100520.20502-1-nikhil.agarwal@linaro.org> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmMzYjgxMTctNzM2OC00YTBjLThjMGUtZDUwMjgxYWNhNTJiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik0yMk9CWSsxSnhYQUlPVjFsdGE1TEpVQm1ITVZ0KzdIeUdiZ2doUHJVd0U9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/3] ethdev: add max burst size to device info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Dec 2017 11:03:29 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Matan Azrad > Sent: Tuesday, December 12, 2017 10:46 AM > To: Nikhil Agarwal ; dev@dpdk.org > Cc: Hunt, David ; nikhil.agarwal@nxp.com; hemant.ag= rawal@nxp.com; Yigit, Ferruh > Subject: Re: [dpdk-dev] [PATCH 1/3] ethdev: add max burst size to device = info >=20 > Hi Nikhil >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Nikhil Agarwal > > Sent: Tuesday, December 12, 2017 12:05 PM > > To: dev@dpdk.org > > Cc: david.hunt@intel.com; nikhil.agarwal@nxp.com; > > hemant.agrawal@nxp.com; ferruh.yigit@intel.com > > Subject: [dpdk-dev] [PATCH 1/3] ethdev: add max burst size to device in= fo > > > > Currently, if the rte_eth_rx_burst() function returns a value less tha= n > > *nb_pkts*, the application will assume that no more packets are present= . > > > > Some of the hw queue based hardware can only support smaller burst for = RX > > and TX and thus break the expectation of the rx_burst API. > > >=20 > Doesn't such like devices PMDs should try to retrieve multiple HW burst t= o adjust the asked received packet number? Same thought here... Can't that limitation be hidden inside PMD by calling HW burst multiple tim= es?=20 Also if I am not mistaken - it would increase size of struct rte_eth_dev_in= fo, right? If so, then it means ABI breakage. Konstantin >=20 > > This patch adds support to provide the maximum burst size that can be > > supported by a given PMD. The dev_info is being memset to '0' in > > rte_ethdev library. The value of '0' indicates that any value for burst= size can > > be supported i.e. no change for existing PMDs. > > > > The application can now use the lowest available max_burst_size value f= or > > rte_eth_rx_burst. > > >=20 > If you are talking about performance, maybe the right field to expose is = something like "perf_burst_size" or "preferred_burst_size". > I also suggest to expose different fields for RX and for TX. > Maybe the rte_eth_rx\tx_burst() descriptions should be updated. >=20 > Thanks > Matan. >=20 > > Signed-off-by: Nikhil Agarwal > > --- > > lib/librte_ether/rte_ethdev.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethde= v.h > > index 341c2d6..3ab6f02 100644 > > --- a/lib/librte_ether/rte_ethdev.h > > +++ b/lib/librte_ether/rte_ethdev.h > > @@ -1047,6 +1047,7 @@ struct rte_eth_dev_info { > > /** Configured number of rx/tx queues */ > > uint16_t nb_rx_queues; /**< Number of RX queues. */ > > uint16_t nb_tx_queues; /**< Number of TX queues. */ > > + uint16_t max_burst_size; /**< MAX burst size, 0 for no limit. */ > > }; > > > > /** > > -- > > 2.7.4