From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 8E04E1B20D; Wed, 10 Jan 2018 10:58:41 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2018 01:58:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,339,1511856000"; d="scan'208";a="9266733" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga007.jf.intel.com with ESMTP; 10 Jan 2018 01:58:39 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.67]) by IRSMSX101.ger.corp.intel.com ([169.254.1.46]) with mapi id 14.03.0319.002; Wed, 10 Jan 2018 09:58:38 +0000 From: "Ananyev, Konstantin" To: "Dai, Wei" , "Yang, Qiming" , "Peng, Yuan" , "Lu, Wenzhuo" , "Wu, Jingjing" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v3 0/2] app/testpmd: fix invalid rxq and txq nubmer setting Thread-Index: AQHTifEEpjYIY+bDbUODosuJumwTRqNs3oLA Date: Wed, 10 Jan 2018 09:58:37 +0000 Message-ID: <2601191342CEEE43887BDE71AB97725880E3B510@irsmsx105.ger.corp.intel.com> References: <1515557660-36763-1-git-send-email-wei.dai@intel.com> <1515573656-41847-1-git-send-email-wei.dai@intel.com> In-Reply-To: <1515573656-41847-1-git-send-email-wei.dai@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDE4MjIxYTAtODNkZS00MWQ5LWJmMmQtOTUwMTFkNGUzNjM4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlQxbE9ybW9rbzh0MlV3ZkQyYlBkanN2STdkc2FyeHFBcTBkWndqNFFrckU9In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 0/2] app/testpmd: fix invalid rxq and txq nubmer setting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 09:58:42 -0000 > -----Original Message----- > From: Dai, Wei > Sent: Wednesday, January 10, 2018 8:41 AM > To: Ananyev, Konstantin ; Yang, Qiming ; Peng, Yuan ; > Lu, Wenzhuo ; Wu, Jingjing > Cc: dev@dpdk.org; stable@dpdk.org; Dai, Wei > Subject: [PATCH v3 0/2] app/testpmd: fix invalid rxq and txq nubmer setti= ng >=20 > If an invlaid number of RX or TX queues is configured from testpmd > command like "port config all rxq number" or "port config all txq number"= . > The global variable rxq or txq is updated by the invalid input. > This can cause testpmd crash. For example, if the maximum number of > RX or TX queues is 4, testpmd will crash after running commands > "port config all rxq 5", "port config all txq 5" and "start" in sequence. >=20 > These 2 patches reserve the last correct rxq and txq, if an invalid input > is detected, it is restored to the backup value to avoid crash. >=20 > Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") > Cc: stable@dpdk.org >=20 > Signed-off-by: Wei Dai >=20 > --- The code looks good to me, just seems some misspellings in the comments (mi= mumal). Acked-by: Konstantin Ananyev > v3: follow the guide from Konstantin to use functions to check > input rxq and txq instead of usage of new added global variables. >=20 > v2: fix a bug in v1 >=20 >=20 > Wei Dai (2): > app/testpmd: fix invalid rxq number setting > app/testpmd: fix invalid txq number setting >=20 > app/test-pmd/cmdline.c | 4 ++ > app/test-pmd/parameters.c | 13 ++++--- > app/test-pmd/testpmd.c | 94 +++++++++++++++++++++++++++++++++++++++++= ++++++ > app/test-pmd/testpmd.h | 5 +++ > 4 files changed, 110 insertions(+), 6 deletions(-) >=20 > -- > 2.7.5