From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <konstantin.ananyev@intel.com>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by dpdk.org (Postfix) with ESMTP id 6C2261B7E6
 for <dev@dpdk.org>; Fri,  9 Feb 2018 14:22:54 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
 by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 09 Feb 2018 05:22:53 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,483,1511856000"; d="scan'208";a="202664502"
Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31])
 by fmsmga005.fm.intel.com with ESMTP; 09 Feb 2018 05:22:51 -0800
Received: from irsmsx105.ger.corp.intel.com ([169.254.7.221]) by
 IRSMSX106.ger.corp.intel.com ([169.254.8.62]) with mapi id 14.03.0319.002;
 Fri, 9 Feb 2018 13:22:06 +0000
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, Neil Horman
 <nhorman@tuxdriver.com>, "Mcnamara, John" <john.mcnamara@intel.com>,
 "Kovacevic, Marko" <marko.kovacevic@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, Stephen Hemminger
 <stephen@networkplumber.org>, "Richardson, Bruce"
 <bruce.richardson@intel.com>, Thomas Monjalon <thomas@monjalon.net>
Thread-Topic: [PATCH v2] doc: update ethdev APIs to return named opaque type
Thread-Index: AQHToY9WFuYUneT+dU6nV+A2eA7R/KOcDq3A
Date: Fri, 9 Feb 2018 13:22:06 +0000
Message-ID: <2601191342CEEE43887BDE71AB977258905710B0@irsmsx105.ger.corp.intel.com>
References: <20180209101119.69860-1-ferruh.yigit@intel.com>
 <20180209101818.70041-1-ferruh.yigit@intel.com>
In-Reply-To: <20180209101818.70041-1-ferruh.yigit@intel.com>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTE1OGZjNTctYjZhYS00MzcyLThlYTUtODMyYzY5NGZkOTMyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjZBbVc5K2NPRG0xVW9zaFdnSlFcL09LUGFVSmFcL0ozOWt6Z0JLQ2FaUzFIbz0ifQ==
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.0.116
dlp-reaction: no-action
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2] doc: update ethdev APIs to return named
	opaque type
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Feb 2018 13:22:55 -0000



> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Friday, February 9, 2018 10:18 AM
> To: Neil Horman <nhorman@tuxdriver.com>; Mcnamara, John <john.mcnamara@in=
tel.com>; Kovacevic, Marko
> <marko.kovacevic@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Ananyev, Konsta=
ntin <konstantin.ananyev@intel.com>; Stephen Hemminger
> <stephen@networkplumber.org>; Richardson, Bruce <bruce.richardson@intel.c=
om>; Thomas Monjalon <thomas@monjalon.net>
> Subject: [PATCH v2] doc: update ethdev APIs to return named opaque type
>=20
> Ethdev APIs to add callback return the callback object as "void *",
> update return type to actual object type
> "struct rte_eth_rxtx_callback *"
>=20
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: Konstantin Ananyev <konstantin.ananyev@intel.com>
> Cc: Stephen Hemminger <stephen@networkplumber.org>
> Cc: Bruce Richardson <bruce.richardson@intel.com>
> Cc: Thomas Monjalon <thomas@monjalon.net>
> ---
>  doc/guides/rel_notes/deprecation.rst | 7 +++++++
>  1 file changed, 7 insertions(+)
>=20
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/=
deprecation.rst
> index bbd9456a7..5cb5a00d2 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -49,6 +49,13 @@ Deprecation Notices
>    rte_eth_dev_get_sec_ctx() is using uint8_t for port_id, which should b=
e
>    uint16_t.
>=20
> +* ethdev: functions add rx/tx callback will return named opaque type
> +  rte_eth_add_rx_callback(), rte_eth_add_first_rx_callback() and
> +  rte_eth_add_tx_callback() functions currently return callback object a=
s
> +  "void \*" but APIs to delete callbacks get "struct rte_eth_rxtx_callba=
ck \*"
> +  as parameter. For consistency functions adding callback will return
> +  "struct rte_eth_rxtx_callback \*" instead of "void * ".
> +
>  * i40e: The default flexible payload configuration which extracts the fi=
rst 16
>    bytes of the payload for RSS will be deprecated starting from 18.02. I=
f
>    required the previous behavior can be configured using existing flow
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

> 2.14.3