From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id B9ADB5F71 for ; Thu, 15 Mar 2018 00:18:47 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2018 16:18:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,307,1517904000"; d="scan'208";a="24747137" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga007.jf.intel.com with ESMTP; 14 Mar 2018 16:18:44 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.221]) by IRSMSX152.ger.corp.intel.com ([169.254.6.52]) with mapi id 14.03.0319.002; Wed, 14 Mar 2018 23:18:43 +0000 From: "Ananyev, Konstantin" To: "Dai, Wei" , "Lu, Wenzhuo" CC: "dev@dpdk.org" Thread-Topic: [PATCH 4/4] net/ixgbe: convert to new Tx offloads API Thread-Index: AQHTr+a2g3i99IHEHkWlrol+iGl26qPQdSkg Date: Wed, 14 Mar 2018 23:18:43 +0000 Message-ID: <2601191342CEEE43887BDE71AB9772589E28FDE7@irsmsx105.ger.corp.intel.com> References: <1519747291-6969-1-git-send-email-wei.dai@intel.com> <1519747291-6969-5-git-send-email-wei.dai@intel.com> In-Reply-To: <1519747291-6969-5-git-send-email-wei.dai@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWM1YzQ2ZjctY2NkYi00ZjA5LWIwYWYtZGUyYjA5MTk3MTMwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkFrV1E2QncxVWFWU25udkNvd1AramlPN1g0OEhSSlFPeVpjV2hkXC9Qbm5RPSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 4/4] net/ixgbe: convert to new Tx offloads API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2018 23:18:48 -0000 > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.h b/drivers/net/ixgbe/ixgbe_rxt= x.h > index 30095fa..d7f0535 100644 > --- a/drivers/net/ixgbe/ixgbe_rxtx.h > +++ b/drivers/net/ixgbe/ixgbe_rxtx.h > @@ -223,6 +223,7 @@ struct ixgbe_tx_queue { > uint8_t hthresh; /**< Host threshold register. */ > uint8_t wthresh; /**< Write-back threshold reg. */ > uint32_t txq_flags; /**< Holds flags for this TXq */ > + uint64_t offloads; /**< Tx offload flags of DEV_TX_OFFLOAD_* */ > uint32_t ctx_curr; /**< Hardware context states. */ > /** Hardware context0 history. */ > struct ixgbe_advctx_info ctx_cache[IXGBE_CTX_NUM]; > @@ -254,6 +255,12 @@ struct ixgbe_txq_ops { > #define IXGBE_SIMPLE_FLAGS ((uint32_t)ETH_TXQ_FLAGS_NOMULTSEGS | \ > ETH_TXQ_FLAGS_NOOFFLOADS) >=20 > +#define IXGBE_SIMPLE_TX_OFFLOAD_FLAGS ((uint64_t)DEV_TX_OFFLOAD_MULTI_SE= GS |\ > + DEV_TX_OFFLOAD_VLAN_INSERT |\ > + DEV_TX_OFFLOAD_SCTP_CKSUM |\ > + DEV_TX_OFFLOAD_UDP_CKSUM |\ > + DEV_TX_OFFLOAD_TCP_CKSUM) Hmm and why IP_CKSUM, TSO, OUTER_IP_CKSUM, etc. is not included into that m= acro? In fact do you really need that? As I understand right now vector TX doesn't support any offloads, so tx_off= load !=3D 0, should be enough for tx function selection, right? Konstanitn=20 > + > /* > * Populate descriptors with the following info: > * 1.) buffer_addr =3D phys_addr + headroom > @@ -307,6 +314,7 @@ uint16_t ixgbe_xmit_fixed_burst_vec(void *tx_queue, s= truct rte_mbuf **tx_pkts, > uint16_t nb_pkts); > int ixgbe_txq_vec_setup(struct ixgbe_tx_queue *txq); >=20 > +uint64_t ixgbe_get_tx_port_offlaods(struct rte_eth_dev *dev); > uint64_t ixgbe_get_rx_queue_offloads(struct rte_eth_dev *dev); > uint64_t ixgbe_get_rx_port_offloads(struct rte_eth_dev *dev); >=20 > -- > 2.7.5