From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <konstantin.ananyev@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
by dpdk.org (Postfix) with ESMTP id 21EBC7272
for <dev@dpdk.org>; Thu, 15 Mar 2018 14:22:42 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
15 Mar 2018 06:22:41 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.48,310,1517904000"; d="scan'208";a="38231965"
Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66])
by fmsmga001.fm.intel.com with ESMTP; 15 Mar 2018 06:22:41 -0700
Received: from irsmsx105.ger.corp.intel.com ([169.254.7.221]) by
IRSMSX152.ger.corp.intel.com ([169.254.6.52]) with mapi id 14.03.0319.002;
Thu, 15 Mar 2018 13:22:40 +0000
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>, "thomas@monjalon.net"
<thomas@monjalon.net>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Xing, Beilei" <beilei.xing@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v2 4/4] net/i40e: enable deferred queue setup
Thread-Index: AQHTsdzniCAjXGTwQUq3PD1jD08qQaPPvVLQgAD4joCAAKZDgA==
Date: Thu, 15 Mar 2018 13:22:39 +0000
Message-ID: <2601191342CEEE43887BDE71AB9772589E290215@irsmsx105.ger.corp.intel.com>
References: <20180212045314.171616-1-qi.z.zhang@intel.com>
<20180302041306.90324-1-qi.z.zhang@intel.com>
<20180302041306.90324-5-qi.z.zhang@intel.com>
<2601191342CEEE43887BDE71AB9772589E28FA78@irsmsx105.ger.corp.intel.com>
<039ED4275CED7440929022BC67E706115316DF28@SHSMSX103.ccr.corp.intel.com>
In-Reply-To: <039ED4275CED7440929022BC67E706115316DF28@SHSMSX103.ccr.corp.intel.com>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjc1ZjcxZTctYjBiMi00ZjU3LWJhMGItNzg4NzM0ZWIzNDdkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ikg2T1AzSHkwT0tGdzI3UDhIeURPNmRvSTFEXC9jVjc1SlZHOXdXQ0FacFM0PSJ9
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.0.116
dlp-reaction: no-action
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 4/4] net/i40e: enable deferred queue setup
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Mar 2018 13:22:43 -0000
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Thursday, March 15, 2018 3:22 AM
> To: Ananyev, Konstantin <konstantin.ananyev@intel.com>; thomas@monjalon.n=
et
> Cc: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing <jin=
gjing.wu@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v2 4/4] net/i40e: enable deferred queue se=
tup
>=20
>=20
>=20
> > -----Original Message-----
> > From: Ananyev, Konstantin
> > Sent: Wednesday, March 14, 2018 8:36 PM
> > To: Zhang, Qi Z <qi.z.zhang@intel.com>; thomas@monjalon.net
> > Cc: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing
> > <jingjing.wu@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhang, Qi =
Z
> > <qi.z.zhang@intel.com>
> > Subject: RE: [dpdk-dev] [PATCH v2 4/4] net/i40e: enable deferred queue
> > setup
> >
> >
> >
> > > -----Original Message-----
> > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qi Zhang
> > > Sent: Friday, March 2, 2018 4:13 AM
> > > To: thomas@monjalon.net
> > > Cc: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing
> > > <jingjing.wu@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhang,
> > Qi
> > > Z <qi.z.zhang@intel.com>
> > > Subject: [dpdk-dev] [PATCH v2 4/4] net/i40e: enable deferred queue
> > > setup
> > >
> > > Expose the deferred queue configuration capability and enhance
> > > i40e_dev_[rx|tx]_queue_[setup|release] to handle the situation when
> > > device already started.
> > >
> > > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> > > ---
> > > drivers/net/i40e/i40e_ethdev.c | 6 ++++
> > > drivers/net/i40e/i40e_rxtx.c | 62
> > ++++++++++++++++++++++++++++++++++++++++--
> > > 2 files changed, 66 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/net/i40e/i40e_ethdev.c
> > > b/drivers/net/i40e/i40e_ethdev.c index 06b0f03a1..843a0c42a 100644
> > > --- a/drivers/net/i40e/i40e_ethdev.c
> > > +++ b/drivers/net/i40e/i40e_ethdev.c
> > > @@ -3195,6 +3195,12 @@ i40e_dev_info_get(struct rte_eth_dev *dev,
> > struct rte_eth_dev_info *dev_info)
> > > DEV_TX_OFFLOAD_GRE_TNL_TSO |
> > > DEV_TX_OFFLOAD_IPIP_TNL_TSO |
> > > DEV_TX_OFFLOAD_GENEVE_TNL_TSO;
> > > + dev_info->deferred_queue_config_capa =3D
> > > + DEV_DEFERRED_RX_QUEUE_SETUP |
> > > + DEV_DEFERRED_TX_QUEUE_SETUP |
> > > + DEV_DEFERRED_RX_QUEUE_RELEASE |
> > > + DEV_DEFERRED_TX_QUEUE_RELEASE;
> > > +
> > > dev_info->hash_key_size =3D (I40E_PFQF_HKEY_MAX_INDEX + 1) *
> > > sizeof(uint32_t);
> > > dev_info->reta_size =3D pf->hash_lut_size; diff --git
> > > a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index
> > > 1217e5a61..e5f532cf7 100644
> > > --- a/drivers/net/i40e/i40e_rxtx.c
> > > +++ b/drivers/net/i40e/i40e_rxtx.c
> > > @@ -1712,6 +1712,7 @@ i40e_dev_rx_queue_setup(struct rte_eth_dev
> > *dev,
> > > uint16_t len, i;
> > > uint16_t reg_idx, base, bsf, tc_mapping;
> > > int q_offset, use_def_burst_func =3D 1;
> > > + int ret =3D 0;
> > >
> > > if (hw->mac.type =3D=3D I40E_MAC_VF || hw->mac.type =3D=3D
> > I40E_MAC_X722_VF) {
> > > vf =3D I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
> > > @@ -1841,6 +1842,25 @@ i40e_dev_rx_queue_setup(struct rte_eth_dev
> > *dev,
> > > rxq->dcb_tc =3D i;
> > > }
> > >
> > > + if (dev->data->dev_started) {
> > > + ret =3D i40e_rx_queue_init(rxq);
> > > + if (ret !=3D I40E_SUCCESS) {
> > > + PMD_DRV_LOG(ERR,
> > > + "Failed to do RX queue initialization");
> > > + return ret;
> > > + }
> > > + if (ad->rx_vec_allowed)
> >
> > Better to check what rx function is installed right now.
> Yes, it should be fixed, need to return fail if any conflict
> >
> > > + i40e_rxq_vec_setup(rxq);
> > > + if (!rxq->rx_deferred_start) {
> > > + ret =3D i40e_dev_rx_queue_start(dev, queue_idx);
> >
> > I don't think it is a good idea to start/stop queue inside
> > queue_setup/queue_release.
> > There is special API (queue_start/queue_stop) to do this.
>=20
> The idea is if dev already started, the queue is supposed to be started a=
utomatically after queue_setup.
Why is that?
Might be user doesn't want to start queue, might be he only wants to start =
it.
Might be he would need to call queue_setup() once again later before starti=
ng it - based on some logic?
If the user wants to setup and start the queue immediately he can always do=
:
rc =3D queue_setup(...);
if (rc =3D=3D 0)
queue_start(...);
We have a pretty well defined API here let's keep it like that.
Konstantin