DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/ixgbe: fix missing suppport of multi-segs offloading
@ 2018-04-17  7:43 Wei Dai
  2018-04-17  8:32 ` Yao, Lei A
  2018-04-17  9:42 ` Ananyev, Konstantin
  0 siblings, 2 replies; 4+ messages in thread
From: Wei Dai @ 2018-04-17  7:43 UTC (permalink / raw)
  To: wenzhuo.lu, konstantin.ananyev, lei.a.yao; +Cc: dev, Wei Dai, stable

This patch adds missing supported Tx multi-segs offloading.

Fixes: 51215925a32f ("net/ixgbe: convert to new Tx offloads API")
Cc: stable@dpdk.org

Signed-off-by: Wei Dai <wei.dai@intel.com>
---
 drivers/net/ixgbe/ixgbe_rxtx.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
index 7511e18..aed3f5a 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx.c
+++ b/drivers/net/ixgbe/ixgbe_rxtx.c
@@ -2429,7 +2429,8 @@ ixgbe_get_tx_port_offloads(struct rte_eth_dev *dev)
 		DEV_TX_OFFLOAD_UDP_CKSUM   |
 		DEV_TX_OFFLOAD_TCP_CKSUM   |
 		DEV_TX_OFFLOAD_SCTP_CKSUM  |
-		DEV_TX_OFFLOAD_TCP_TSO;
+		DEV_TX_OFFLOAD_TCP_TSO     |
+		DEV_TX_OFFLOAD_MULTI_SEGS;
 
 	if (hw->mac.type == ixgbe_mac_82599EB ||
 	    hw->mac.type == ixgbe_mac_X540)
-- 
2.7.5

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] net/ixgbe: fix missing suppport of multi-segs offloading
  2018-04-17  7:43 [dpdk-dev] [PATCH] net/ixgbe: fix missing suppport of multi-segs offloading Wei Dai
@ 2018-04-17  8:32 ` Yao, Lei A
  2018-04-17  9:42 ` Ananyev, Konstantin
  1 sibling, 0 replies; 4+ messages in thread
From: Yao, Lei A @ 2018-04-17  8:32 UTC (permalink / raw)
  To: Dai, Wei, Lu, Wenzhuo, Ananyev, Konstantin; +Cc: dev, stable



> -----Original Message-----
> From: Dai, Wei
> Sent: Tuesday, April 17, 2018 3:44 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Yao, Lei A <lei.a.yao@intel.com>
> Cc: dev@dpdk.org; Dai, Wei <wei.dai@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/ixgbe: fix missing suppport of multi-segs offloading
> 
> This patch adds missing supported Tx multi-segs offloading.
> 
> Fixes: 51215925a32f ("net/ixgbe: convert to new Tx offloads API")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Wei Dai <wei.dai@intel.com>
Tested-by: Lei Yao<lei.a.yao@intel.com>
This patch can fix the vhost-sample launch issue, the virtio VM2VM Iperf
test can pass  with this patch on ixgbe NIC. 
> ---
>  drivers/net/ixgbe/ixgbe_rxtx.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
> index 7511e18..aed3f5a 100644
> --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> @@ -2429,7 +2429,8 @@ ixgbe_get_tx_port_offloads(struct rte_eth_dev
> *dev)
>  		DEV_TX_OFFLOAD_UDP_CKSUM   |
>  		DEV_TX_OFFLOAD_TCP_CKSUM   |
>  		DEV_TX_OFFLOAD_SCTP_CKSUM  |
> -		DEV_TX_OFFLOAD_TCP_TSO;
> +		DEV_TX_OFFLOAD_TCP_TSO     |
> +		DEV_TX_OFFLOAD_MULTI_SEGS;
> 
>  	if (hw->mac.type == ixgbe_mac_82599EB ||
>  	    hw->mac.type == ixgbe_mac_X540)
> --
> 2.7.5

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] net/ixgbe: fix missing suppport of multi-segs offloading
  2018-04-17  7:43 [dpdk-dev] [PATCH] net/ixgbe: fix missing suppport of multi-segs offloading Wei Dai
  2018-04-17  8:32 ` Yao, Lei A
@ 2018-04-17  9:42 ` Ananyev, Konstantin
  2018-04-17 16:16   ` Zhang, Helin
  1 sibling, 1 reply; 4+ messages in thread
From: Ananyev, Konstantin @ 2018-04-17  9:42 UTC (permalink / raw)
  To: Dai, Wei, Lu, Wenzhuo, Yao, Lei A; +Cc: dev, stable



> -----Original Message-----
> From: Dai, Wei
> Sent: Tuesday, April 17, 2018 8:44 AM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin <konstantin.ananyev@intel.com>; Yao, Lei A <lei.a.yao@intel.com>
> Cc: dev@dpdk.org; Dai, Wei <wei.dai@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/ixgbe: fix missing suppport of multi-segs offloading
> 
> This patch adds missing supported Tx multi-segs offloading.
> 
> Fixes: 51215925a32f ("net/ixgbe: convert to new Tx offloads API")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Wei Dai <wei.dai@intel.com>
> ---
>  drivers/net/ixgbe/ixgbe_rxtx.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
> index 7511e18..aed3f5a 100644
> --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> @@ -2429,7 +2429,8 @@ ixgbe_get_tx_port_offloads(struct rte_eth_dev *dev)
>  		DEV_TX_OFFLOAD_UDP_CKSUM   |
>  		DEV_TX_OFFLOAD_TCP_CKSUM   |
>  		DEV_TX_OFFLOAD_SCTP_CKSUM  |
> -		DEV_TX_OFFLOAD_TCP_TSO;
> +		DEV_TX_OFFLOAD_TCP_TSO     |
> +		DEV_TX_OFFLOAD_MULTI_SEGS;
> 
>  	if (hw->mac.type == ixgbe_mac_82599EB ||
>  	    hw->mac.type == ixgbe_mac_X540)
> --
> 2.7.5

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] net/ixgbe: fix missing suppport of multi-segs offloading
  2018-04-17  9:42 ` Ananyev, Konstantin
@ 2018-04-17 16:16   ` Zhang, Helin
  0 siblings, 0 replies; 4+ messages in thread
From: Zhang, Helin @ 2018-04-17 16:16 UTC (permalink / raw)
  To: Ananyev, Konstantin, Dai, Wei, Lu, Wenzhuo, Yao, Lei A; +Cc: dev, stable



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ananyev, Konstantin
> Sent: Tuesday, April 17, 2018 5:43 PM
> To: Dai, Wei; Lu, Wenzhuo; Yao, Lei A
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix missing suppport of multi-segs
> offloading
> 
> 
> 
> > -----Original Message-----
> > From: Dai, Wei
> > Sent: Tuesday, April 17, 2018 8:44 AM
> > To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin
> > <konstantin.ananyev@intel.com>; Yao, Lei A <lei.a.yao@intel.com>
> > Cc: dev@dpdk.org; Dai, Wei <wei.dai@intel.com>; stable@dpdk.org
> > Subject: [PATCH] net/ixgbe: fix missing suppport of multi-segs
> > offloading
> >
> > This patch adds missing supported Tx multi-segs offloading.
> >
> > Fixes: 51215925a32f ("net/ixgbe: convert to new Tx offloads API")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Wei Dai <wei.dai@intel.com>
> > ---
> >  drivers/net/ixgbe/ixgbe_rxtx.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c
> > b/drivers/net/ixgbe/ixgbe_rxtx.c index 7511e18..aed3f5a 100644
> > --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> > @@ -2429,7 +2429,8 @@ ixgbe_get_tx_port_offloads(struct rte_eth_dev
> *dev)
> >  		DEV_TX_OFFLOAD_UDP_CKSUM   |
> >  		DEV_TX_OFFLOAD_TCP_CKSUM   |
> >  		DEV_TX_OFFLOAD_SCTP_CKSUM  |
> > -		DEV_TX_OFFLOAD_TCP_TSO;
> > +		DEV_TX_OFFLOAD_TCP_TSO     |
> > +		DEV_TX_OFFLOAD_MULTI_SEGS;
> >
> >  	if (hw->mac.type == ixgbe_mac_82599EB ||
> >  	    hw->mac.type == ixgbe_mac_X540)
> > --
> > 2.7.5
> 
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Applied to dpdk-next-net-intel, thanks!

/Helin

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-04-17 16:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-17  7:43 [dpdk-dev] [PATCH] net/ixgbe: fix missing suppport of multi-segs offloading Wei Dai
2018-04-17  8:32 ` Yao, Lei A
2018-04-17  9:42 ` Ananyev, Konstantin
2018-04-17 16:16   ` Zhang, Helin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).