From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id E961C1C8BB for ; Mon, 14 May 2018 16:55:16 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 May 2018 07:55:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,400,1520924400"; d="scan'208";a="49107733" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by FMSMGA003.fm.intel.com with ESMTP; 14 May 2018 07:55:14 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.214]) by IRSMSX103.ger.corp.intel.com ([169.254.3.179]) with mapi id 14.03.0319.002; Mon, 14 May 2018 15:55:13 +0100 From: "Ananyev, Konstantin" To: Thomas Monjalon CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] bpf: add missed EXPERIMENTAL tags Thread-Index: AQHT64XLFjg2gfwT3kmImgwpebqdlaQvOKYAgAAVywA= Date: Mon, 14 May 2018 14:55:13 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258AEDC72E8@irsmsx105.ger.corp.intel.com> References: <4850625.lUN5xUOOBk@xps> <1526303742-18336-1-git-send-email-konstantin.ananyev@intel.com> <2420395.OS6qY2Y8eq@xps> In-Reply-To: <2420395.OS6qY2Y8eq@xps> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDIxOGFlYzEtYzNiMS00NTEzLThiMzQtNWJlNTMyZWJkMzUwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlVWNGtxenhWMkVcL1FQRWxvaElQZnBjVFQ1S1paNFpCekIzVVQ1aGNydkdvPSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] bpf: add missed EXPERIMENTAL tags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 May 2018 14:55:17 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Monday, May 14, 2018 3:31 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] bpf: add missed EXPERIMENTAL tags >=20 > 14/05/2018 15:15, Konstantin Ananyev: > > - add EXPERIMENTAL tag for the section in MAINTAINERS. > > - add EXPERIMENTAL tag to BPF public API files. > > - add attribute __rte_experimental to BPF public API declarations. > > > > Fixes: 94972f35a02e ("bpf: add BPF loading and execution framework") > > Fixes: 5dba93ae5f2d ("bpf: add ability to load eBPF program from ELF") > > Fixes: a93ff62a8938 ("bpf: add BPF loading and execution framework") > > > > Reported-by: Thomas Monjalon > > Signed-off-by: Konstantin Ananyev > > --- > > MAINTAINERS | 2 +- > > lib/librte_bpf/rte_bpf.h | 26 ++++++++++++++++---------- > > lib/librte_bpf/rte_bpf_ethdev.h | 15 ++++++++++----- > > 3 files changed, 27 insertions(+), 16 deletions(-) >=20 > You need to add __rte_experimental in function definitions too (.c file). I believe that was done in initial commit. >=20 > There is a tool to check it: buildtools/check-experimental-syms.sh >=20 ./buildtools/check-experimental-syms.sh lib/librte_bpf/rte_bpf_version.map = x86_64-native-linuxapp-gcc-meson/lib/librte_bpf.a Don't produce any errors/warnings for me. Do I miss something here? Konstantin