From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 44F4B2C38 for ; Tue, 21 Aug 2018 15:08:16 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Aug 2018 06:08:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,269,1531810800"; d="scan'208";a="78784834" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga002.fm.intel.com with ESMTP; 21 Aug 2018 06:08:13 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.180]) by IRSMSX104.ger.corp.intel.com ([169.254.5.213]) with mapi id 14.03.0319.002; Tue, 21 Aug 2018 14:08:12 +0100 From: "Ananyev, Konstantin" To: Dekel Peled , "dev@dpdk.org" , "Adrien Mazarguil" , "olivier.matz@6wind.com" CC: Ori Kam , Shahaf Shuler Thread-Topic: [RFC] ethdev: support metadata as flow rule criteria Thread-Index: AQHUMtwqQZL3Zvrwj0eo5HIkrJTSx6TKOWXA Date: Tue, 21 Aug 2018 13:08:12 +0000 Message-ID: <2601191342CEEE43887BDE71AB977258E9FA2D49@IRSMSX102.ger.corp.intel.com> References: <1534146418-1060-1-git-send-email-dekelp@mellanox.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDZmYjFhZDgtZTZkMy00NWUxLWEyYmYtY2Q4NWVkMGJkYzk0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibUhlSjFBekU1RWFiQUJXTWs2RXQrY1VDNWJGeGhtWU5tdnhVWGRLTzB3dlpjaURWdjZnQStxMnZBTGM0RzFWbiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [RFC] ethdev: support metadata as flow rule criteria X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2018 13:08:16 -0000 >=20 > > -----Original Message----- > > From: Dekel Peled [mailto:dekelp@mellanox.com] > > Sent: Monday, August 13, 2018 10:47 AM > > To: dev@dpdk.org > > Cc: Ori Kam ; Shahaf Shuler > > > > Subject: [RFC] ethdev: support metadata as flow rule criteria > > > > Current implementation of rte_flow allows match pattern of flow rule, b= ased > > on packet data or header fields. > > This limits the application use of match patterns. > > > > For example, consider a vswitch application which controls a set of VMs= , > > connected with virtio, in a fabric with overlay of VXLAN. > > Several VMs can have the same inner tuple, while the outer tuple is dif= ferent > > and controlled by the vswitch (encap action). > > For the vswtich to be able to offload the rule to the NIC, it must use = a unique > > match criteria, independent from the inner tuple, to perform the encap > > action. > > > > This RFC adds support for additional metadata to use as match pattern. > > The metadata is an opaque item, fully controlled by the application. > > > > The use of metadata is relevant for egress rules only. > > It can be set in the flow rule using the RTE_FLOW_ITEM_META. > > > > Application should set the packet metdata in the mbuf->metadata field, = and > > set the PKT_TX_METADATA flag in the mbuf->ol_flags. > > The NIC will use the packet metadata as match criteria for relevant flo= w rules. > > > > For example, to do an encap action depending on the VM id, the applicat= ion > > needs to configure 'match on metadata' rte_flow rule with VM id as > > metadata, along with desired encap action. > > When preparing an egress data packet, application will set VM id data i= n > > mbuf metadata field and set PKT_TX_METADATA flag. > > > > PMD will send data packets to NIC, with VM id as metadata. > > Egress flow on NIC will match metadata as done with other criteria. > > Upon match on metadata (VM id) the appropriate encap action will be > > performed. > > > > This RFC introduces metadata item type for rte_flow > > RTE_FLOW_ITEM_META, along with corresponding struct > > rte_flow_item_meta and ol_flag PKT_TX_METADATA. > > It also enhances struct rte_mbuf with new data item, uint64_t metadata. > > > > Comments are welcome. > > > > Signed-off-by: Dekel Peled > > --- > > doc/guides/prog_guide/rte_flow.rst | 21 +++++++++++++++++++++ > > lib/librte_ethdev/rte_flow.c | 1 + > > lib/librte_ethdev/rte_flow.h | 25 +++++++++++++++++++++++++ > > lib/librte_mbuf/rte_mbuf.h | 11 +++++++++++ > > 4 files changed, 58 insertions(+) > > > > diff --git a/doc/guides/prog_guide/rte_flow.rst > > b/doc/guides/prog_guide/rte_flow.rst > > index b305a72..b6e35f1 100644 > > --- a/doc/guides/prog_guide/rte_flow.rst > > +++ b/doc/guides/prog_guide/rte_flow.rst > > @@ -1191,6 +1191,27 @@ Normally preceded by any of: > > - `Item: ICMP6_ND_NS`_ > > - `Item: ICMP6_ND_OPT`_ > > > > +Item: ``META`` > > +^^^^^^^^^^^^^^ > > + > > +Matches an application specific 64 bit metadata item. > > + > > +- Default ``mask`` matches any 64 bit value. > > + > > +.. _table_rte_flow_item_meta: > > + > > +.. table:: META > > + > > + +----------+----------+---------------------------+ > > + | Field | Subfield | Value | > > + +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D+=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D+ > > + | ``spec`` | ``data`` | 64 bit metadata value | > > + +----------+--------------------------------------+ > > + | ``last`` | ``data`` | upper range value | > > + +----------+----------+---------------------------+ > > + | ``mask`` | ``data`` | zeroed to match any value | > > + +----------+----------+---------------------------+ > > + > > Actions > > ~~~~~~~ > > > > diff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.= c index > > cff4b52..54e5ef8 100644 > > --- a/lib/librte_ethdev/rte_flow.c > > +++ b/lib/librte_ethdev/rte_flow.c > > @@ -66,6 +66,7 @@ struct rte_flow_desc_data { > > sizeof(struct rte_flow_item_icmp6_nd_opt_sla_eth)), > > MK_FLOW_ITEM(ICMP6_ND_OPT_TLA_ETH, > > sizeof(struct rte_flow_item_icmp6_nd_opt_tla_eth)), > > + MK_FLOW_ITEM(META, sizeof(struct rte_flow_item_meta)), > > }; > > > > /** Generate flow_action[] entry. */ > > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.= h index > > f8ba71c..b81c816 100644 > > --- a/lib/librte_ethdev/rte_flow.h > > +++ b/lib/librte_ethdev/rte_flow.h > > @@ -413,6 +413,15 @@ enum rte_flow_item_type { > > * See struct rte_flow_item_mark. > > */ > > RTE_FLOW_ITEM_TYPE_MARK, > > + > > + /** > > + * [META] > > + * > > + * Matches a metadata value specified in mbuf metadata field. > > + * > > + * See struct rte_flow_item_meta. > > + */ > > + RTE_FLOW_ITEM_TYPE_META, > > }; > > > > /** > > @@ -849,6 +858,22 @@ struct rte_flow_item_gre { #endif > > > > /** > > + * RTE_FLOW_ITEM_TYPE_META. > > + * > > + * Matches a specified metadata value. > > + */ > > +struct rte_flow_item_meta { > > + uint64_t data; > > +}; > > + > > +/** Default mask for RTE_FLOW_ITEM_TYPE_META. */ #ifndef __cplusplus > > +static const struct rte_flow_item_meta rte_flow_item_meta_mask =3D { > > + .data =3D RTE_BE64(UINT64_MAX), > > +}; > > +#endif > > + > > +/** > > * RTE_FLOW_ITEM_TYPE_FUZZY > > * > > * Fuzzy pattern match, expect faster than default. > > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h in= dex > > 9ce5d76..8f06a78 100644 > > --- a/lib/librte_mbuf/rte_mbuf.h > > +++ b/lib/librte_mbuf/rte_mbuf.h > > @@ -182,6 +182,11 @@ > > /* add new TX flags here */ > > > > /** > > + * This flag indicates that the metadata field in the mbuf is in use. > > + */ > > +#define PKT_TX_METADATA (1ULL << 41) > > + > > +/** > > * UDP Fragmentation Offload flag. This flag is used for enabling UDP > > * fragmentation in SW or in HW. When use UFO, mbuf->tso_segsz is used > > * to store the MSS of UDP fragments. > > @@ -593,6 +598,12 @@ struct rte_mbuf { > > */ > > struct rte_mbuf_ext_shared_info *shinfo; > > > > + /** > > + * Application specific metadata value for flow rule match. > > + * Valid if PKT_TX_METADATA is set. > > + */ > > + uint64_t metadata; > > + Just one thought - with that change we'll have only 8 free bytes left insid= e rte_mbuf. Wonder tan this metadata field be combined within tx_offload or probably ha= sh fields? Konstantin > > } __rte_cache_aligned; > > > > /** > > -- > > 1.8.3.1