From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id C950D37B0 for ; Wed, 25 May 2016 11:45:20 +0200 (CEST) Received: by mail-wm0-f43.google.com with SMTP id n129so172042630wmn.1 for ; Wed, 25 May 2016 02:45:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=5URiIkLoQcVuZzjt1SnGGaH0jQdJe1ha0w1zP6MBTSE=; b=qZ9vj+k83H89L+u92ZJe3lXcoyVZ3LLepl5BveIltPcESdFPBg3/JRde4MQYd7GT+P XHNvFZ7hCl4LDXYGHVjy/HZGw0ckbHZ3uDaEzwI7+Rdya3LTu17Ln5u5FVHYsmSCPB7c rgu6bdXBxS4h98sNnKdT+zOegDq0+xJIUZRpafyDtXHdsa40pD1qABeBNJIWO8MWFCpz odY3+yVVje5YIZ6P0JynPxIKNuaX6tUXPsX3KtL3Zm8756M9xGPIQxdWSOUxYJnLy9LX b9A3X4AzWgHMS/JQWQ144XaUDEpO5OFS9jnX5znt63CI5P7MqftG01EXWAgjQLovBUwa A5nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=5URiIkLoQcVuZzjt1SnGGaH0jQdJe1ha0w1zP6MBTSE=; b=YTXoKpJr1GqV7nmfpnKKAHLCzofUgCy9YHsWJ6zTGiu53XBOzxa9ks7P0srIs/2XCV /2+d7Eu6JmajjNlvWGAGCTdLvUmQAgbvMyG7Z03uFNmZlvuRxcXRzi3o0FugxsmqOpwW Pu8n54LwoSXiAil00R+KN9h5KDHL+thXQ1GNkrYORiWNY3Oh4Yd78m0LDhY5C0L2lbMs eDrE0nCImDY9/VeWvGAqOC6Eas9rEuVuJVcGjDTy+fPrkuyFY0b5Dg7pX086swzY3auu vkHRHHK5rmkGekiSZ2TeK3frsJ8SlrTOx2TD8bXFA4qU7Z9lYr2jUIgBMEeKdc6EVrAl vuyg== X-Gm-Message-State: ALyK8tKEmQgByrm47tjoza5zQaiz61u9v7X1VHHzqd3xlB2shsc/IxCxfPNCFe40HZsmpRVD X-Received: by 10.28.146.73 with SMTP id u70mr2602704wmd.42.1464169520626; Wed, 25 May 2016 02:45:20 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id s196sm6789048wme.23.2016.05.25.02.45.19 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 25 May 2016 02:45:19 -0700 (PDT) From: Thomas Monjalon To: Zhihong Wang Cc: dev@dpdk.org, konstantin.ananyev@intel.com, bruce.richardson@intel.com, pablo.de.lara.guarch@intel.com Date: Wed, 25 May 2016 11:45:19 +0200 Message-ID: <2604231.jECmEcnI7g@xps13> User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1462488421-118990-6-git-send-email-zhihong.wang@intel.com> References: <1462488421-118990-1-git-send-email-zhihong.wang@intel.com> <1462488421-118990-6-git-send-email-zhihong.wang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 5/6] testpmd: show topology at forwarding start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2016 09:45:21 -0000 2016-05-05 18:47, Zhihong Wang: > This patch show topology at forwarding start. > > "show config fwd" also does this, but showing it directly can reduce the > possibility of misconfiguration. [...] > - fwd_config_setup(); > + fwd_config_display(); > rxtx_config_display(); Having _display() calling _setup() is really strange. Maybe it is worth to be fixed in this patch.