From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id 2F0603775 for ; Sat, 23 May 2015 22:38:38 +0200 (CEST) Received: by wicmx19 with SMTP id mx19so15114678wic.0 for ; Sat, 23 May 2015 13:38:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=O/Nd2W6cMiA2kv3xkJsgdV5ziLYCJ3oGnDHX552pikA=; b=YWo/ap5B3AC4fqfXzyBnINCGFOaIji6yucboVh0xi9+2VfqtS5NSNxe+maOJ/j+xBW 4mvS+MuIUaowdN8sO8n/O6L1Tm65bpVPazOcTYLtGeG78i5TQX7s0Ai2zaPPEcobAQti 0C6cygC5qJbE5QUfFZNzgjVdQqd8XMSWeorIt2BAgm74Hg5IxEwbba2YQF45DqNjRunO WsTJZv6+dP1p/4Khl0t9lNCiUshz5HdRaCjLpes7crH4saKWrG6TjkfvpehHJlDzZOtf 1uMlxi3EpzmjWdF5CrAIfdJpLb1ri/ewekshBwb4NIc+bxaz9vw/m57DUAkxmHo//Vud Fk+Q== X-Gm-Message-State: ALoCoQlhDylVdZiH38morlzC9Qwf83Ncl7S6GvpEPaIi7jwoH3d4TTs+fkH+mcTI8uNciNKi2YT/ X-Received: by 10.180.20.200 with SMTP id p8mr18042336wie.78.1432413517013; Sat, 23 May 2015 13:38:37 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id g15sm4397084wiv.22.2015.05.23.13.38.35 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 May 2015 13:38:35 -0700 (PDT) From: Thomas Monjalon To: Or Gerlitz Date: Sat, 23 May 2015 22:37:49 +0200 Message-ID: <26044433.c9sIfhf4pb@xps13> Organization: 6WIND User-Agent: KMail/4.14.7 (Linux/4.0.1-1-ARCH; KDE/4.14.7; x86_64; ; ) In-Reply-To: References: <1431450315-13179-1-git-send-email-bruce.richardson@intel.com> <1431705423-16134-11-git-send-email-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 10/19] mlx4: move mlx4 PMD to drivers/net directory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 May 2015 20:38:38 -0000 Hi, 2015-05-23 07:46, Or Gerlitz: > On Fri, May 15, 2015 at 6:56 PM, Bruce Richardson > wrote: > > move mlx4 PMD to drivers/net directory > > > > Signed-off-by: Bruce Richardson > > --- > > drivers/net/Makefile | 2 +- > > drivers/net/mlx4/Makefile | 121 + > > drivers/net/mlx4/mlx4.c | 4686 ++++++++++++++++++++++++++ > > drivers/net/mlx4/mlx4.h | 157 + > > drivers/net/mlx4/rte_pmd_mlx4_version.map | 4 + > > lib/Makefile | 1 - > > lib/librte_pmd_mlx4/Makefile | 121 - > > lib/librte_pmd_mlx4/mlx4.c | 4686 -------------------------- > > lib/librte_pmd_mlx4/mlx4.h | 157 - > > lib/librte_pmd_mlx4/rte_pmd_mlx4_version.map | 4 - > > 10 files changed, 4969 insertions(+), 4970 deletions(-) > > create mode 100644 drivers/net/mlx4/Makefile > > create mode 100644 drivers/net/mlx4/mlx4.c > > create mode 100644 drivers/net/mlx4/mlx4.h > > create mode 100644 drivers/net/mlx4/rte_pmd_mlx4_version.map > > delete mode 100644 lib/librte_pmd_mlx4/Makefile > > delete mode 100644 lib/librte_pmd_mlx4/mlx4.c > > delete mode 100644 lib/librte_pmd_mlx4/mlx4.h > > delete mode 100644 lib/librte_pmd_mlx4/rte_pmd_mlx4_version.map > > There's a way to do source movements with git such that history > remains, see for example in the upstream kernel the way the ethernet > drivers were moved from drivers/net to drivers/net/ethernet couple of > years ago. I don't see anything special here: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=5a2cc190eb3fe It doesn't seem different of http://dpdk.org/browse/dpdk/commit/?id=98a1f3776fc9a3de442 By the way, what do you mean by "history remains"? Are you thinking about git log --follow which is known to be a hack? http://permalink.gmane.org/gmane.comp.version-control.git/147089 My understanding is that file history doesn't fit well with git: http://article.gmane.org/gmane.comp.version-control.git/217 > Please make sure to use that practice here too. The change was applied before you sent this message: http://dpdk.org/ml/archives/dev/2015-May/018064.html But I'm still interested about best practices.