From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E849342C9A; Mon, 12 Jun 2023 22:25:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BCE56410D7; Mon, 12 Jun 2023 22:25:31 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id CB2DD40689 for ; Mon, 12 Jun 2023 22:25:29 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 4EBD35C01A0; Mon, 12 Jun 2023 16:25:29 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 12 Jun 2023 16:25:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1686601529; x=1686687929; bh=cVK/3zzJzpHYXIYr1WvAEg6ZqhFIVoOJerw CV0Z9ylg=; b=WreTTLwyLByN9XYdeYLQZFNIQsWM/CNaSV5r6yqpqMYeMIlrN3q /MtVuexpoEj6svA0vnruwv4Kt4lc2gyr4AwSe0hMRLj5inmdzpKfRLM8DBrqic4X lUg7wPDngCpZDi88+HDUYzupxEcj0BYGZNwrhAzeyDP7L/7LfPsTEwC1+NNyo7Xm qjs8RL7spSknRoiQWyAWKcgSOf/iDKHHa4U/DGcEw+9BuQuFifwl9H8svnsMeH9Z fZMEqHH+s0YU2nsrehauKQtZrQlaj8hfFbNUOX57DDz+Bg/6CpjorMLwhlJrEzsa oYWfXSPQQY6Lwdlx06bl4Du3ch3TcxvO6jA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1686601529; x=1686687929; bh=cVK/3zzJzpHYXIYr1WvAEg6ZqhFIVoOJerw CV0Z9ylg=; b=LOYfUQuXWDQ3aJx7l3jdW4+Cempnslu7OpYaw9Uq9j2PlbAL/L8 QPiaWYb+xj6db6mGA38AeHyTKTzwmkw5y9eOA5587ssCkF/DmPxGHCRvh0WHXO+O gUWmJPIJLaROutD+gdFiyfCxkic7XeWMpUfehkKB9dexCe67/y/HV6Bjw+X3wUVb p65DbRAc4f8GmUbnXnuhn4mp+A3cmWGte1mBYl4lJ7XxhBNPyYeo60B97VgjrEzp B//ExeOgcUl9mvlqfdGX+S6q2gcKYiX7uKvEAtEX/DrCD4QkRCgo3PawD37i7CJD 0TuEhi/poHzR/uT6TCgDn1GwOVeKRCm8JGw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeduhedgudegkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 12 Jun 2023 16:25:28 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger Cc: "dev@dpdk.org" , Jerin Jacob Kollanukkaran , Kiran Kumar Kokkilagadda , Nithin Kumar Dabilpuram , Amit Prakash Shukla Subject: Re: [EXT] [PATCH v2] graph: fix pcapng file support Date: Mon, 12 Jun 2023 22:25:26 +0200 Message-ID: <2604609.tIAgqjz4sF@thomas> In-Reply-To: References: <20230530190834.142932-1-stephen@networkplumber.org> <20230531172753.65074-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > The interface to rte_pcapng changed in last release > > so that the interfaces used need to be added to the pcapng > > file via the API. If this step is missing the pcapng > > file will not be valid and can't be read by wireshark etc. > > > > Fixes: d1da6d0d04c7 ("pcapng: require per-interface information") > > Signed-off-by: Stephen Hemminger > > Looks good to me. Thanks. > > Acked-by: Amit Prakash Shukla Applied, thanks.