From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id A82512A58 for ; Mon, 3 Jul 2017 23:06:05 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4C20420777; Mon, 3 Jul 2017 17:06:05 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 03 Jul 2017 17:06:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=VSHI4pq3MzF3/ki 20d7XGW8zFSKsHjcecNrlg345mFg=; b=DEDNgnf7mjOyRc2cc8oG3nrsBG3gcBS sx3pvh0oLgfE3ic5TNcPkecuncHLfP9ehD/H99WrOwzMnO7MflzLnr5wMf5KBFWc 7I5Mdbn/mrcqcBhL1E3wUian0x76m/TzIs7NyAsm3gd2tVc0xWiRqgSutwjkDIMp dDavlkmyz1ks= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=VSHI4pq3MzF3/ki20d7XGW8zFSKsHjcecNrlg345mFg=; b=PfnhLCkD z+Jzb2cqUJy+CNWkNSPu+aj1itY1TFowPGL4/9p28yxNspFbXUAF+4HPbXEoHl7n WbZPQ3zF+XAyETLyTTUhxx/M9ELx+ZJD8O5kctNfB1GB4Z/hTwEc2COL3Bpy04w0 /6Q+8NTzsjvInY3vyx1se0tEvHmYiqQA1rLfDaOjrI6tUQ+YiI6eGp7C+FBYoz7T +FHp20M3K0sm/vyzDY+/dCkSSOItNa7JigOVE7t8VR1NInMb2XKKxmGLjBg9QHnD YluljxRRXbj1j5gd1LITh93Dx+Xi+wTsu3/dDgifAk+wHC+9aZuc39j6r+1+LpvH jysNbyAOCOUbmQ== X-ME-Sender: X-Sasl-enc: v95jxDbuzpfyR46R3rchTQKybTSLsYa7gU9yV/KMQAy3 1499115965 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 09B2824713; Mon, 3 Jul 2017 17:06:05 -0400 (EDT) From: Thomas Monjalon To: Ashwin Sekhar T K Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, viktorin@rehivetech.com, jianbo.liu@linaro.org, jasvinder.singh@intel.com Date: Mon, 03 Jul 2017 23:06:04 +0200 Message-ID: <2605665.7CG6vINj2E@xps> In-Reply-To: <20170512101535.7221-4-ashwin.sekhar@caviumnetworks.com> References: <20170427140618.35897-1-ashwin.sekhar@caviumnetworks.com> <20170512101535.7221-1-ashwin.sekhar@caviumnetworks.com> <20170512101535.7221-4-ashwin.sekhar@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 3/4] net: add arm64 neon version of CRC compute APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jul 2017 21:06:06 -0000 12/05/2017 12:15, Ashwin Sekhar T K: > +#elif defined(ARM64_NEON_PMULL) > + case RTE_NET_CRC_NEON: > + if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_PMULL)) { > + handlers = handlers_neon; > + break; > + } > + //-fallthrough > +#endif > case RTE_NET_CRC_SCALAR: > + //-fallthrough > default: These fallthrough comments are not in the right coding style.