From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id BBCEC9E3 for ; Mon, 26 Jun 2017 11:39:30 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4962920F51; Mon, 26 Jun 2017 05:39:30 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 26 Jun 2017 05:39:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=gRfJubXU+dC2lab 1unJGwRnwp/8ZwE8lEfSP7lVuQqw=; b=Q+n08UN+zlq2COnJd5ngZdTa1BrEcx8 TRWh3LJIKerpyGXFLqQ1ar2cknPCkuAgHi9OUHvveewNIygke5p1XdPdu7j7pU+M VmISNKcyUYDnf/JZ97bdyJJUfWz1K1dvteXpvE9245yd5PpNhGgN2na1azb9Sd0r lCpNVTNCNgE4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=gRfJubXU+dC2lab1unJGwRnwp/8ZwE8lEfSP7lVuQqw=; b=gx5SK/mR CvnZDAY8pnwb6yB8xHWdBX7zqaKjgufTtvW3dd4l6HtmZKDupLvAqzHdZW0uoqwi CDGrqR2ddttGi5ctMotKbImo53XXjQ6sp64038/jqlteGqhyQhIf5haPTRpXffnr bzSQ7vkwxKWJzrkJpMf5IuoiOZWnHBF+wFgfQdBRzV8PjRPSTyumjFpQZIsu3Pcn 7O9Ad1NUsw2u9zrMgo8kBVK7hM1dSwkfR0ZuTJw8iwW9SO/O22qOXt0VfxCEQL0O aBYnsx+Y46Ji0wETi15NvlNlCWC/X1jxv1Gz535TWZiO+mUGR5dFUb8380UTt5qC FYEiv1FtxZ1KYA== X-ME-Sender: X-Sasl-enc: bSI7vu9DjHv84lAglhaV3mSKc2xKq+7R8gs/qF+qg9Nm 1498469970 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 028702445F; Mon, 26 Jun 2017 05:39:30 -0400 (EDT) From: Thomas Monjalon To: Sergio Gonzalez Monroy Cc: Tonghao Zhang , dev@dpdk.org Date: Mon, 26 Jun 2017 11:39:29 +0200 Message-ID: <2606734.FJRB2dCBfg@xps> In-Reply-To: References: <1494467793-19887-1-git-send-email-nic@opencloud.tech> <8278174.tmcXUfVEQA@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] eal: Set numa node value for system which not support it. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jun 2017 09:39:31 -0000 26/06/2017 11:14, Sergio Gonzalez Monroy: > On 23/06/2017 14:02, Thomas Monjalon wrote: > > 22/06/2017 17:15, Sergio Gonzalez Monroy: > >> Just fyi, the summary line should be lowercase apart from acronyms (DPDK > >> guidelines). > >> > >> On 11/05/2017 02:56, Tonghao Zhang wrote: > >>> The NUMA node information for PCI devices provided through > >>> sysfs is invalid for AMD Opteron(TM) Processor 62xx and 63xx > >>> on Red Hat Enterprise Linux 6, and VMs on some hypervisors. > >>> It is good to see more checking for valid values. > >>> > >>> Signed-off-by: Tonghao Zhang > >>> --- > >> IMHO the message could be slightly improved by adding some of the > >> replies that you made to your v3. > >> ie. Typical wrong numa node in VMs > >> > >> $ cat /sys/devices/pci0000:00/0000:00:18.6/numa_node > >> -1 > > [...] > >> The code changes look fine, so I leave it to Thomas regarding the commit > >> message :) > >> > >> Acked-by: Sergio Gonzalez Monroy > > Applied, thanks > > It looks like some systems have quite a few devices that report -1 as > numa_node value causing lots of warning messages being printed. > Quick fixes that come to mind would be: > 1) Change log level to DEBUG As it is important for performance, it should not be just for DEBUG. > 2) Add static var to only print the message once. Yes good idea. > I also think that the message itself should show at least the BDF to at > least know which devices are reporting bad numa_node values. With the static variable, we will have only the first device BDF. Is it relevant?