[dpdk-dev] [PATCH v2 1/1] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags

[dpdk-dev] [PATCH v2 1/1] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags

[Sunil Kumar Kori]

Currently PKT_TX_IP_CKSUM is being set into mbuf->ol_flags during
fragmentation operation implicitly by the library. Because of this,
application is forced to use checksum offload whether it is supported
by platform or not.

Also documentation does not provide any expected value of ol_flags in
returned fragmented mbufs so application will never come to know that which
offloads are enabled. So transmission may be failed for the platforms which
does not support checksum offload.

So removing mentioned flag from the library.

Mentioned changeset is part of http://patches.dpdk.org/patch/53475/
Changes for reassembly operation is already accepcted. This patch set
implements the similar change for fragmentation operation.

Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
---
Current patch is part of following patchset                                     
http://patches.dpdk.org/patch/53475/                                            
which is missed to be merged into upstream because of accepted version of this  
patch does not contain this change.                                             
                                                                                
Accepted patchset is given below:                                               
http://patches.dpdk.org/patch/56202/                                            
                                                                                
Patchset is already reviewed and acked on maillist. Also corrersponding release 
notes are updated.                                                              

 lib/librte_ip_frag/rte_ipv4_fragmentation.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/librte_ip_frag/rte_ipv4_fragmentation.c b/lib/librte_ip_frag/rte_ipv4_fragmentation.c
index 221d74e..9e9f986 100644
--- a/lib/librte_ip_frag/rte_ipv4_fragmentation.c
+++ b/lib/librte_ip_frag/rte_ipv4_fragmentation.c
@@ -173,7 +173,6 @@ static inline void __free_fragments(struct rte_mbuf *mb[], uint32_t num)
 		fragment_offset = (uint16_t)(fragment_offset +
 		    out_pkt->pkt_len - sizeof(struct rte_ipv4_hdr));
 
-		out_pkt->ol_flags |= PKT_TX_IP_CKSUM;
 		out_pkt->l3_len = sizeof(struct rte_ipv4_hdr);
 
 		/* Write the fragment to the output list */
-- 
1.8.3.1

Re: [dpdk-dev] [PATCH v2 1/1] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags

[Thomas Monjalon]

16/07/2019 08:23, Sunil Kumar Kori:
> Currently PKT_TX_IP_CKSUM is being set into mbuf->ol_flags during
> fragmentation operation implicitly by the library. Because of this,
> application is forced to use checksum offload whether it is supported
> by platform or not.
> 
> Also documentation does not provide any expected value of ol_flags in
> returned fragmented mbufs so application will never come to know that which
> offloads are enabled. So transmission may be failed for the platforms which
> does not support checksum offload.
> 
> So removing mentioned flag from the library.
> 
> Mentioned changeset is part of http://patches.dpdk.org/patch/53475/
> Changes for reassembly operation is already accepcted. This patch set
> implements the similar change for fragmentation operation.
> 
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>

Sunil, I would really appreciate you take care of the formatting.
The previous patch had a changed title to comply some coding style:
	e29fc4437     ip_frag: remove IP checkum offload flag
It requires also this line:
	Fixes: e29fc44370c2 ("ip_frag: remove IP checkum offload flag")
When sending a new version, you are supposed to:
	- add a changelog
	- use --in-reply-to

Applied

Re: [dpdk-dev] [PATCH v2 1/1] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags

[Sunil Kumar Kori]

Regards
Sunil Kumar Kori

>-----Original Message-----
>From: Thomas Monjalon <thomas@monjalon.net>
>Sent: Tuesday, July 16, 2019 4:52 PM
>To: Sunil Kumar Kori <skori@marvell.com>
>Cc: dev@dpdk.org; Konstantin Ananyev <konstantin.ananyev@intel.com>;
>Jerin Jacob Kollanukkaran <jerinj@marvell.com>
>Subject: Re: [dpdk-dev] [PATCH v2 1/1] lib/librte_ip_frag: Remove
>PKT_TX_IP_CKSUM offload flags
>
>16/07/2019 08:23, Sunil Kumar Kori:
>> Currently PKT_TX_IP_CKSUM is being set into mbuf->ol_flags during
>> fragmentation operation implicitly by the library. Because of this,
>> application is forced to use checksum offload whether it is supported
>> by platform or not.
>>
>> Also documentation does not provide any expected value of ol_flags in
>> returned fragmented mbufs so application will never come to know that
>> which offloads are enabled. So transmission may be failed for the
>> platforms which does not support checksum offload.
>>
>> So removing mentioned flag from the library.
>>
>> Mentioned changeset is part of http://patches.dpdk.org/patch/53475/
>> Changes for reassembly operation is already accepcted. This patch set
>> implements the similar change for fragmentation operation.
>>
>> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
>
>Sunil, I would really appreciate you take care of the formatting.
>The previous patch had a changed title to comply some coding style:
>	e29fc4437     ip_frag: remove IP checkum offload flag
>It requires also this line:
>	Fixes: e29fc44370c2 ("ip_frag: remove IP checkum offload flag") When
>sending a new version, you are supposed to:
>	- add a changelog
>	- use --in-reply-to
>
>Applied
>
Thanks.
Its my bad that I forgot to send next version with "--in-reply-to" and shared as a new patch.
I will take care of suggestions in future patches.