From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24323A0547; Fri, 12 Mar 2021 16:52:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 08C041608BB; Fri, 12 Mar 2021 16:52:13 +0100 (CET) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id DD7951608AD for ; Fri, 12 Mar 2021 16:52:11 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 944DF1605; Fri, 12 Mar 2021 10:52:10 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 12 Mar 2021 10:52:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= Gj13Xh1aey/lHhaw9IGjawZ4hHiH8fEjXSY4m6ZooWg=; b=jTzCbgMyfMxP6sn3 zFeNokZxAoSh2NWgSfphz/X0e/uIlJO3g5SBOFb4n5rNefpTHoAcPqr4PYz8Nehh S6fkBImsdV9jbGIZGHWPNqpjZ6vQpRcnRJw4+DvUVGhuKZ2GLk6AQZc1zSrfQqDA DyZ/6TY1MRHQ2JvoRA+O+yQ2KYerb5K6bk1cXSmTiueinHCcSgk4EqOUH6d4wVJj S+FOld7yxgXK9Oe3arHQwm+A3dQIXlwjOfi2VvIJlYqz7+xSU3WSm2XpqX4q8VlM 7qrWfH9PK2eXvE5CHskgWyMoNN4+cCduPyHsJ+LvMy2tDM8tw7IcYv8kepu/DsAR Wt/fdw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Gj13Xh1aey/lHhaw9IGjawZ4hHiH8fEjXSY4m6Zoo Wg=; b=bTVivRATWRqK2NcGhZoZo3d3MhEgg1P88OnMG/HW7kRKr8fEGms8YtxIw ann9fo8/nxIBSrhRbmrKXM1ho6sgTtkw2IC1A/dkOLBppa2HMSZsMf8kmVgz9Xer 3s7g5qtVoO7mvlwUfipOPeBtDkALen4qwYCireHg1iOD3ZAyIioEM5ke8eY9rYrx fn7tz+HMEjk2Vtcz/T1WD4wiVn/fspFi4pBWh/5jE9/ZU3HeWRCu1jEd45OIcNBG fKe/WvsjCzmDuEELvW2I93noK3YMaemqLTVqxnUFwaDh8JUXeJIqg938u2esqSip rqkVQcJ5BD1xr2yxVzH5z20FzYSLg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddvvddgkeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 652201080063; Fri, 12 Mar 2021 10:52:08 -0500 (EST) From: Thomas Monjalon To: David Marchand , Bruce Richardson , Ferruh Yigit Cc: Tyler Retzlaff , dev , Andrew Rybchenko Date: Fri, 12 Mar 2021 16:52:05 +0100 Message-ID: <2611050.R5Dl0tXAX9@thomas> In-Reply-To: <20210312153419.GB937@bricha3-MOBL.ger.corp.intel.com> References: <1615490833-23052-1-git-send-email-roretzla@linux.microsoft.com> <20210312153419.GB937@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: introduce enable_driver_sdk to install driver headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 12/03/2021 16:34, Bruce Richardson: > On Fri, Mar 12, 2021 at 04:25:09PM +0100, David Marchand wrote: > > On Fri, Mar 12, 2021 at 4:20 PM Ferruh Yigit wrote: > > > > > > On 3/11/2021 7:27 PM, Tyler Retzlaff wrote: > > > > Introduce a meson option enable_driver_sdk when true installs internal > > > > driver headers for ethdev. this allows drivers that do not depend on > > > > stable api/abi to be built external to the dpdk source tree. > > > > > > > > Signed-off-by: Tyler Retzlaff > > > > --- > > > > > > > > it's still unclear to me if we should be renaming the headers: > > > > > > > > ethdev_driver.h -> rte_ethdev_driver.h > > > > ethdev_pci.h -> rte_ethdev_pci.h > > > > ethdev_vdev.h -> rte_ethdev_vdev.h > > > > > > > > lib/librte_ethdev/meson.build | 5 +++++ > > > > meson_options.txt | 2 ++ > > > > 2 files changed, 7 insertions(+) > > > > > > > > diff --git a/lib/librte_ethdev/meson.build b/lib/librte_ethdev/meson.build > > > > index c37b2e377..7ecdec6f0 100644 > > > > --- a/lib/librte_ethdev/meson.build > > > > +++ b/lib/librte_ethdev/meson.build > > > > @@ -20,6 +20,11 @@ headers = files('rte_ethdev.h', > > > > 'rte_mtr_driver.h', > > > > 'rte_tm.h', > > > > 'rte_tm_driver.h') > > > > +if get_option('enable_driver_sdk') > > > > +headers += files('ethdev_driver.h', > > > > + 'ethdev_pci.h', > > > > + 'ethdev_vdev.h') > > > > +endif > > > > > > Instead of adding the "get_option('enable_driver_sdk')" checks to the modules, > > > what about a more generic solution, like: > > > > > > modules assign relevant headers into a new variable, let's say 'pmd_headers', > > > and in a high level meson file, all 'pmd_headers' are installed if > > > 'enable_driver_sdk' enabled? > > > > > > > +1. > > Just, I don't like "pmd_headers" as the list name. > > It can be misunderstood as the list of pmd-specific headers (thinking > > of rte_pmd_i40e.h), that are exposed to applications. > > > Since the option is called "enable_driver_sdk" the variable name of > "driver_sdk_headers" would be a good match. We should try and keep variable > names and option names in sync as much as possible. +1