From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A9CFA034F; Wed, 24 Feb 2021 13:10:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 871E64069B; Wed, 24 Feb 2021 13:10:00 +0100 (CET) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 4719240042 for ; Wed, 24 Feb 2021 13:09:59 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 73F1DA53; Wed, 24 Feb 2021 07:09:56 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 24 Feb 2021 07:09:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= j2uWhJIHRG6JVZozthpikTGlZ9RUMwe9pqfq0QnpbEo=; b=W44rv9pxxv42klMa vTN4S40W7/vVofBZncUraJe4CbY+SnDPQgmivrvI1+icbsFTj8hJ9cRmOfNm5vJ9 7WJqM54P6xoa6MahAu+WLmgTB1x9LQ55XmuNp+LcBnb6R4G+dSVGCJAaYCvxqIyV KXWLXHSrnmWUdnUmP2abkPN2UWtBeXiq+20h82GxCbqHX8cCBwwNfhqRhOUgAW5C U5z2Pc90nNWCKYLUHPbInBd6UfEjjUn8jXPlA6NabTHrZCxTtow4WHVSkhnjrSqV xAXvWlqqCJ5w4oMnedbqBGCQpIqCtYWGEkN+pCWa73rw1ADWr6o2uMEVPY9TGnQR mDdBqA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=j2uWhJIHRG6JVZozthpikTGlZ9RUMwe9pqfq0Qnpb Eo=; b=tzAPnwJFTGLaiYPGjJo5JW+/7zZsnBTHb0XvEykBq/CCtyMggAa9U0fAQ czJxklxXvChdgaeijLPFO+No27oNvN6FdXnKoOS60FWI9ALuMU9ip0/J6s6xCBMJ vVWQkW93knQSB6qAsRJnYVgrPd5ELVRu1TzrjoscVJ60LswnIDA/s74FjzZnLM7f 7nfBRirQ3cWpMd9LI4wvSLJ9AdXBvP4lJQd5COUL07q9vTWV+VfHKqRwg8G9Jows hjfnxg/q+htq9AOG4QHE2H6WNt+/Dtl+nP1gWSjqHx92jh5OBHmiqsbpZH63qaP1 KSdNoQR5RwuGCxWPGLncVdiqxXyNg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrkeejgdefiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeekteehtdeivefhieegjeelgedufeejheekkeetueevieeuvdevuedt jeevheevteenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7722724005A; Wed, 24 Feb 2021 07:09:54 -0500 (EST) From: Thomas Monjalon To: Juraj =?utf-8?B?TGlua2XFoQ==?= Cc: oulijun , "ferruh.yigit@intel.com" , "dev@dpdk.org" , "linuxarm@openeuler.org" Date: Wed, 24 Feb 2021 13:09:52 +0100 Message-ID: <2613370.aJkOJV8Rtk@thomas> In-Reply-To: References: <1612356396-21309-1-git-send-email-oulijun@huawei.com> <5435054.rFV2aVPxyo@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 24/02/2021 12:55, Juraj Linke=C5=A1: > From: dev On Behalf Of Thomas Monjalon > > 24/02/2021 02:34, oulijun: > > > > > > =E5=9C=A8 2021/2/10 17:41, Thomas Monjalon =E5=86=99=E9=81=93: > > > > 03/02/2021 13:46, Lijun Ou: > > > >> From: Chengchang Tang > > > >> > > > >> Because of the '9ca2f16' have merged, the current hns3 pmd driver > > > >> can not be directly complied on the kunpeng920 server board. > > > >> Therefore, we need to fix the meson build. > > > >> Besides, add kunpeng 920 SoC meson cross compile target. > > > >> > > > >> Fixes: 9ca2f16faa7f ("config/arm: isolate generic build") > > > > > > > > Why do you think this patch is fixing the one above? > > > > It looks just a new config, not a fix. Am I missing something? > > > > > > > I'm sorry to see you so late. In the meantime, we are celebrating the > > > Spring Festival. This patch fixes the problem. If the patch is not > > > added, the latest version cannot be directly compiled on the Kunpeng > > > 930 server board.In addition, the cross compilation configuration fil= e is added. > >=20 > > Please can you explain what was removed which breaks your compilation? > >=20 >=20 > I can explain what's changed and why we changed it. >=20 > The previous behavior was that when an uknown implementer was found (when= we're building on an uknown build machine) we fell back to a generic build. > The current behavior is we raise an error when building on an unknown bui= ld machine and inform the user about the generic build (there's an error in= the message, it should be -Dmachine=3Ddefault instead of -Dmachine=3Dgener= ic). Lijun came across this scenario, so he wants to add an implementer, bu= t it is not a fix, rather an addition that we wanted to encourage when we c= hanged the behavior. The change in behavior also has an additional benefit = in that it notifies the user that meson is not doing a tailored build for t= he build machine and the only permissible build is the generic one. There were already many fixes for that rework. Please check if there are other missing updates.