From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55D1F41FDB; Thu, 31 Aug 2023 13:57:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E191E4027B; Thu, 31 Aug 2023 13:57:42 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id BF81E40279 for ; Thu, 31 Aug 2023 13:57:40 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C5C255C013A; Thu, 31 Aug 2023 07:57:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 31 Aug 2023 07:57:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1693483059; x=1693569459; bh=oNnlFARbSfn0U5dAFlrAkwFiAslK67mp4NX RpfGk2gQ=; b=poPsq0FFW1cnKFQGG6fPGxENjbnhJumQIK/j17m6aGFqqKsRHeb afcO5zMDVKdBK7Cc+cCux//xWCPNMTGyF3Ii6vNR5snhjd/xhZpK7qpsCo5ucIdY 8O9ZKIRaYb7qenf7+KXVVe7HyADuJiAOpz6H4wobgs3pLeQWyOQIT1uj/2c5L6yM Sdkg7kg4kMt/0jFuktT/PWvjyAEmJ+EMy0Y1dEw4kow9Lwwu0i0nu+AAB1LGKAst wRfVf6MBzwpTOPtAK8x+TtUHgWsGF6AqdyEUA63NuytLCELGhX1XkUrr1JderkGi poMW4XxgwtLppbkgMvEt4pWyiUg1O2mT6mg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1693483059; x=1693569459; bh=oNnlFARbSfn0U5dAFlrAkwFiAslK67mp4NX RpfGk2gQ=; b=EEJX/RK3Sv62bMm7EI8H8tnxc5HgN/OVT5lsw1xyxbJONG/5In4 lp+Ken6ivp2ZvrogFqFX0s3s1xtTQhJtCjD69B87XIRYEKeQa94MeHe3uEEz3yDR HqxPe3q3wobSG+7a7qNqgXjvaVcIk2zqU/vP85Pl+K3ySYey4NOrQJZjNvimurpd MDmXA+L+Xl+klW6mRcTA8ozZB6uWpKGX/dVDPixJRP5pzeODungdMZnkyQtSExXE JguNH7jxMji/WoYQrGWkmbi0A/6SkSkkZVzZST4sFdKMZZoRw8pgbNC2dV7Bmc2r KezzUJIvGBzVCPzk7UeVtvGzxWDHmahqCIQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudegtddggeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 31 Aug 2023 07:57:38 -0400 (EDT) From: Thomas Monjalon To: Tyler Retzlaff Cc: dev@dpdk.org, david.marchand@redhat.com, Stephen Hemminger Subject: Re: [PATCH v2] eal: provide per lcore macros for MSVC Date: Thu, 31 Aug 2023 13:57:36 +0200 Message-ID: <2619168.k3LOHGUjKi@thomas> In-Reply-To: <1689090747-5331-2-git-send-email-roretzla@linux.microsoft.com> References: <1689024585-17303-1-git-send-email-roretzla@linux.microsoft.com> <1689090747-5331-1-git-send-email-roretzla@linux.microsoft.com> <1689090747-5331-2-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 11/07/2023 17:52, Tyler Retzlaff: > +#ifdef RTE_TOOLCHAIN_MSVC > /** > * Macro to define a per lcore variable "var" of type "type", don't > * use keywords like "static" or "volatile" in type, just prefix the > * whole macro. > */ > #define RTE_DEFINE_PER_LCORE(type, name) \ > - __thread __typeof__(type) per_lcore_##name > + __declspec(thread) typeof(type) per_lcore_##name > > /** > * Macro to declare an extern per lcore variable "var" of type "type" > */ > #define RTE_DECLARE_PER_LCORE(type, name) \ > + extern __declspec(thread) typeof(type) per_lcore_##name > +#else > +#define RTE_DEFINE_PER_LCORE(type, name) \ > + __thread __typeof__(type) per_lcore_##name > + > +#define RTE_DECLARE_PER_LCORE(type, name) \ > extern __thread __typeof__(type) per_lcore_##name > +#endif I'm afraid you damaged the doxygen document here. Please check what happens when generating doxygen. I suppose it does not take the RTE_TOOLCHAIN_MSVC path, so it does not find any comment.