From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 323A141E21; Thu, 9 Mar 2023 21:07:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C844940ED7; Thu, 9 Mar 2023 21:07:02 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 9CF9540695 for ; Thu, 9 Mar 2023 21:07:01 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id EFC145C00B5; Thu, 9 Mar 2023 15:07:00 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 09 Mar 2023 15:07:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1678392420; x=1678478820; bh=07kcvuirspx/AicqYKBarIfJWEFoRKBXNjY KmwVDAtY=; b=ORA5K0vRnXbLwDpsHKDNkkn6BbfEXoSHTzSkw+sSXXMSpk49GhS /30z9A5Xl7RwCIWMegi0AQs3CPeVvO7uOe70vivp2eNgAlC7f10KSM3zwQ3cifmU zhQBCRBs8aszsST9/rm6495chLO+7s+gcpUn7EDcrb8SycSCdPkp4GMeZkCTjCCE W7ZO+BOeIN5vgRp5sADByrPuplQgtrU+m54u9XxDPJVcfzjRw3HaM5hRyqOtkVqG jAiv+NdLF+X+Fw2LmtOCToDnspwVLV6ZV5kN1gfKm2UJn+2f5QK18sehNM1AhHMM 6cuDKrYWBaXcKdiqPAE1uzTfYLkPY0EuO7A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1678392420; x=1678478820; bh=07kcvuirspx/AicqYKBarIfJWEFoRKBXNjY KmwVDAtY=; b=V5r0/wpAj09qzSIITpaC2l3mX+6wKJpwQjDXIzZTEraQhhLtgFY TDRlqxBFHUCRBJTW0X0MehuFHAFNXUeIkHSpQfTw5U1nDbZZZS0ufR/VlyW0LaKo rCQ/bFNVG76soIBoZRBRFyfYnGdrPc0qGHtKw/kfT5cRZe1Rb9qKheo7p8jDnfwD DauZN/Ef9C3GVhqKfpdiizQ0w+Jq3Rr2Id91L+7rkd7y2zvkyixSf5e4D/uZzYEb o556NGCrJIRejoJJAXYOgt2vFS3M87X/9wpxKU+Mlae5aDApacmzwh1nxLiSZuPD jHPFbEDz4Wo7yO7OdKm/dRyvJVPpLb+Q40A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdduiedgudeftdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 9 Mar 2023 15:06:59 -0500 (EST) From: Thomas Monjalon To: Srikanth Yalavarthi Cc: dev@dpdk.org, sshankarnara@marvell.com, jerinj@marvell.com, aprabhu@marvell.com, ptakkar@marvell.com, pshukla@marvell.com Subject: Re: [PATCH v4 05/12] app/mldev: add ordered inference test case Date: Thu, 09 Mar 2023 21:06:57 +0100 Message-ID: <2619928.BddDVKsqQX@thomas> In-Reply-To: <20230207154943.18779-6-syalavarthi@marvell.com> References: <20221129070746.20396-1-syalavarthi@marvell.com> <20230207154943.18779-1-syalavarthi@marvell.com> <20230207154943.18779-6-syalavarthi@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 07/02/2023 16:49, Srikanth Yalavarthi: > static struct option lgopts[] = { > - {ML_TEST, 1, 0, 0}, {ML_DEVICE_ID, 1, 0, 0}, {ML_SOCKET_ID, 1, 0, 0}, {ML_MODELS, 1, 0, 0}, > - {ML_DEBUG, 0, 0, 0}, {ML_HELP, 0, 0, 0}, {NULL, 0, 0, 0}}; > + {ML_TEST, 1, 0, 0}, {ML_DEVICE_ID, 1, 0, 0}, {ML_SOCKET_ID, 1, 0, 0}, > + {ML_MODELS, 1, 0, 0}, {ML_FILELIST, 1, 0, 0}, {ML_REPETITIONS, 1, 0, 0}, > + {ML_DEBUG, 0, 0, 0}, {ML_HELP, 0, 0, 0}, {NULL, 0, 0, 0}}; > > static int > ml_opts_parse_long(int opt_idx, struct ml_options *opt) > @@ -133,10 +195,9 @@ ml_opts_parse_long(int opt_idx, struct ml_options *opt) > unsigned int i; > > struct long_opt_parser parsermap[] = { > - {ML_TEST, ml_parse_test_name}, > - {ML_DEVICE_ID, ml_parse_dev_id}, > - {ML_SOCKET_ID, ml_parse_socket_id}, > - {ML_MODELS, ml_parse_models}, > + {ML_TEST, ml_parse_test_name}, {ML_DEVICE_ID, ml_parse_dev_id}, > + {ML_SOCKET_ID, ml_parse_socket_id}, {ML_MODELS, ml_parse_models}, > + {ML_FILELIST, ml_parse_filelist}, {ML_REPETITIONS, ml_parse_repetitions}, [...] > /* Options names */ > -#define ML_TEST ("test") > -#define ML_DEVICE_ID ("dev_id") > -#define ML_SOCKET_ID ("socket_id") > -#define ML_MODELS ("models") > -#define ML_DEBUG ("debug") > -#define ML_HELP ("help") > +#define ML_TEST ("test") > +#define ML_DEVICE_ID ("dev_id") > +#define ML_SOCKET_ID ("socket_id") > +#define ML_MODELS ("models") > +#define ML_FILELIST ("filelist") > +#define ML_REPETITIONS ("repetitions") > +#define ML_DEBUG ("debug") > +#define ML_HELP ("help") It seems you have issues with alignment. Please try to do the right alignment in the initial patch, using only spaces. > + ml_err("error_code = 0x%016lx, error_message = %s\n", error.errcode, > + error.message); errcode is 64-bit, you cannot use %lx with 32-bit compiler. PRIx64 is OK [...] > + req->output = RTE_PTR_ADD(req->input, RTE_ALIGN_CEIL(t->model[t->fid].inp_qsize, > + t->cmn.dev_info.min_align_size)); [...] > + t->model[fid].output = RTE_PTR_ADD(t->model[fid].input, t->model[fid].inp_dsize); inp_qsize and inp_dsize are defined as 64-bit fields. Is it really necessary to have such big sizes? It cannot compile on 32-bit systems. The workaround is to cast to uint32_t or uintptr_t.