From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Ido Barnea (ibarnea)" <ibarnea@cisco.com>
Cc: dev@dpdk.org, Helin Zhang <helin.zhang@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [PATCH] ixgbe:Prevent redefinition of bool if compiling using c++
Date: Mon, 18 Jul 2016 17:13:13 +0200 [thread overview]
Message-ID: <2620065.kVZaRD93r7@xps13> (raw)
In-Reply-To: <50DD7300-C300-4862-AEDB-B148206013AD@cisco.com>
2016-07-18 14:12, Ido Barnea:
> In Trex, we do include ixgbe_type.h from c++ code because we do some
> register writes ourselves to support some functionality not exposed in
> the DPDK API.
I agree we should find a way to expose some driver-specific headers for
very specific features which will never be implemented elsewhere.
But ideally, we should try to fix the DPDK API.
> We can continue making this change in our copy of the code only. Just
> trying to align our code with the official version as much as possible,
> and thought it might benefit others as well to make this c++ compatible.
> Apart from this small change, c++ compilation is supported.
OK. Other comment from the maintainers (cc) of this driver?
PS: please avoid top-post.
> On 18/07/2016, 4:54 PM, "Thomas Monjalon" <thomas.monjalon@6wind.com> wrote:
>
> >Hi,
> >
> >DPDK is a C code and do not support C++ compilation.
> >Only the exposed headers have some C++ support requirements.
> >
> >> drivers/net/ixgbe/base/ixgbe_osdep.h | 2 ++
> >
> >Patching this file for C++ will be probably rejected, sorry.
> >
> >I'm interested to understand what is your need?
next prev parent reply other threads:[~2016-07-18 15:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160718133630.58012-1-ibarnea@cisco.com>
2016-07-18 13:39 ` Ido Barnea (ibarnea)
2016-07-18 13:54 ` Thomas Monjalon
2016-07-18 14:12 ` Ido Barnea (ibarnea)
2016-07-18 15:13 ` Thomas Monjalon [this message]
2016-07-21 23:23 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2620065.kVZaRD93r7@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=ibarnea@cisco.com \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).