[dpdk-dev] [PATCH] app/testpmd: unchecked return value

[dpdk-dev] [PATCH] app/testpmd: unchecked return value

[Slawomir Mrozowicz]

Calling rte_eth_dev_rss_hash_update without checking return value.
Fixed by handle return value and print out error status.

Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings")
Coverity ID 119251

Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
---
 app/test-pmd/cmdline.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index c5b9479..9616790 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -1524,6 +1524,7 @@ cmd_config_rss_parsed(void *parsed_result,
 {
 	struct cmd_config_rss *res = parsed_result;
 	struct rte_eth_rss_conf rss_conf;
+	int diag;
 	uint8_t i;
 
 	if (!strcmp(res->value, "all"))
@@ -1547,8 +1548,13 @@ cmd_config_rss_parsed(void *parsed_result,
 		return;
 	}
 	rss_conf.rss_key = NULL;
-	for (i = 0; i < rte_eth_dev_count(); i++)
-		rte_eth_dev_rss_hash_update(i, &rss_conf);
+	for (i = 0; i < rte_eth_dev_count(); i++) {
+		diag = rte_eth_dev_rss_hash_update(i, &rss_conf);
+		if (diag < 0)
+			printf("Configuration of RSS hash at ethernet port %d "
+				"failed with error (%d): %s.\n",
+				i, -diag, strerror(-diag));
+	}
 }
 
 cmdline_parse_token_string_t cmd_config_rss_port =
-- 
1.9.1

Re: [dpdk-dev] [PATCH] app/testpmd: unchecked return value

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Mrozowicz, SlawomirX
> Sent: Wednesday, June 15, 2016 11:34 AM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org; Mrozowicz, SlawomirX
> Subject: [PATCH] app/testpmd: unchecked return value
> 
> Calling rte_eth_dev_rss_hash_update without checking return value.
> Fixed by handle return value and print out error status.
> 
> Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings")
> Coverity ID 119251
> 
> Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Re: [dpdk-dev] [PATCH] app/testpmd: unchecked return value

[Thomas Monjalon]

> > Calling rte_eth_dev_rss_hash_update without checking return value.
> > Fixed by handle return value and print out error status.
> > 
> > Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings")
> > Coverity ID 119251
> > 
> > Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied, thanks