DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] windows: minor install fix
@ 2020-10-31  6:56 Nick Connolly
  2020-11-13 13:48 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Nick Connolly @ 2020-10-31  6:56 UTC (permalink / raw)
  To: Bruce Richardson; +Cc: dev, Nick Connolly, Ranjit Menon

Don't run symlink-drivers-solibs.sh as part of 'install' because
Windows doesn't support shell scripts.

Signed-off-by: Nick Connolly <nick.connolly@mayadata.io>
Tested-by: Ranjit Menon <ranjit.menon@intel.com>
Acked-by: Ranjit Menon <ranjit.menon@intel.com>
---
 config/meson.build | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/config/meson.build b/config/meson.build
index 258b01d06..a29693b88 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -57,9 +57,11 @@ eal_pmd_path = join_paths(get_option('prefix'), driver_install_path)
 # driver .so files often depend upon the bus drivers for their connect bus,
 # e.g. ixgbe depends on librte_bus_pci. This means that the bus drivers need
 # to be in the library path, so symlink the drivers from the main lib directory.
-meson.add_install_script('../buildtools/symlink-drivers-solibs.sh',
-		get_option('libdir'),
-		pmd_subdir_opt)
+if not is_windows
+	meson.add_install_script('../buildtools/symlink-drivers-solibs.sh',
+			get_option('libdir'),
+			pmd_subdir_opt)
+endif
 
 # set the machine type and cflags for it
 if meson.is_cross_build()
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] windows: minor install fix
  2020-10-31  6:56 [dpdk-dev] [PATCH] windows: minor install fix Nick Connolly
@ 2020-11-13 13:48 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2020-11-13 13:48 UTC (permalink / raw)
  To: Nick Connolly; +Cc: Bruce Richardson, dev, Ranjit Menon

31/10/2020 07:56, Nick Connolly:
> Don't run symlink-drivers-solibs.sh as part of 'install' because
> Windows doesn't support shell scripts.
> 
> Signed-off-by: Nick Connolly <nick.connolly@mayadata.io>
> Tested-by: Ranjit Menon <ranjit.menon@intel.com>
> Acked-by: Ranjit Menon <ranjit.menon@intel.com>

Applied with title "build: fix install on Windows", thanks.




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-13 13:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-31  6:56 [dpdk-dev] [PATCH] windows: minor install fix Nick Connolly
2020-11-13 13:48 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).