From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CBEA343ABD; Fri, 9 Feb 2024 18:36:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6A7F242E6F; Fri, 9 Feb 2024 18:36:37 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id EF1E842E64 for ; Fri, 9 Feb 2024 18:36:35 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id EC91E32002D8; Fri, 9 Feb 2024 12:36:33 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 09 Feb 2024 12:36:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1707500193; x=1707586593; bh=hMHPJ67h8jlaNs+HnDgLhzbx1YRlV3Gnrik1zfpkZQs=; b= n6aTGzsK7sQf/vBUUprzOi+8VFh06/K5djTFJiAn6scd6sLl1H7a8WEUGjoq/kRB 85eQzZAEMPPZsKEUTzh9Q8b/GA+/ld/gpt3moeCl2E5Y7EbwTFPbXFuNFct9AuIW P86dkmAqgPISEUSvkm2uWhx/5rFrSaMceAQxoScySfx9YN0yAtSFOyz2rF1j4qKq Y4MAOFUDDAGGID/jUT5JsojDIterQlM8ulULr5rMyTWNHQOEgiNvzRu+nin7WW0O Y3GMU/cOQJ8hdUAnnzv7YG5lOTDU4q6qa3bdgKU8x9LcSVWIVSFRlpm5fVB/8PBr 8IglL+02y2HrVMxoCOQ6Gg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1707500193; x= 1707586593; bh=hMHPJ67h8jlaNs+HnDgLhzbx1YRlV3Gnrik1zfpkZQs=; b=Q 0apgmJMoPipJdEUeOfV4wI1iJCdK8tz1jEj9E74wp8LHJ6V2+wdAilaYBtQ+FtRP byA+vnHtMF6Hp5d1CIajRHdnAtZfNwDSO6mKQTibLOrBjxx30OOicOEks929M5jC 1XEULQLiKVk+MduWtBiMWf+frJb1hGEWrWfco4E/TADmPxKK7pYSZn9LrqndNPDX Q2JB3T43UMl1vR3CqfJE0G/sUOkWEGpBnxV/IEzFZel1nQuuq9VjuUPn0hAA9LED MioY4uuqV89Xk5kjGznAF5eMOOt3ERWEm9Gpamgq387ynstEwaVDjyOds3A6NSHu z5JrvKdgAVnfxpRiyWHWA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrtdeigddutdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 9 Feb 2024 12:36:31 -0500 (EST) From: Thomas Monjalon To: Amit Prakash Shukla Cc: fengchengwen , dev@dpdk.org, Kevin Laatz , Bruce Richardson , "dev@dpdk.org" , Jerin Jacob , Vamsi Krishna Attunuru , Nithin Kumar Dabilpuram , Anoob Joseph , "mb@smartsharesystems.com" Subject: Re: [EXT] Re: [PATCH v2] lib/dmadev: get DMA device using device ID Date: Fri, 09 Feb 2024 18:36:29 +0100 Message-ID: <2625483.9Mp67QZiUf@thomas> In-Reply-To: References: <20231208075526.2696553-1-amitprakashs@marvell.com> <2153070.3Lj2Plt8kZ@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 09/02/2024 12:30, Amit Prakash Shukla: > > > > > > > > > > invoke (*dev->dev_ops->dma_adapter_vchan_add)(dev, dma_dev_id, > > > > vchan, event), > > > > > > > > at cnxk driver, this ops will check whether the DMA is > > > > cnxk_dmadev_pci_driver. > > > > > > > > I think this is because the cnxk's event-and-dma implement has deep > > > > coupling > > > > > > > > (because the cnxk's event device could interact with another > > > > vendor's dma device). > > > > > > > > > > > > Maybe we should think of a better way to solve this kind of coupling > > > > problem. > > > > > > Id, is the DMA dev id which is used in looking up DMA dev. This API is in-line > > with the other libraries. > > > Crypto library has an api rte_cryptodev_pmd_get_dev to get crypto device > > based on device id. > > > > OK I think I understand. > > It is the library ID, the same as returned by int > > rte_dma_get_dev_id_by_name(const char *name); > > > > I can remove the const and apply if you are OK. > > Sure, I am okay. > > > I would just change this comment: > > > > + * @param dev_id > > + * Device ID value to select the device structure. > > > > into > > > > + * DMA device index in dmadev library. > > Sure. > Thanks. I've also fixed the ID type to be int16_t. Applied