From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f170.google.com (mail-lb0-f170.google.com [209.85.217.170]) by dpdk.org (Postfix) with ESMTP id 5BAEFC2E6 for ; Wed, 22 Jun 2016 09:52:12 +0200 (CEST) Received: by mail-lb0-f170.google.com with SMTP id ak10so17229839lbc.3 for ; Wed, 22 Jun 2016 00:52:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=+CJHh49HQZ8mgIo8v5Uy+ZXEXCvuUnoHD8x8N+rxzlc=; b=MpXfS1rFfUrRWsugXfhroVkENE1WO2KePaqSKyeg26Zw3I5hhEG3jh0G+/bFmLOKec UKN0XR0ae9nIQJZrbsdy6dhnCoCfjyvTBw7230A7/6Wkzrg2NSVf/uE6sfNQ64aNIcD8 FUfEYyzjrWMYODgEqR6jCSeY8DCnJz6fedDEs8hBCll/Sh5hiGID+QpwfcsZ2dJkxYrr wth7+G76o2B6jaQY8MHAKqm3JwfLKG+D5xxKZ9UwWGRmt1FJgAUVFZb0JkW2Fs/IPx5b FukZ8Z6EPOyYbSCZ+AItYCYNlGnJGJ35Z3Votgt3AItyszQCOr1Kt/lecS9i/f7Z8XDl Vuug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=+CJHh49HQZ8mgIo8v5Uy+ZXEXCvuUnoHD8x8N+rxzlc=; b=CPuKVircbQ765++JD4IPzi/QRowbc1cVildwHZYZXAiEruBZ12jLGIcqzkxL/PDvFB crMsvmsTbdX1V/5IF+FyjqdZFsep9xF/oKrpv9w2Xvhmn72LhBCFyd9RdEs6lAOse31e UCpGX3uWFsFJvfhSjDHNeK/qGWKWTC2qiuVq5bIwgwCaOuvlFC2LGRPXHUtdKkahqArJ ip9sTuaTIOHNpdMROxh+kuguy4swDh4azQAVOgXJEof1NWfE4pciV5ICae+s+C3SAlQN 6xVVGIlwcXmpo8FUOLOfL9RKoAq6aN4CSqByvA39Tco7uBX6IBi01suIs1wuOYj12YpE I9OQ== X-Gm-Message-State: ALyK8tKa6CP2NeuF1q1PUOLbXwMok8Hcj+pv0aw4cPa5K+5+1c3o91IplyVx6MW5BTmi7sr/ X-Received: by 10.194.22.169 with SMTP id e9mr23408533wjf.128.1466581931993; Wed, 22 Jun 2016 00:52:11 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id jf3sm41732236wjb.41.2016.06.22.00.52.10 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 22 Jun 2016 00:52:11 -0700 (PDT) From: Thomas Monjalon To: Jerin Jacob Cc: dev@dpdk.org, bruce.richardson@intel.com, pablo.de.lara.guarch@intel.com, john.mcnamara@intel.com, "Zhang, Helin" Date: Wed, 22 Jun 2016 09:52:10 +0200 Message-ID: <2626579.gf37SNjKxD@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160622071553.GA9860@localhost.localdomain> References: <1459250409-5123-2-git-send-email-jerin.jacob@caviumnetworks.com> <19576009.SQKuele073@xps13> <20160622071553.GA9860@localhost.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add tunnel and port RSS offload types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jun 2016 07:52:12 -0000 2016-06-22 12:45, Jerin Jacob: > On Wed, Jun 22, 2016 at 08:43:52AM +0200, Thomas Monjalon wrote: > > 2016-06-22 09:00, Jerin Jacob: > > > On Tue, Jun 21, 2016 at 11:02:59PM +0200, Thomas Monjalon wrote: > > > > 2016-03-31 02:21, Jerin Jacob: > > > > > +#define RTE_ETH_FLOW_PORT 18 > > > > > +#define RTE_ETH_FLOW_VXLAN 19 > > > > > +#define RTE_ETH_FLOW_GENEVE 20 > > > > > +#define RTE_ETH_FLOW_NVGRE 21 > > > > > +#define RTE_ETH_FLOW_MAX 22 > > > > > > > > Please could you explain more what is PORT flow? > > > > > > For example, a NIC card with two physical port where application > > > configures RTE_ETH_FLOW_IPV4 for both, In that case > > > HW generate same RSS value for a similar IPV4 packet, However, in-case if > > > application want to generate a flow that account physical port also then > > > it can configure with RTE_ETH_FLOW_IPV4 | RTE_ETH_FLOW_PORT. > > > > > > RTE_ETH_FLOW_PORT useful for the case where one physical port assigned for > > > INBOUND traffic and other-one for OUTBOUND traffic etc > > > > OK > > > > > > Does it need a comment in the code? > > > Not sure, commit log has description. > > > > How do you expect the user to understand this new value in the API? > > Users do not check in the git history. > > They use doxygen, headers comments and/or examples. > > The reason why I said because none of flow type has comments in the > list. If you think RTE_ETH_FLOW_PORT needs a doxygen comment then I can > add it. > > It would be nice some else could add the comments for following, > RTE_ETH_FLOW_RAW, > RTE_ETH_FLOW_L2_PAYLOAD These values passed without a proper check. That's why we must not accept any line in API without good comment. Please go ahead with what you can do and we'll fix or remove the remaining later.