From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1BEDA04F9; Fri, 10 Jan 2020 10:14:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 318291E93F; Fri, 10 Jan 2020 10:14:01 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id E33361E938 for ; Fri, 10 Jan 2020 10:13:58 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 69BA121F8A; Fri, 10 Jan 2020 04:13:58 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 10 Jan 2020 04:13:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=T3m/yR+BQuNj3xRixMGf96zReyNmUaKWdeSsqBPnyn0=; b=Vcu5k20d6uDu quMIIpGpSYqcwaRsZyT+lMguneC7hizl9W8x7s9TFeKk/aiOgm+79flD3Qt8bDqT sXcvuO/YM0YtkJcedvxbqUpZYB0rcyPAOeven5Rh98X5iFgiLfkikyfy8CQU9oSk XNmjeqXL7b4jFad7K/0E26Jmv+91UkY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=T3m/yR+BQuNj3xRixMGf96zReyNmUaKWdeSsqBPny n0=; b=vUH45PjZiuY8tDtdbKy90pSqhiGx0heiDl6kP9tRGf2yiuy/2SGWq0w1R M+DjwxocSETA0FBF7xAFY7sz+bswAMHVNYLdlG8OK5wmqZieV2QYPJVLHVjH/mG5 ltfIw99GQ9uG3AN3gUhdOSmpRhQ+mnEjMFfdZg5Tm+wLzEC09wsnKtMhEjiK2n6C qfhlD64TagPNfAFVIX+tUnK03tKnYBg9/hCgZi85IkcwUuFVSO6dBX90P27SZ4d/ R47Vqfxzon9J8IZmdjrbARuCSo5rjfu/k7fOZSsNiZ+XGWsLYYUwZaCVvBUIn/UK HsKyp8VuynruNkwpNPzGPiPqdGw3g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvdeifedgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 01AC28005B; Fri, 10 Jan 2020 04:13:56 -0500 (EST) From: Thomas Monjalon To: "Wang, Haiyue" , Matan Azrad Cc: Maxime Coquelin , "Bie, Tiwei" , "Wang, Zhihong" , "Wang, Xiao W" , "Yigit, Ferruh" , "dev@dpdk.org" , Andrew Rybchenko Date: Fri, 10 Jan 2020 10:13:55 +0100 Message-ID: <2627757.Y6S9NjorxK@xps> In-Reply-To: References: <1577287161-10321-1-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 3/3] drivers: move ifc driver to the vDPA class X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/01/2020 10:07, Matan Azrad: > From: Wang, Haiyue > > From: Matan Azrad > > > > delete mode 100644 doc/guides/nics/ifc.rst create mode 100644 > > > > doc/guides/vdpadevs/features/ifcvf.ini > > > > create mode 100644 doc/guides/vdpadevs/ifc.rst delete mode 100644 > > > > drivers/net/ifc/Makefile delete mode 100644 > > > > drivers/net/ifc/base/ifcvf.c delete mode 100644 > > > > drivers/net/ifc/base/ifcvf.h delete mode 100644 > > > > drivers/net/ifc/base/ifcvf_osdep.h > > > > delete mode 100644 drivers/net/ifc/ifcvf_vdpa.c delete mode 100644 > > > > drivers/net/ifc/meson.build delete mode 100644 > > > > drivers/net/ifc/rte_pmd_ifc_version.map > > > > create mode 100644 drivers/vdpa/ifc/Makefile create mode 100644 > > > > drivers/vdpa/ifc/base/ifcvf.c create mode 100644 > > > > drivers/vdpa/ifc/base/ifcvf.h create mode 100644 > > > > drivers/vdpa/ifc/base/ifcvf_osdep.h > > > > create mode 100644 drivers/vdpa/ifc/ifcvf_vdpa.c create mode > > > > 100644 drivers/vdpa/ifc/meson.build create mode 100644 > > > > drivers/vdpa/ifc/rte_pmd_ifc_version.map > > > > > >=20 > > git mv drivers/net/ifc/ drivers/vdpa/ifc ? ;-) >=20 > Yes, and more file move in docs. (you can see like rename in git =F0=9F= =98=8A) > Adjusted also the classes makefiles\measons to remove from net and to add= in vdpa. > Also MAINTAINER file etc... I think the comment from Haiyue was about the files deleted and created in the patch, instead of being moved (renamed). As far as I know, this is for 2 reasons: - there is no move in internal git representation - some versions of git-diff does not detect moves properly, but option -M may help