From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B96E7A0548; Wed, 1 Jun 2022 17:04:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F78840689; Wed, 1 Jun 2022 17:04:29 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 62F0F4003F; Wed, 1 Jun 2022 17:04:28 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D7FCC5C0246; Wed, 1 Jun 2022 11:04:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 01 Jun 2022 11:04:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1654095867; x= 1654182267; bh=dTqPsve4Yig6c7vhmzxNnPUDpcsoteHr1HFHwkPJPa0=; b=j 1x7wTmzwH5R1NEv+P6jdYhqPU/1LvKCdXVzVFa0B9OHwzKzwk+DKwGQBH+dEnStX bhHFKGnO56zX2rLs4DN93j09V0H4KJbGYgwP6LEZBB632eCBi7Ri34SsKANrPocp dM7yI3+giwFvNH9lc3APl6Z9CEqrKfdt+Yxa21LavSoEvffKOQbJEa8EA6iUoWRK UI6qXMtu/IYJbqiJ7ZjTtcXnPys3K2qEmJCCJKhogXDBaNDpZhXnQAFTff4UN/Ej 0nNXGkELnVNl/uT4Y/OG4vglaWe0PJYS63r7WggJ/RODGNqgNTUWnmqpvMVaOFX3 xf7HCyzmHOpqgl1BCO6AA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1654095867; x= 1654182267; bh=dTqPsve4Yig6c7vhmzxNnPUDpcsoteHr1HFHwkPJPa0=; b=M DNZcytTvnChkXlJ7yFjBuL+R84AI8ca3cwVU1souYyyPybF0KBTZaL6NIdn4hlJY hgye3Y4SYT9KxPpLDTm5+U5bROc5EhXN0sIAD1HyIyuGi1MdIqGTnzJ942GqHBAh 7pribHgSfbLhSITdpR2Y86h7T1bK9BoAifeJyMM3edYagPwyPmvb2iSH2LhiJHek YxnzVmUTaSH15++RdVUGtLAW23rws97sXjF8B79OXiobOy8wriFtrLJhsqhDAV5G 0e7O6GSwG6AAjVYNE7zUWupbYpwyoz4fprzvnjF2ECHPV8EMQ3WefZ3VVYzXQJij lkmj68VlroAwUYhsVg5VQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrledtgdekvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkjghfggfgtgesthfure dttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvd elteeufeefheeujefgueetfedttdeikefgkeduhedtgfenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrd hnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 1 Jun 2022 11:04:24 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: Tyler Retzlaff , david.marchand@redhat.com, techboard@dpdk.org, David Christensen , Ray Kinsella Subject: Re: [PATCH] eal/ppc: undefine AltiVec keyword vector Date: Wed, 01 Jun 2022 17:04:21 +0200 Message-ID: <2631038.mvXUDI8C0e@thomas> In-Reply-To: <87leuoblpg.fsf@mdr78.vserver.site> References: <20220525095307.675312-1-thomas@monjalon.net> <3966769.zXnORWrf4K@thomas> <87leuoblpg.fsf@mdr78.vserver.site> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 26/05/2022 13:02, Ray Kinsella: > Thomas Monjalon writes: > > 25/05/2022 20:34, Tyler Retzlaff: > >> On Wed, May 25, 2022 at 07:02:52PM +0100, Ray Kinsella wrote: > >> > Thomas Monjalon writes: > >> > > 25/05/2022 13:48, Ray Kinsella: > >> > >> Thomas Monjalon writes: > >> > >> > >> > >> > The AltiVec header file is defining "vector", except in C++ build. > >> > >> > The keyword "vector" may conflict easily. > >> > >> > As a rule, it is better to use the alternative keyword "__vector". > >> > >> > > >> > >> > The DPDK header file rte_altivec.h takes care of undefining "vector", > >> > >> > so the applications and dependencies are free to define the name "vector". > >> > >> > > >> > >> > This is a compatibility breakage for applications which were using > >> > >> > the keyword "vector" for its AltiVec meaning. > >> > >> > > >> > >> > Signed-off-by: Thomas Monjalon > >> > >> > --- > >> > >> > doc/guides/rel_notes/release_22_07.rst | 5 +++++ > >> > >> > lib/eal/ppc/include/rte_altivec.h | 7 +++++++ > >> > >> > 2 files changed, 12 insertions(+) > >> > >> > > >> > >> > >> > >> Acked-by: Ray Kinsella > >> > > > >> > > Just to make sure, we are all OK to break compatibility of rte_altivec.h? > >> > > It means the keyword vector is not available anymore with this #include. > >> > > Please confirm it is OK to merge in DPDK 22.07. > >> > > >> > I did think about it yes ;-). > >> > I can't see how it would break the ABI in the short term. > >> > And it makes sense to preclude this keyword in the long term. > >> > > >> > So I ack'ed - did I miss something? > >> > >> Acked-by: Tyler Retzlaff > >> > >> double ack, impact of break is understood as follows. > >> > >> * this is not an issue with abi it is an issue with api. > >> * the break will cause a compile failure, the action to resolve is to > >> replace vector with __vector. > > > > Exactly > > > > I'll wait few days or acks from the techboard, and will apply. > > +1 Applied