From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id B66CA10CAD for ; Wed, 21 Dec 2016 17:19:31 +0100 (CET) Received: by mail-wm0-f41.google.com with SMTP id a197so152647530wmd.0 for ; Wed, 21 Dec 2016 08:19:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=FyWDJpv/wsVEu7tuERnwD3axtS3If4Ob2Wr3gvHzEFY=; b=iGAFNxrGvoNr6CxK/UYS8fN3e7czo7d6sQV3+BAG+w7xTzP+lI3RYMqHgGX0SinJhG K3piN5QlMzlOaZ+nMpuA+3OBVxIA1MJ1cNuEHxqJ9WHct8IHdz7dP8q5lf7GL8HfUd9N m3y75dYkviB/wQNgRmBve5ytIM3Ind4aqYW50qOmQ3IBoglGA7riCoHDblBG5uqSGIIr 07gS71lRRl4D6c3iriCfdgH+C/mKl8/q7P38Bit0FcRYV27gQX1haWeHA+Dzwd8h9gQf tLwct0aTE+suwYLXhwyj1F0gx8PqxZ9J1GfGXpXBRWI/my27B5PlSCnLYqeoJIo8EZMr cDCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=FyWDJpv/wsVEu7tuERnwD3axtS3If4Ob2Wr3gvHzEFY=; b=LCY4Dak+EJ8Neq4lmifIzcWZD4biazPpk3l/8E/HtBsRuwhDCcCN5DuULUeTxgNCcr ErCdzqL5NngMXO2loHl7WDQNAwWWjbptjR6ywkZQgTVnRphonrQ81DHlDmVMJdRsdesJ yJFF6R7TPOxhRNLVd6TdbuKgBEQEcI5KMn1VaKWVz48z6h1Nldz4F7GH58zlqc0vhWKM t/RBNWyh0PlZYY/bqKv1th+tJDebH7Q6Okq3Gb0LnZ/yaofNiOca/DRffWiHWOcCUzfc b8npiFF0batwMRP+SAe3DjU9KDttFJC0ZHYgJEQWjxpx+WFfQrqRbivbw17SvFAl1gef Ml+A== X-Gm-Message-State: AIkVDXK5vavnyXMKkBducwm2NJCF30sqbgUJQlJF+AD2BgqoyvlJ72despxnGqL30vMTRpUu X-Received: by 10.28.64.67 with SMTP id n64mr4928838wma.34.1482337171428; Wed, 21 Dec 2016 08:19:31 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id e188sm27933934wma.21.2016.12.21.08.19.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Dec 2016 08:19:30 -0800 (PST) From: Thomas Monjalon To: Shreyansh Jain , Ben Walker Cc: dev@dpdk.org Date: Wed, 21 Dec 2016 17:19:29 +0100 Message-ID: <2631459.aun9V5NdHs@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1479929804-19614-1-git-send-email-benjamin.walker@intel.com> <1479931644-78960-1-git-send-email-benjamin.walker@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/7] pci: If a driver's probe function fails, unmap resources. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Dec 2016 16:19:31 -0000 2016-11-25 14:51, Shreyansh Jain: > On Thursday 24 November 2016 01:37 AM, Ben Walker wrote: > > If resources were mapped prior to probe, unmap them > > if probe fails. > > > > This does not handle the case where the kernel driver was > > forcibly unbound prior to probe. > > > > Signed-off-by: Ben Walker > > Acked-by: Shreyansh Jain The 3 first patches of this series seems good and easy to agree, except some minor nits. Please Ben or Shreyansh, could you respin only them to help make progress before applying a PCI/bus rework from Shreyansh? As soon as one of you shoot a partial v3, I'll apply them. Thanks