[dpdk-dev] [PATCH] usertools/devbind: update octeontx2 DMA device

[dpdk-dev] [PATCH] usertools/devbind: update octeontx2 DMA device

[Radha Mohan Chintakuntla]

The octeontx2_dma rawdev driver is removed in DPDK-21.11. The new driver
for the same device uses the dmadev. So this patch updates the device
naming and lists it under dma devices section.

Signed-off-by: Radha Mohan Chintakuntla <radhac@marvell.com>
---
 usertools/dpdk-devbind.py | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index af9a0ad5ab..e298ad5f75 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -41,8 +41,8 @@
                  'SVendor': None, 'SDevice': None}
 octeontx2_npa = {'Class': '08', 'Vendor': '177d', 'Device': 'a0fb,a0fc',
                  'SVendor': None, 'SDevice': None}
-octeontx2_dma = {'Class': '08', 'Vendor': '177d', 'Device': 'a081',
-                 'SVendor': None, 'SDevice': None}
+cnxk_dma = {'Class': '08', 'Vendor': '177d', 'Device': 'a081',
+            'SVendor': None, 'SDevice': None}
 octeontx2_ree = {'Class': '08', 'Vendor': '177d', 'Device': 'a0f4',
                  'SVendor': None, 'SDevice': None}
 cnxk_bphy = {'Class': '08', 'Vendor': '177d', 'Device': 'a089',
@@ -75,13 +75,14 @@
 baseband_devices = [acceleration_class]
 crypto_devices = [encryption_class, intel_processor_class]
 dma_devices = [hisilicon_dma,
-               intel_idxd_spr, intel_ioat_bdw, intel_ioat_icx, intel_ioat_skx]
+               intel_idxd_spr, intel_ioat_bdw, intel_ioat_icx, intel_ioat_skx,
+               cnxk_dma]
 eventdev_devices = [cavium_sso, cavium_tim, intel_dlb, octeontx2_sso]
 mempool_devices = [cavium_fpa, octeontx2_npa]
 compress_devices = [cavium_zip]
 regex_devices = [octeontx2_ree]
-misc_devices = [cnxk_bphy, cnxk_bphy_cgx, cnxk_inl_dev, intel_ntb_skx,
-                intel_ntb_icx, octeontx2_dma]
+misc_devices = [cnxk_bphy, cnxk_bphy_cgx, cnxk_inl_dev,
+                intel_ntb_skx, intel_ntb_icx]
 
 # global dict ethernet devices present. Dictionary indexed by PCI address.
 # Each device within this is itself a dictionary of device properties
-- 
2.17.1

Re: [dpdk-dev] [PATCH] usertools/devbind: update octeontx2 DMA device

[Thomas Monjalon]

09/11/2021 17:55, Radha Mohan Chintakuntla:
> The octeontx2_dma rawdev driver is removed in DPDK-21.11. The new driver
> for the same device uses the dmadev. So this patch updates the device
> naming and lists it under dma devices section.
> 
> Signed-off-by: Radha Mohan Chintakuntla <radhac@marvell.com>
> ---
>  usertools/dpdk-devbind.py | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
> index af9a0ad5ab..e298ad5f75 100755
> --- a/usertools/dpdk-devbind.py
> +++ b/usertools/dpdk-devbind.py
> @@ -41,8 +41,8 @@
>                   'SVendor': None, 'SDevice': None}
>  octeontx2_npa = {'Class': '08', 'Vendor': '177d', 'Device': 'a0fb,a0fc',
>                   'SVendor': None, 'SDevice': None}
> -octeontx2_dma = {'Class': '08', 'Vendor': '177d', 'Device': 'a081',
> -                 'SVendor': None, 'SDevice': None}
> +cnxk_dma = {'Class': '08', 'Vendor': '177d', 'Device': 'a081',
> +            'SVendor': None, 'SDevice': None}

It doesn't look logical to have cnxk device in the middle of octeontx2 ones.
Maybe before to sort it a bit alphabetically?

>  dma_devices = [hisilicon_dma,
> -               intel_idxd_spr, intel_ioat_bdw, intel_ioat_icx, intel_ioat_skx]
> +               intel_idxd_spr, intel_ioat_bdw, intel_ioat_icx, intel_ioat_skx,
> +               cnxk_dma]

Would be better at the beginning of the list, before hisilicon
so it is alphabetically sorted.

Re: [dpdk-dev] [PATCH] usertools/devbind: update octeontx2 DMA device

[Radha Mohan]

On Tue, Nov 9, 2021 at 12:50 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 09/11/2021 17:55, Radha Mohan Chintakuntla:
> > The octeontx2_dma rawdev driver is removed in DPDK-21.11. The new driver
> > for the same device uses the dmadev. So this patch updates the device
> > naming and lists it under dma devices section.
> >
> > Signed-off-by: Radha Mohan Chintakuntla <radhac@marvell.com>
> > ---
> >  usertools/dpdk-devbind.py | 11 ++++++-----
> >  1 file changed, 6 insertions(+), 5 deletions(-)
> >
> > diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
> > index af9a0ad5ab..e298ad5f75 100755
> > --- a/usertools/dpdk-devbind.py
> > +++ b/usertools/dpdk-devbind.py
> > @@ -41,8 +41,8 @@
> >                   'SVendor': None, 'SDevice': None}
> >  octeontx2_npa = {'Class': '08', 'Vendor': '177d', 'Device': 'a0fb,a0fc',
> >                   'SVendor': None, 'SDevice': None}
> > -octeontx2_dma = {'Class': '08', 'Vendor': '177d', 'Device': 'a081',
> > -                 'SVendor': None, 'SDevice': None}
> > +cnxk_dma = {'Class': '08', 'Vendor': '177d', 'Device': 'a081',
> > +            'SVendor': None, 'SDevice': None}
>
> It doesn't look logical to have cnxk device in the middle of octeontx2 ones.
> Maybe before to sort it a bit alphabetically?

ok sure will do. I thought about it but rest of them were not in any
order so didn't think it wouldn't matter.
>
> >  dma_devices = [hisilicon_dma,
> > -               intel_idxd_spr, intel_ioat_bdw, intel_ioat_icx, intel_ioat_skx]
> > +               intel_idxd_spr, intel_ioat_bdw, intel_ioat_icx, intel_ioat_skx,
> > +               cnxk_dma]
>
> Would be better at the beginning of the list, before hisilicon
> so it is alphabetically sorted.

ok.

>
>
>

[dpdk-dev] [PATCH v2] usertools/devbind: update octeontx2 DMA device

[Radha Mohan Chintakuntla]

The octeontx2_dma rawdev driver is removed in DPDK-21.11. The new driver
for the same device uses the dmadev. So this patch updates the device
naming and lists it under dma devices section.

Signed-off-by: Radha Mohan Chintakuntla <radhac@marvell.com>
---
Changes from v1:
- Sort the names alphabetically

 usertools/dpdk-devbind.py | 24 +++++++++++++-----------
 1 file changed, 13 insertions(+), 11 deletions(-)

diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index af9a0ad5ab..c8874066f7 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -37,18 +37,12 @@
 avp_vnic = {'Class': '05', 'Vendor': '1af4', 'Device': '1110',
             'SVendor': None, 'SDevice': None}
 
-octeontx2_sso = {'Class': '08', 'Vendor': '177d', 'Device': 'a0f9,a0fa',
-                 'SVendor': None, 'SDevice': None}
-octeontx2_npa = {'Class': '08', 'Vendor': '177d', 'Device': 'a0fb,a0fc',
-                 'SVendor': None, 'SDevice': None}
-octeontx2_dma = {'Class': '08', 'Vendor': '177d', 'Device': 'a081',
-                 'SVendor': None, 'SDevice': None}
-octeontx2_ree = {'Class': '08', 'Vendor': '177d', 'Device': 'a0f4',
-                 'SVendor': None, 'SDevice': None}
 cnxk_bphy = {'Class': '08', 'Vendor': '177d', 'Device': 'a089',
              'SVendor': None, 'SDevice': None}
 cnxk_bphy_cgx = {'Class': '08', 'Vendor': '177d', 'Device': 'a059,a060',
                  'SVendor': None, 'SDevice': None}
+cnxk_dma = {'Class': '08', 'Vendor': '177d', 'Device': 'a081',
+            'SVendor': None, 'SDevice': None}
 cnxk_inl_dev = {'Class': '08', 'Vendor': '177d', 'Device': 'a0f0,a0f1',
                 'SVendor': None, 'SDevice': None}
 
@@ -71,17 +65,25 @@
 intel_ntb_icx = {'Class': '06', 'Vendor': '8086', 'Device': '347e',
                  'SVendor': None, 'SDevice': None}
 
+octeontx2_sso = {'Class': '08', 'Vendor': '177d', 'Device': 'a0f9,a0fa',
+                 'SVendor': None, 'SDevice': None}
+octeontx2_npa = {'Class': '08', 'Vendor': '177d', 'Device': 'a0fb,a0fc',
+                 'SVendor': None, 'SDevice': None}
+octeontx2_ree = {'Class': '08', 'Vendor': '177d', 'Device': 'a0f4',
+                 'SVendor': None, 'SDevice': None}
+
 network_devices = [network_class, cavium_pkx, avp_vnic, ifpga_class]
 baseband_devices = [acceleration_class]
 crypto_devices = [encryption_class, intel_processor_class]
-dma_devices = [hisilicon_dma,
+dma_devices = [cnxk_dma,
+               hisilicon_dma,
                intel_idxd_spr, intel_ioat_bdw, intel_ioat_icx, intel_ioat_skx]
 eventdev_devices = [cavium_sso, cavium_tim, intel_dlb, octeontx2_sso]
 mempool_devices = [cavium_fpa, octeontx2_npa]
 compress_devices = [cavium_zip]
 regex_devices = [octeontx2_ree]
-misc_devices = [cnxk_bphy, cnxk_bphy_cgx, cnxk_inl_dev, intel_ntb_skx,
-                intel_ntb_icx, octeontx2_dma]
+misc_devices = [cnxk_bphy, cnxk_bphy_cgx, cnxk_inl_dev,
+                intel_ntb_skx, intel_ntb_icx]
 
 # global dict ethernet devices present. Dictionary indexed by PCI address.
 # Each device within this is itself a dictionary of device properties
-- 
2.17.1

Re: [dpdk-dev] [PATCH v2] usertools/devbind: update octeontx2 DMA device

[Thomas Monjalon]

10/11/2021 00:32, Radha Mohan Chintakuntla:
> The octeontx2_dma rawdev driver is removed in DPDK-21.11. The new driver
> for the same device uses the dmadev. So this patch updates the device
> naming and lists it under dma devices section.
> 
> Signed-off-by: Radha Mohan Chintakuntla <radhac@marvell.com>

Applied, thanks.