From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3850B41E71; Sat, 11 Mar 2023 11:17:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 18C0140DDC; Sat, 11 Mar 2023 11:17:10 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 0E2A240A89; Sat, 11 Mar 2023 11:17:09 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 5070E5C00D9; Sat, 11 Mar 2023 05:17:08 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 11 Mar 2023 05:17:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1678529828; x=1678616228; bh=Z1Jz2BS0AZhcyI6YWhH8d/aHf2l4DkUyznP zEnwYUak=; b=nwG6aluSRzDBSFREzz9nhd7At8uxEj8FJIb184DW0phCq6JJggO JDVyvEiuMOnrLq8t01hcemNRFcaddZzawOuoks3cAN9Spg3/9438pUA3SC+N7w1R TUMwJTqJ7bfIte9uYwS3z6CsYmuszKfaf55e/g1NKDvGIAW4fbh/QeDAmUWvwTja 6DRYoWjkHqlcO/ZwNzsPqzYmKniQx1lx4R9IYuYwJKel6OBdMZz2/DueOZck9XaB r95kP258/gTuUm5tmcbUwKwkEkBkqytcToFixhXnN1Mf2t6/ZwYMi8D5gvN1c3n/ MWoOJUOPrhkk3Y0aoY0925UYr8hbwAbIQLQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1678529828; x=1678616228; bh=Z1Jz2BS0AZhcyI6YWhH8d/aHf2l4DkUyznP zEnwYUak=; b=MpIVf62mK3EmHVj7UWCvFUzN//coSLifjpW6E2pq1ZibSs2Wrzu vtatFnGH5R1ZUs5WxOsSTQINyVeaDpRF7gffSxDitRpi+kCimApdF3m993nad1Mq 30G9+c6vOh9B0zmHK6kdtOObMezrSNZOJ1NOqi8RrLJDUybjf7vYr+is05l2t3Ny gcyREpd2dgnALlx87IOX0EhpouQo6kuxi+aadSOFddvKZY9Xi7LbZvdfN6CKvGHr mH/XlD/i6I8A8+ByZhEviFtHbkBN3iVhK4OBl5DeAMNAI52ti3z5fL7KoZOQYMhu Ud0oxyWtm9BuuFRIeG6yhCgjhUlhSarmXFQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdduledgudeflecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 11 Mar 2023 05:17:07 -0500 (EST) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, stable@dpdk.org, ferruh.yigit@amd.com, aman.deep.singh@intel.com, Yuying Zhang Subject: Re: [PATCH v11 0/3] Fix cmdline_poll and testpmd signal handling Date: Sat, 11 Mar 2023 11:17:05 +0100 Message-ID: <2636586.KRxA6XjA2N@thomas> In-Reply-To: <20230219095348.5f496a67@hermes.local> References: <20230130200914.22049-1-stephen@networkplumber.org> <20230203191409.97567-1-stephen@networkplumber.org> <20230219095348.5f496a67@hermes.local> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 19/02/2023 18:53, Stephen Hemminger: > On Fri, 3 Feb 2023 11:14:06 -0800 > Stephen Hemminger wrote: > > > This patchset keeps uncovering bad practices in the cmdline library > > around end of file and signal handling. > > > > Stephen Hemminger (3): > > cmdline: make rdline status not private > > cmdline: handle EOF in cmdline_poll > > testpmd: cleanup cleanly from signal > > > > app/test-pmd/cmdline.c | 29 +++++-------- > > app/test-pmd/testpmd.c | 77 ++++++++++++++++------------------- > > app/test-pmd/testpmd.h | 1 + > > lib/cmdline/cmdline.c | 11 +++-- > > lib/cmdline/cmdline.h | 6 +++ > > lib/cmdline/cmdline_private.h | 6 --- > > 6 files changed, 62 insertions(+), 68 deletions(-) > > > > Could this please be merged for 23.03? > There are Ack's. > The only CI failure is a bogus performance test failure. There was no review from testpmd maintainers. I've added Cc: stable@dpdk.org. Applied, thanks.