From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF56DA0A02; Thu, 14 Jan 2021 10:30:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5412A140F62; Thu, 14 Jan 2021 10:30:35 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id D108A140F50 for ; Thu, 14 Jan 2021 10:30:33 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 7C8CB5C0107; Thu, 14 Jan 2021 04:30:31 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 14 Jan 2021 04:30:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= nKtmCSJyY9ngxrGAmwC3DyQZw4yHRupfFpawUGydsWQ=; b=BYR6hSgIYIAnky32 yY7/E9aESAH/yVg1k0tZee/wfxZk257aoDuxt32edpfGgrjXPOT26N2nFmsVMTbD vAWdnZzE3BK2pOR64Y13mWBEm1ajlXZdyMgKIGrvKBUXuaN2O348JVMZ8yabRKL6 nQvkePhUTvT7v/UzlG87rc9VO3SnZLhPDrl20zYQ41BQ11wsWzsE+EfOR2szpmlZ 7uhNFDXFQPPSEoGjr7+kDTTV2/QCHGR/dfQSHJGfglC/vVFuM86j72aLVcmPr3ml inEgGxqbePZpd2wmA9AC30zucFyq7fFnGOOYPhc9r5mKNlAXxjO1Mol2/9gLcoUk aaiZ0w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=nKtmCSJyY9ngxrGAmwC3DyQZw4yHRupfFpawUGyds WQ=; b=dBZwBYx6es2uy+/A9ZTYe9VZ9nRKrJH3dx2vcYnPQ1qy6sow06uPv/DHg bv1Q+GQ6gfP+/5qvH3fHqpF1FcPEt9yCQbtNqlPWq56WmA44xnuq4bcpeU0QYPmx W4IvurpAabtroQ6+pmJFBlpdK4Lf6hgKtExFQlHkjK6cFa6GX20vDHvmUzmclfH4 OkbALwXxImdE/kUdzrUbKrovsyRzwMS91o27IK0huzX5bdGMJiYoUOZR6l+vysga JZd5XoUq0WtDeAu5vQ+eecvEP51xo1UTTOEhBk+3epKgZYl83hYVFM+O0xl61L7W roskCHXPHbCi+YWMJn4l4S+t4hAgg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedukedrtdehgddtvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeffvdffjeeuteelfeeileduudeugfetjeelveefkeejfeeigeehteff vdekfeegudenucffohhmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvd dtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id F21651080057; Thu, 14 Jan 2021 04:30:29 -0500 (EST) From: Thomas Monjalon To: Tal Shnaiderman Cc: Dmitry Kozlyuk , "dev@dpdk.org" , Olivier Matz , Bruce Richardson , Ranjit Menon , Aaron Date: Thu, 14 Jan 2021 10:30:29 +0100 Message-ID: <2637046.0b4CQWxj9Z@thomas> In-Reply-To: References: <20210112003602.29004-1-dmitry.kozliuk@gmail.com> <1999240.RY27NfppNA@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] build: fix using ELF-only linker flags with COFF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/01/2021 10:27, Tal Shnaiderman: > > Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] build: fix using ELF-only linker > > flags with COFF > > > > External email: Use caution opening links or attachments > > > > > > 13/01/2021 21:27, Ranjit Menon: > > > On 1/11/2021 4:36 PM, Dmitry Kozlyuk wrote: > > > > The --export-dynamic linker option is only applicable to ELF. > > > > On Windows, where COFF is used, it causes warnings: > > > > > > > > x86_64-w64-mingw32-ld: warning: --export-dynamic is not supported > > > > for PE+ targets, did you mean --export-all-symbols? (MinGW) > > > > > > > > LINK : warning LNK4044: unrecognized option '/-export-dynamic'; > > > > ignored (clang) > > > > > > > > Don't add --export-dynamic on Windows anywhere. > > > > > > > > Fixes: b031e13d7f0d ("build: fix plugin load on static build") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Dmitry Kozlyuk > > > > --- > > > > Using TLS variables with DLLs is problematic on Windows for now, so > > > > not attempting to check or solve the issue with plugin load. > > > > > > Acked-by: Ranjit Menon > > > > Applied, thanks > > > > Why we didn't catch it in advance in CI? > > > > I think Windows CI still passes on builds with warnings, maybe we can change it now that we cleared all of them. Yes. Please can you open a ticket in bugs.dpdk.org in the section lab/jobs? Thank you