From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 3EB4F1EF58 for ; Wed, 13 Jun 2018 17:16:52 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CED8321DF1; Wed, 13 Jun 2018 11:16:48 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 13 Jun 2018 11:16:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=iF06xCiQ/+pq48G73FGu57tn3M JTPlOOJNI+3cHwGWY=; b=UjpQscxr+xI0bx24K5fbYAIJT79g88SmBAz54gb7pA TR31WQJdLnLOJzUOvdFvEscU5RhWQ+fejO3Bw/FI8WNnA1RsB1fwc5SsFHYxZZag hRCcrKZ3vss11pyrbfPhhAcFJ2LkYvp5UH4JzU62msK1KAtHOfHYIZxwXaZGDcTT g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=iF06xC iQ/+pq48G73FGu57tn3MJTPlOOJNI+3cHwGWY=; b=Z/eqxDC76avdmO0LL3z+fb DegMQYBw4F/IxrxpIzLsk7L8kzrM6akr+1Kn0pFbjC7CZ5psLZg6OqemxBqjS7L4 xyrVD/lz7v53S76SQzEU/ZpWRySK+iE+2CdDFIw6HerTnWzPACEm1bur5zIHkGk/ ufKDzlIYW4dCGCEA44J+7Wp/qDmtH/fS6+rxndR5x2VcgzzjMqPbOZmPWYYMqo34 xGpYiIZB3o8TNjs74Se4KGTDUuDh/SMU7x/EugfI9aGTN78XKAIpbXlMrf8Gggm6 kdMpqflnmWUVSSlbQiz1JOuXqVdRN1ViR4cxMDe1Ga05RiS1xZVdOXz8iTScGeCw == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C191E102A2; Wed, 13 Jun 2018 11:16:47 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Shahaf Shuler , Wei Dai , Qi Zhang , Andrew Rybchenko Date: Wed, 13 Jun 2018 17:16:46 +0200 Message-ID: <2637487.4jdQHLv9Lb@xps> In-Reply-To: <6291522.OcHR8ZgW26@xps> References: <20180531124431.13746-1-ferruh.yigit@intel.com> <6291522.OcHR8ZgW26@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: force offloading API rules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jun 2018 15:16:52 -0000 08/06/2018 22:01, Thomas Monjalon: > 08/06/2018 21:51, Ferruh Yigit: > > On 5/31/2018 1:44 PM, Ferruh Yigit wrote: > > > The error path was disabled in previous release to let apps to be more > > > flexible. > > > > > > But this release they are enabled, applications have to obey offload API > > > rules otherwise they will get errors from following APIs: > > > rte_eth_dev_configure > > > rte_eth_rx_queue_setup > > > rte_eth_tx_queue_setup > > > > > > Signed-off-by: Ferruh Yigit > > > --- > > > Cc: Shahaf Shuler > > > Cc: Wei Dai > > > Cc: Qi Zhang > > > Cc: Andrew Rybchenko > > > > Any objection to this patch? > > I really would like to get this early to catch any possible issue. > > Yes you're right. > Let's merge it. Acked-by: Thomas Monjalon