From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 718EC427F6; Tue, 21 Mar 2023 11:30:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E1F0410D3; Tue, 21 Mar 2023 11:30:27 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 0A4A740A7A; Tue, 21 Mar 2023 11:30:26 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 3B06D3200C46; Tue, 21 Mar 2023 06:30:24 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 21 Mar 2023 06:30:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1679394623; x=1679481023; bh=5uoI1S7rI2YjWJV7tszOOzUjnuGFTCk/Jzo 7a28FODY=; b=wrhN/EdiSUs+drDsjiUPjoCfNTGmVOR7N17FUura5G4vCacGLZ1 +CfTiOOoBitLt8nabj3kwqpfLn/eYoRM0cVPtjYPa1zJfMc0KAYdnWB8dklEC2sN YgOkXcHMBDC5m22fqk1Mc7IcpDpXei1Xy4PN4OxdGNxL0zE9gLGTDNwGpPqXElgm A7PEbXmgj9RBjl/wsv+BUKEruF3Jv3hlIf0v+MCTgFcLB8uzOCCPZU9VjhpDbepa S1oEaMuD0V99SmStH7TGB/A0/GYeLYldUKddpDJy7eWRr15dri6vNn8j3edOYQKV Cn9jaLz5N3iTvk0D2LozvE4UrR/B9nejQng== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1679394623; x=1679481023; bh=5uoI1S7rI2YjWJV7tszOOzUjnuGFTCk/Jzo 7a28FODY=; b=YM9KkKCf+hbc/tTa6UFgbc07C7IcZuzzssMdckPWacPB1vzt9cj GgT2DbzMPHC8t0Ect2VVvUluarX57CydfllJfZyW71RiiHOLeTy+XlrRxWv8ZgZs G4yL5RsCO/asjKZx8K2eGlpm6KuPhZeGnamPwQqy3vpgO0CKvcjYlUZoREurHyzO ief59N2wsJiVCnmNVaDshz5kKgr/k3kT1BovQscnG2wsoqWH+CdPS9L6GlEEIELR VWUcMifrKr7+PsCuYH7D1SLQxTqujpofWI/Tp6EnyegGtugRSXRKtahsEX3msbHa BoqrAlgBO5HgbN1zWtqQ0IGjHmzPN9hkttg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdegtddgudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 21 Mar 2023 06:30:22 -0400 (EDT) From: Thomas Monjalon To: "Huang, Wei" Cc: "dev@dpdk.org" , "david.marchand@redhat.com" , "stable@dpdk.org" , "Xu, Rosen" , "Zhang, Tianfei" , "Zhang, Qi Z" Subject: Re: [PATCH v1] raw/ifpga: remove virtual device unplug operation Date: Tue, 21 Mar 2023 11:30:19 +0100 Message-ID: <2637984.KRxA6XjA2N@thomas> In-Reply-To: References: <20230316204445.360330-1-wei.huang@intel.com> <18059490.sWSEgdgrri@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 21/03/2023 09:41, Huang, Wei: > From: Thomas Monjalon > > 21/03/2023 01:11, Huang, Wei: > > > From: Thomas Monjalon > > > > 16/03/2023 21:44, Wei Huang: > > > > > VDEV bus has implemented cleanup() function to perform cleanup for > > > > > devices on the bus during eal_cleanup(), so there is no need for > > > > > ifpga driver to record virtual devices and unplug them. > > > > > > > > Why no need? > > > > If the application wants to explicitly remove a device, what happens? > > > > > > > > > > > EAL will output an error information "Cannot find plugged device (%s)". > > > > It does not look what we expect. > > > Let me clear it. > With this patch, no error information will be outputted. > Without this patch, error information will be outputted. > Because bus cleanup action will unplug virtual device, > then ifpga PMD unplug the virtual device which is already be cleanup, Why ipfga unplug the device after the bus cleanup? I'm not following. > bus->find_device() returns NULL, > EAL output "Cannot find plugged device (%s)\n" at line 302 in eal_common_dev.c Anyway, the good answer is not to completely remove the "remove" operation.