[PATCH 00/11] Fix repeated words in comments and messages

[PATCH 00/11] Fix repeated words in comments and messages

[Stephen Hemminger]

Reading netdev, noticed lots of places in Linux kernel with bad
comments being fixed.  Use similar kind of scanning to look
for repeated words in DPDK.

Stephen Hemminger (11):
  remove duplicated 'to to' in messages and comments
  remove duplicate words 'is is'
  mvnet,mvpp2: remove duplicate word
  Remove repeated word 'on on'
  fix repeated words 'in in'
  ring: fix repeated word in comment
  i40e,igc: fix duplicate word than
  bnx2x, pcap: replace only only
  distrubutor: fix repeated word in comment
  ethdev: fix repeated word in comment
  cxgbe: replace 'or or' in comment

 app/test/test_resource.c                    | 2 +-
 drivers/common/sfc_efx/base/efx_regs_mcdi.h | 2 +-
 drivers/common/sfc_efx/base/efx_types.h     | 2 +-
 drivers/common/sfc_efx/base/siena_nvram.c   | 2 +-
 drivers/event/sw/sw_evdev.c                 | 2 +-
 drivers/net/bnx2x/bnx2x.c                   | 2 +-
 drivers/net/bonding/rte_eth_bond_8023ad.h   | 2 +-
 drivers/net/cxgbe/sge.c                     | 2 +-
 drivers/net/hns3/hns3_ethdev.c              | 2 +-
 drivers/net/i40e/i40e_fdir.c                | 2 +-
 drivers/net/igc/base/igc_mac.c              | 2 +-
 drivers/net/mlx5/mlx5_flow.c                | 2 +-
 drivers/net/mvneta/mvneta_ethdev.c          | 2 +-
 drivers/net/mvpp2/mrvl_ethdev.c             | 2 +-
 drivers/net/pcap/pcap_ethdev.c              | 2 +-
 drivers/net/sfc/sfc_ef10_tx.c               | 2 +-
 drivers/net/sfc/sfc_tso.c                   | 2 +-
 examples/vm_power_manager/channel_monitor.h | 2 +-
 examples/vm_power_manager/oob_monitor.h     | 2 +-
 lib/distributor/rte_distributor.c           | 2 +-
 lib/ethdev/rte_ethdev.h                     | 2 +-
 lib/mbuf/rte_mbuf_core.h                    | 2 +-
 lib/net/rte_ether.h                         | 2 +-
 lib/pipeline/rte_swx_ctl.c                  | 2 +-
 lib/power/guest_channel.c                   | 2 +-
 lib/ring/rte_ring.c                         | 2 +-
 26 files changed, 26 insertions(+), 26 deletions(-)

-- 
2.35.1

[PATCH 01/11] remove duplicated 'to to' in messages and comments

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 app/test/test_resource.c                  | 2 +-
 drivers/common/sfc_efx/base/siena_nvram.c | 2 +-
 lib/pipeline/rte_swx_ctl.c                | 2 +-
 lib/power/guest_channel.c                 | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/app/test/test_resource.c b/app/test/test_resource.c
index 8f41e3babdc5..05c27db203cc 100644
--- a/app/test/test_resource.c
+++ b/app/test/test_resource.c
@@ -45,7 +45,7 @@ static int test_resource_c(void)
 			r->name);
 
 	TEST_ASSERT_SUCCESS(resource_fwrite_file(r, "test_resource.c"),
-			"Failed to to write file %s", r->name);
+			"Failed to write file %s", r->name);
 
 	f = fopen("test_resource.c", "r");
 	TEST_ASSERT_NOT_NULL(f,
diff --git a/drivers/common/sfc_efx/base/siena_nvram.c b/drivers/common/sfc_efx/base/siena_nvram.c
index 05ca4bd83dc9..ebcd3487b631 100644
--- a/drivers/common/sfc_efx/base/siena_nvram.c
+++ b/drivers/common/sfc_efx/base/siena_nvram.c
@@ -532,7 +532,7 @@ siena_nvram_partn_get_version(
 			: MC_CMD_NVRAM_TYPE_DYNAMIC_CFG_PORT1;
 		/*
 		 * Ingore missing partitions on port 2, assuming they're due
-		 * to to running on a single port part.
+		 * to running on a single port part.
 		 */
 		if ((1 << dcfg_partn) &  ~enp->en_u.siena.enu_partn_mask) {
 			if (entry->port == 2)
diff --git a/lib/pipeline/rte_swx_ctl.c b/lib/pipeline/rte_swx_ctl.c
index 710e89a46a26..9b7bf5e0fb01 100644
--- a/lib/pipeline/rte_swx_ctl.c
+++ b/lib/pipeline/rte_swx_ctl.c
@@ -1582,7 +1582,7 @@ rte_swx_ctl_pipeline_table_entry_delete(struct rte_swx_ctl_pipeline *ctl,
 	CHECK(!table_entry_check(ctl, table_id, entry, 1, 0), EINVAL);
 
 	/* The entry is found in the table->entries list:
-	 * - Move the existing entry from the table->entries list to to the
+	 * - Move the existing entry from the table->entries list to the
 	 *   table->pending_delete list.
 	 */
 	existing_entry = table_entries_find(table, entry);
diff --git a/lib/power/guest_channel.c b/lib/power/guest_channel.c
index 969a9e5aaa06..7b2ae0b6506f 100644
--- a/lib/power/guest_channel.c
+++ b/lib/power/guest_channel.c
@@ -74,7 +74,7 @@ guest_channel_host_connect(const char *path, unsigned int lcore_id)
 			fd_path, lcore_id);
 	fd = open(fd_path, O_RDWR);
 	if (fd < 0) {
-		RTE_LOG(ERR, GUEST_CHANNEL, "Unable to to connect to '%s' with error "
+		RTE_LOG(ERR, GUEST_CHANNEL, "Unable to connect to '%s' with error "
 				"%s\n", fd_path, strerror(errno));
 		return -1;
 	}
-- 
2.35.1

[PATCH 02/11] remove duplicate words 'is is'

[Stephen Hemminger]

Found by scanning for duplicate words.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/common/sfc_efx/base/efx_regs_mcdi.h | 2 +-
 lib/net/rte_ether.h                         | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/common/sfc_efx/base/efx_regs_mcdi.h b/drivers/common/sfc_efx/base/efx_regs_mcdi.h
index 2daf825a366e..f3ec456864f6 100644
--- a/drivers/common/sfc_efx/base/efx_regs_mcdi.h
+++ b/drivers/common/sfc_efx/base/efx_regs_mcdi.h
@@ -7992,7 +7992,7 @@
 #define	MC_CMD_SENSOR_SET_LIMS_IN_SENSOR_LEN 4
 /*            Enum values, see field(s): */
 /*               MC_CMD_SENSOR_INFO/MC_CMD_SENSOR_INFO_OUT/MASK */
-/* interpretation is is sensor-specific. */
+/* interpretation is sensor-specific. */
 #define	MC_CMD_SENSOR_SET_LIMS_IN_LOW0_OFST 4
 #define	MC_CMD_SENSOR_SET_LIMS_IN_LOW0_LEN 4
 /* interpretation is is sensor-specific. */
diff --git a/lib/net/rte_ether.h b/lib/net/rte_ether.h
index bf8a55ba06ca..b35c72c7b0e0 100644
--- a/lib/net/rte_ether.h
+++ b/lib/net/rte_ether.h
@@ -350,7 +350,7 @@ static inline int rte_vlan_strip(struct rte_mbuf *m)
  *   The packet mbuf.
  * @return
  *   - 0: On success
- *   -EPERM: mbuf is is shared overwriting would be unsafe
+ *   -EPERM: mbuf is shared overwriting would be unsafe
  *   -ENOSPC: not enough headroom in mbuf
  */
 static inline int rte_vlan_insert(struct rte_mbuf **m)
-- 
2.35.1

[PATCH 03/11] mvnet,mvpp2: remove duplicate word

[Stephen Hemminger]

The word 'same' is duplicated in comment.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/mvneta/mvneta_ethdev.c | 2 +-
 drivers/net/mvpp2/mrvl_ethdev.c    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/mvneta/mvneta_ethdev.c b/drivers/net/mvneta/mvneta_ethdev.c
index eef016aa0b65..fc13b2547f31 100644
--- a/drivers/net/mvneta/mvneta_ethdev.c
+++ b/drivers/net/mvneta/mvneta_ethdev.c
@@ -350,7 +350,7 @@ mvneta_dev_start(struct rte_eth_dev *dev)
 	mvneta_stats_reset(dev);
 
 	/*
-	 * In case there are some some stale uc/mc mac addresses flush them
+	 * In case there are some stale uc/mc mac addresses flush them
 	 * here. It cannot be done during mvneta_dev_close() as port information
 	 * is already gone at that point (due to neta_ppio_deinit() in
 	 * mvneta_dev_stop()).
diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c
index 735efb6cfc06..19a4e3b8c329 100644
--- a/drivers/net/mvpp2/mrvl_ethdev.c
+++ b/drivers/net/mvpp2/mrvl_ethdev.c
@@ -858,7 +858,7 @@ mrvl_dev_start(struct rte_eth_dev *dev)
 	}
 
 	/*
-	 * In case there are some some stale uc/mc mac addresses flush them
+	 * In case there are some stale uc/mc mac addresses flush them
 	 * here. It cannot be done during mrvl_dev_close() as port information
 	 * is already gone at that point (due to pp2_ppio_deinit() in
 	 * mrvl_dev_stop()).
-- 
2.35.1

[PATCH 04/11] Remove repeated word 'on on'

[Stephen Hemminger]

Found in a couple of places.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/bonding/rte_eth_bond_8023ad.h   | 2 +-
 examples/vm_power_manager/channel_monitor.h | 2 +-
 examples/vm_power_manager/oob_monitor.h     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.h b/drivers/net/bonding/rte_eth_bond_8023ad.h
index 7eb392f8c8a1..7ad8d6d00bd5 100644
--- a/drivers/net/bonding/rte_eth_bond_8023ad.h
+++ b/drivers/net/bonding/rte_eth_bond_8023ad.h
@@ -271,7 +271,7 @@ rte_eth_bond_8023ad_ext_slowtx(uint16_t port_id, uint16_t slave_id,
 		struct rte_mbuf *lacp_pkt);
 
 /**
- * Enable dedicated hw queues for 802.3ad control plane traffic on on slaves
+ * Enable dedicated hw queues for 802.3ad control plane traffic on slaves
  *
  * This function creates an additional tx and rx queue on each slave for
  * dedicated 802.3ad control plane traffic . A flow filtering rule is
diff --git a/examples/vm_power_manager/channel_monitor.h b/examples/vm_power_manager/channel_monitor.h
index 2b38c554b5cd..ab69524af52c 100644
--- a/examples/vm_power_manager/channel_monitor.h
+++ b/examples/vm_power_manager/channel_monitor.h
@@ -41,7 +41,7 @@ extern "C" {
 int channel_monitor_init(void);
 
 /**
- * Run the channel monitor, loops forever on on epoll_wait.
+ * Run the channel monitor, loops forever on epoll_wait.
  *
  *
  * @return
diff --git a/examples/vm_power_manager/oob_monitor.h b/examples/vm_power_manager/oob_monitor.h
index b96e08df782c..2389c1151956 100644
--- a/examples/vm_power_manager/oob_monitor.h
+++ b/examples/vm_power_manager/oob_monitor.h
@@ -20,7 +20,7 @@ extern "C" {
 int branch_monitor_init(void);
 
 /**
- * Run the OOB branch monitor, loops forever on on epoll_wait.
+ * Run the OOB branch monitor, loops forever on epoll_wait.
  *
  *
  * @return
-- 
2.35.1

[PATCH 05/11] fix repeated words 'in in'

[Stephen Hemminger]

Multiple files are incorrectly using 'in in'

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/common/sfc_efx/base/efx_types.h | 2 +-
 drivers/event/sw/sw_evdev.c             | 2 +-
 drivers/net/hns3/hns3_ethdev.c          | 2 +-
 drivers/net/mlx5/mlx5_flow.c            | 2 +-
 drivers/net/sfc/sfc_ef10_tx.c           | 2 +-
 drivers/net/sfc/sfc_tso.c               | 2 +-
 lib/mbuf/rte_mbuf_core.h                | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/common/sfc_efx/base/efx_types.h b/drivers/common/sfc_efx/base/efx_types.h
index 12ae1084d83a..a6123962f976 100644
--- a/drivers/common/sfc_efx/base/efx_types.h
+++ b/drivers/common/sfc_efx/base/efx_types.h
@@ -399,7 +399,7 @@ extern int fix_lint;
  *
  *   (_element) << 4
  *
- * The result will contain the relevant bits filled in in the range
+ * The result will contain the relevant bits filled in the range
  * [0,high-low), with garbage in bits [high-low+1,...).
  */
 #define	EFX_EXTRACT_NATIVE(_element, _min, _max, _low, _high)		\
diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
index f93313b31b5c..7be9ac320963 100644
--- a/drivers/event/sw/sw_evdev.c
+++ b/drivers/event/sw/sw_evdev.c
@@ -244,7 +244,7 @@ qid_init(struct sw_evdev *sw, unsigned int idx, int type,
 	if (qid->type == RTE_SCHED_TYPE_ORDERED) {
 		uint32_t window_size;
 
-		/* rte_ring and window_size_mask require require window_size to
+		/* rte_ring and window_size_mask require window_size to
 		 * be a power-of-2.
 		 */
 		window_size = rte_align32pow2(
diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c
index 6b1d1a5fb191..29cff1946932 100644
--- a/drivers/net/hns3/hns3_ethdev.c
+++ b/drivers/net/hns3/hns3_ethdev.c
@@ -3904,7 +3904,7 @@ hns3_dev_promiscuous_enable(struct rte_eth_dev *dev)
 
 	/*
 	 * When promiscuous mode was enabled, disable the vlan filter to let
-	 * all packets coming in in the receiving direction.
+	 * all packets coming in the receiving direction.
 	 */
 	offloads = dev->data->dev_conf.rxmode.offloads;
 	if (offloads & RTE_ETH_RX_OFFLOAD_VLAN_FILTER) {
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 8c93a3f2e5ac..674dc31cadd0 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -4816,7 +4816,7 @@ flow_mreg_del_default_copy_action(struct rte_eth_dev *dev)
 }
 
 /**
- * Add the default copy action in in RX_CP_TBL.
+ * Add the default copy action in RX_CP_TBL.
  *
  * This functions is called in the mlx5_dev_start(). No thread safe
  * is guaranteed.
diff --git a/drivers/net/sfc/sfc_ef10_tx.c b/drivers/net/sfc/sfc_ef10_tx.c
index 5403a60707d1..116229382b68 100644
--- a/drivers/net/sfc/sfc_ef10_tx.c
+++ b/drivers/net/sfc/sfc_ef10_tx.c
@@ -503,7 +503,7 @@ sfc_ef10_xmit_tso_pkt(struct sfc_ef10_txq * const txq, struct rte_mbuf *m_seg,
 
 	/*
 	 * Tx prepare has debug-only checks that offload flags are correctly
-	 * filled in in TSO mbuf. Use zero IPID if there is no IPv4 flag.
+	 * filled in TSO mbuf. Use zero IPID if there is no IPv4 flag.
 	 * If the packet is still IPv4, HW will simply start from zero IPID.
 	 */
 	if (first_m_seg->ol_flags & RTE_MBUF_F_TX_IPV4)
diff --git a/drivers/net/sfc/sfc_tso.c b/drivers/net/sfc/sfc_tso.c
index 927e351a6ed4..a0827d1c0dd6 100644
--- a/drivers/net/sfc/sfc_tso.c
+++ b/drivers/net/sfc/sfc_tso.c
@@ -149,7 +149,7 @@ sfc_efx_tso_do(struct sfc_efx_txq *txq, unsigned int idx,
 
 	/*
 	 * Handle IP header. Tx prepare has debug-only checks that offload flags
-	 * are correctly filled in in TSO mbuf. Use zero IPID if there is no
+	 * are correctly filled in TSO mbuf. Use zero IPID if there is no
 	 * IPv4 flag. If the packet is still IPv4, HW will simply start from
 	 * zero IPID.
 	 */
diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h
index 3d6ddd6773d2..b1c10cccc252 100644
--- a/lib/mbuf/rte_mbuf_core.h
+++ b/lib/mbuf/rte_mbuf_core.h
@@ -42,7 +42,7 @@ extern "C" {
 
 /**
  * The RX packet is a 802.1q VLAN packet, and the tci has been
- * saved in in mbuf->vlan_tci.
+ * saved in mbuf->vlan_tci.
  * If the flag RTE_MBUF_F_RX_VLAN_STRIPPED is also present, the VLAN
  * header has been stripped from mbuf data, else it is still
  * present.
-- 
2.35.1

[PATCH 06/11] ring: fix repeated word in comment

[Stephen Hemminger]

Replace this this.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/ring/rte_ring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/ring/rte_ring.c b/lib/ring/rte_ring.c
index cddaf6b2876f..a42767b75d9c 100644
--- a/lib/ring/rte_ring.c
+++ b/lib/ring/rte_ring.c
@@ -280,7 +280,7 @@ rte_ring_create_elem(const char *name, unsigned int esize, unsigned int count,
 
 	/* reserve a memory zone for this ring. If we can't get rte_config or
 	 * we are secondary process, the memzone_reserve function will set
-	 * rte_errno for us appropriately - hence no check in this this function */
+	 * rte_errno for us appropriately - hence no check in this function */
 	mz = rte_memzone_reserve_aligned(mz_name, ring_size, socket_id,
 					 mz_flags, __alignof__(*r));
 	if (mz != NULL) {
-- 
2.35.1

[PATCH 07/11] i40e,igc: fix duplicate word than

[Stephen Hemminger]

Another obvious typo.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/i40e/i40e_fdir.c   | 2 +-
 drivers/net/igc/base/igc_mac.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c
index 8caedea14eaa..3b7714217405 100644
--- a/drivers/net/i40e/i40e_fdir.c
+++ b/drivers/net/i40e/i40e_fdir.c
@@ -377,7 +377,7 @@ i40e_init_flx_pld(struct i40e_pf *pf)
 	if ((flex_pit2).src_offset < \
 		(flex_pit1).src_offset + (flex_pit1).size) { \
 		PMD_DRV_LOG(ERR, "src_offset should be not" \
-			" less than than previous offset" \
+			" less than previous offset" \
 			" + previous FSIZE."); \
 		return -EINVAL; \
 	} \
diff --git a/drivers/net/igc/base/igc_mac.c b/drivers/net/igc/base/igc_mac.c
index 3cd6506e5e60..0822ffe7c37c 100644
--- a/drivers/net/igc/base/igc_mac.c
+++ b/drivers/net/igc/base/igc_mac.c
@@ -587,7 +587,7 @@ void igc_update_mc_addr_list_generic(struct igc_hw *hw,
  *  @hw: pointer to the HW structure
  *
  *  In certain situations, a system BIOS may report that the PCIx maximum
- *  memory read byte count (MMRBC) value is higher than than the actual
+ *  memory read byte count (MMRBC) value is higher than the actual
  *  value. We check the PCIx command register with the current PCIx status
  *  register.
  **/
-- 
2.35.1

[PATCH 08/11] bnx2x, pcap: replace only only

[Stephen Hemminger]

Duplicate word in comments.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/bnx2x/bnx2x.c      | 2 +-
 drivers/net/pcap/pcap_ethdev.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
index 74e3018eab6f..29c16bb207c7 100644
--- a/drivers/net/bnx2x/bnx2x.c
+++ b/drivers/net/bnx2x/bnx2x.c
@@ -5929,7 +5929,7 @@ static uint8_t bnx2x_trylock_hw_lock(struct bnx2x_softc *sc, uint32_t resource)
 
 /*
  * Get the recovery leader resource id according to the engine this function
- * belongs to. Currently only only 2 engines is supported.
+ * belongs to. Currently only 2 engines are supported.
  */
 static int bnx2x_get_leader_lock_resource(struct bnx2x_softc *sc)
 {
diff --git a/drivers/net/pcap/pcap_ethdev.c b/drivers/net/pcap/pcap_ethdev.c
index ec29fd6bc53c..bcb02ca0638e 100644
--- a/drivers/net/pcap/pcap_ethdev.c
+++ b/drivers/net/pcap/pcap_ethdev.c
@@ -1336,7 +1336,7 @@ eth_from_pcaps(struct rte_vdev_device *vdev,
 		internals->if_index =
 			osdep_iface_index_get(rx_queues->queue[0].name);
 
-		/* phy_mac arg is applied only only if "iface" devarg is provided */
+		/* phy_mac arg is applied only if "iface" devarg is provided */
 		if (rx_queues->phy_mac) {
 			if (eth_pcap_update_mac(rx_queues->queue[0].name,
 					eth_dev, vdev->device.numa_node) == 0)
-- 
2.35.1

[PATCH 09/11] distrubutor: fix repeated word in comment

[Stephen Hemminger]

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/distributor/rte_distributor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/distributor/rte_distributor.c b/lib/distributor/rte_distributor.c
index 3035b7a99925..967e27d35a49 100644
--- a/lib/distributor/rte_distributor.c
+++ b/lib/distributor/rte_distributor.c
@@ -575,7 +575,7 @@ rte_distributor_process(struct rte_distributor *d,
 					}
 				}
 
-				/* Add to current worker worker */
+				/* Add to current worker */
 				unsigned int idx = bl->count++;
 
 				bl->tags[idx] = new_tag;
-- 
2.35.1

[PATCH 10/11] ethdev: fix repeated word in comment

[Stephen Hemminger]

Replace 'of of'

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/ethdev/rte_ethdev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
index de9e970d4d11..701eac328fe6 100644
--- a/lib/ethdev/rte_ethdev.h
+++ b/lib/ethdev/rte_ethdev.h
@@ -3356,7 +3356,7 @@ int rte_eth_macaddrs_get(uint16_t port_id, struct rte_ether_addr *ma,
 /**
  * Retrieve the contextual information of an Ethernet device.
  *
- * As part of this function, a number of of fields in dev_info will be
+ * As part of this function, a number of fields in dev_info will be
  * initialized as follows:
  *
  * rx_desc_lim = lim
-- 
2.35.1

[PATCH 11/11] cxgbe: replace 'or or' in comment

[Stephen Hemminger]

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/cxgbe/sge.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/cxgbe/sge.c b/drivers/net/cxgbe/sge.c
index 5d91355c9ab1..1a767dabf59c 100644
--- a/drivers/net/cxgbe/sge.c
+++ b/drivers/net/cxgbe/sge.c
@@ -65,7 +65,7 @@ static inline void ship_tx_pkt_coalesce_wr(struct adapter *adap,
  * for DMA, but this is of course never sent to the hardware and is only used
  * to prevent double unmappings.  All of the above requires that the Free List
  * Buffers which we allocate have the bottom 5 bits free (0) -- i.e. are
- * 32-byte or or a power of 2 greater in alignment.  Since the SGE's minimal
+ * 32-byte or a power of 2 greater in alignment.  Since the SGE's minimal
  * Free List Buffer alignment is 32 bytes, this works out for us ...
  */
 enum {
-- 
2.35.1

RE: [EXT] [PATCH 03/11] mvnet,mvpp2: remove duplicate word

[Liron Himi]

Acked-by: Liron Himi <lironh@marvell.com>

-----Original Message-----
From: Stephen Hemminger <stephen@networkplumber.org> 
Sent: Saturday, 23 July 2022 00:41
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>; Zyta Szpak <zr@semihalf.com>; Liron Himi <lironh@marvell.com>
Subject: [EXT] [PATCH 03/11] mvnet,mvpp2: remove duplicate word

External Email

----------------------------------------------------------------------
The word 'same' is duplicated in comment.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/mvneta/mvneta_ethdev.c | 2 +-
 drivers/net/mvpp2/mrvl_ethdev.c    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/mvneta/mvneta_ethdev.c b/drivers/net/mvneta/mvneta_ethdev.c
index eef016aa0b65..fc13b2547f31 100644
--- a/drivers/net/mvneta/mvneta_ethdev.c
+++ b/drivers/net/mvneta/mvneta_ethdev.c
@@ -350,7 +350,7 @@ mvneta_dev_start(struct rte_eth_dev *dev)
 	mvneta_stats_reset(dev);
 
 	/*
-	 * In case there are some some stale uc/mc mac addresses flush them
+	 * In case there are some stale uc/mc mac addresses flush them
 	 * here. It cannot be done during mvneta_dev_close() as port information
 	 * is already gone at that point (due to neta_ppio_deinit() in
 	 * mvneta_dev_stop()).
diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c index 735efb6cfc06..19a4e3b8c329 100644
--- a/drivers/net/mvpp2/mrvl_ethdev.c
+++ b/drivers/net/mvpp2/mrvl_ethdev.c
@@ -858,7 +858,7 @@ mrvl_dev_start(struct rte_eth_dev *dev)
 	}
 
 	/*
-	 * In case there are some some stale uc/mc mac addresses flush them
+	 * In case there are some stale uc/mc mac addresses flush them
 	 * here. It cannot be done during mrvl_dev_close() as port information
 	 * is already gone at that point (due to pp2_ppio_deinit() in
 	 * mrvl_dev_stop()).
--
2.35.1

Re: [PATCH 10/11] ethdev: fix repeated word in comment

[Thomas Monjalon]

22/07/2022 23:41, Stephen Hemminger:
> Replace 'of of'
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  lib/ethdev/rte_ethdev.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
> index de9e970d4d11..701eac328fe6 100644
> --- a/lib/ethdev/rte_ethdev.h
> +++ b/lib/ethdev/rte_ethdev.h
> @@ -3356,7 +3356,7 @@ int rte_eth_macaddrs_get(uint16_t port_id, struct rte_ether_addr *ma,
>  /**
>   * Retrieve the contextual information of an Ethernet device.
>   *
> - * As part of this function, a number of of fields in dev_info will be
> + * As part of this function, a number of fields in dev_info will be
>   * initialized as follows:
>   *
>   * rx_desc_lim = lim

This comment is the code of the function.
That's very unusual and should be completely removed in my opinion,
instead of just fixing the repeated word.

Re: [PATCH 00/11] Fix repeated words in comments and messages

[Bruce Richardson]

On Fri, Jul 22, 2022 at 02:40:55PM -0700, Stephen Hemminger wrote:
> Reading netdev, noticed lots of places in Linux kernel with bad
> comments being fixed.  Use similar kind of scanning to look
> for repeated words in DPDK.
> 
> Stephen Hemminger (11):
>   remove duplicated 'to to' in messages and comments
>   remove duplicate words 'is is'
>   mvnet,mvpp2: remove duplicate word
>   Remove repeated word 'on on'
>   fix repeated words 'in in'
>   ring: fix repeated word in comment
>   i40e,igc: fix duplicate word than
>   bnx2x, pcap: replace only only
>   distrubutor: fix repeated word in comment

Typo in title

>   ethdev: fix repeated word in comment
>   cxgbe: replace 'or or' in comment
>
Nice simple cleanup. If doing a future version, perhaps have the titles and
comments consistent across patches - some of the title above are missing
the repeated word in them.

Series-acked-by: Bruce Richardson <bruce.richardson@intel.com> 

[PATCH v2 00/20] Remove repeated words in comments and messages

[Stephen Hemminger]

This is a cleanup of comments and messages. Done by an ugly
pcregrep across sources and skipping lots of false positives

The idea is based of what some maintainers have been doing in netdev.

Series-acked-by: Bruce Richardson <bruce.richardson@intel.com> 

v2
  - reword ethdev comment rather than just fix typo
  - catch more repeated words
  - make messages consistent

Stephen Hemminger (20):
  ethdev: reword dev_info_get description.
  remove repeated word 'to'
  remove repeated word 'is'
  remove repeated word 'same'
  remove repeated word 'on'
  remove repeated word 'in'
  remove repeated word 'this'
  remove repeated word 'then'
  remove repeated word 'only'
  remove repeated word 'worker'
  remove repeated word 'or'
  remove repeated word 'table'
  remove repeated word 'that'
  remove repeated word 'override'
  remove repeated word 'groups'
  remove repeated word 'page'
  remove repeated word 'individual'
  remove repeated word 'expected'
  remove repeated word 'be'
  remove repeated word 'all'

 app/test/test_ipsec.c                       |  2 +-
 app/test/test_resource.c                    |  2 +-
 drivers/common/sfc_efx/base/efx_regs_mcdi.h |  2 +-
 drivers/common/sfc_efx/base/efx_types.h     |  2 +-
 drivers/common/sfc_efx/base/siena_nvram.c   |  2 +-
 drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c |  4 +--
 drivers/event/sw/sw_evdev.c                 |  2 +-
 drivers/net/bnx2x/bnx2x.c                   |  2 +-
 drivers/net/bnx2x/ecore_fw_defs.h           |  2 +-
 drivers/net/bnx2x/ecore_sp.h                |  2 +-
 drivers/net/bonding/rte_eth_bond_8023ad.h   |  2 +-
 drivers/net/cxgbe/cxgbe_filter.h            |  2 +-
 drivers/net/cxgbe/sge.c                     |  2 +-
 drivers/net/hns3/hns3_ethdev.c              |  2 +-
 drivers/net/i40e/i40e_fdir.c                |  2 +-
 drivers/net/igc/base/igc_mac.c              |  2 +-
 drivers/net/ixgbe/ixgbe_ipsec.c             |  2 +-
 drivers/net/mlx5/mlx5_flow.c                |  2 +-
 drivers/net/mvneta/mvneta_ethdev.c          |  2 +-
 drivers/net/mvpp2/mrvl_ethdev.c             |  2 +-
 drivers/net/nfp/nfp_ctrl.h                  |  2 +-
 drivers/net/pcap/pcap_ethdev.c              |  2 +-
 drivers/net/qede/qede_filter.c              |  4 +--
 drivers/net/sfc/sfc_ef10_tx.c               |  2 +-
 drivers/net/sfc/sfc_tso.c                   |  2 +-
 examples/vm_power_manager/channel_monitor.h |  2 +-
 examples/vm_power_manager/oob_monitor.h     |  2 +-
 lib/bpf/rte_bpf_ethdev.h                    |  2 +-
 lib/distributor/rte_distributor.c           |  2 +-
 lib/ethdev/rte_ethdev.h                     | 33 ++++-----------------
 lib/mbuf/rte_mbuf_core.h                    |  2 +-
 lib/net/rte_ether.h                         |  2 +-
 lib/pipeline/rte_swx_ctl.c                  |  2 +-
 lib/power/guest_channel.c                   |  2 +-
 lib/ring/rte_ring.c                         |  2 +-
 35 files changed, 41 insertions(+), 64 deletions(-)

-- 
2.35.1

[PATCH v2 01/20] ethdev: reword dev_info_get description.

[Stephen Hemminger]

The original comment was redundant and had duplicate word 'of'.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/ethdev/rte_ethdev.h | 33 +++++----------------------------
 1 file changed, 5 insertions(+), 28 deletions(-)

diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
index de9e970d4d11..48e0814f2535 100644
--- a/lib/ethdev/rte_ethdev.h
+++ b/lib/ethdev/rte_ethdev.h
@@ -3356,34 +3356,11 @@ int rte_eth_macaddrs_get(uint16_t port_id, struct rte_ether_addr *ma,
 /**
  * Retrieve the contextual information of an Ethernet device.
  *
- * As part of this function, a number of of fields in dev_info will be
- * initialized as follows:
- *
- * rx_desc_lim = lim
- * tx_desc_lim = lim
- *
- * Where lim is defined within the rte_eth_dev_info_get as
- *
- *  const struct rte_eth_desc_lim lim = {
- *      .nb_max = UINT16_MAX,
- *      .nb_min = 0,
- *      .nb_align = 1,
- *	.nb_seg_max = UINT16_MAX,
- *	.nb_mtu_seg_max = UINT16_MAX,
- *  };
- *
- * device = dev->device
- * min_mtu = RTE_ETHER_MIN_LEN - RTE_ETHER_HDR_LEN - RTE_ETHER_CRC_LEN
- * max_mtu = UINT16_MAX
- *
- * The following fields will be populated if support for dev_infos_get()
- * exists for the device and the rte_eth_dev 'dev' has been populated
- * successfully with a call to it:
- *
- * driver_name = dev->device->driver->name
- * nb_rx_queues = dev->data->nb_rx_queues
- * nb_tx_queues = dev->data->nb_tx_queues
- * dev_flags = &dev->data->dev_flags
+ * The device information about driver, descriptors limits,
+ * capabilities, flags,  and queues is returned.
+ *
+ * The fields are populated with generic values that then are
+ * overriden by the device driver specific values.
  *
  * @param port_id
  *   The port identifier of the Ethernet device.
-- 
2.35.1

[PATCH v2 02/20] remove repeated word 'to'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 app/test/test_resource.c                  | 2 +-
 drivers/common/sfc_efx/base/siena_nvram.c | 2 +-
 lib/pipeline/rte_swx_ctl.c                | 2 +-
 lib/power/guest_channel.c                 | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/app/test/test_resource.c b/app/test/test_resource.c
index 8f41e3babdc5..05c27db203cc 100644
--- a/app/test/test_resource.c
+++ b/app/test/test_resource.c
@@ -45,7 +45,7 @@ static int test_resource_c(void)
 			r->name);
 
 	TEST_ASSERT_SUCCESS(resource_fwrite_file(r, "test_resource.c"),
-			"Failed to to write file %s", r->name);
+			"Failed to write file %s", r->name);
 
 	f = fopen("test_resource.c", "r");
 	TEST_ASSERT_NOT_NULL(f,
diff --git a/drivers/common/sfc_efx/base/siena_nvram.c b/drivers/common/sfc_efx/base/siena_nvram.c
index 05ca4bd83dc9..ebcd3487b631 100644
--- a/drivers/common/sfc_efx/base/siena_nvram.c
+++ b/drivers/common/sfc_efx/base/siena_nvram.c
@@ -532,7 +532,7 @@ siena_nvram_partn_get_version(
 			: MC_CMD_NVRAM_TYPE_DYNAMIC_CFG_PORT1;
 		/*
 		 * Ingore missing partitions on port 2, assuming they're due
-		 * to to running on a single port part.
+		 * to running on a single port part.
 		 */
 		if ((1 << dcfg_partn) &  ~enp->en_u.siena.enu_partn_mask) {
 			if (entry->port == 2)
diff --git a/lib/pipeline/rte_swx_ctl.c b/lib/pipeline/rte_swx_ctl.c
index 710e89a46a26..9b7bf5e0fb01 100644
--- a/lib/pipeline/rte_swx_ctl.c
+++ b/lib/pipeline/rte_swx_ctl.c
@@ -1582,7 +1582,7 @@ rte_swx_ctl_pipeline_table_entry_delete(struct rte_swx_ctl_pipeline *ctl,
 	CHECK(!table_entry_check(ctl, table_id, entry, 1, 0), EINVAL);
 
 	/* The entry is found in the table->entries list:
-	 * - Move the existing entry from the table->entries list to to the
+	 * - Move the existing entry from the table->entries list to the
 	 *   table->pending_delete list.
 	 */
 	existing_entry = table_entries_find(table, entry);
diff --git a/lib/power/guest_channel.c b/lib/power/guest_channel.c
index 969a9e5aaa06..7b2ae0b6506f 100644
--- a/lib/power/guest_channel.c
+++ b/lib/power/guest_channel.c
@@ -74,7 +74,7 @@ guest_channel_host_connect(const char *path, unsigned int lcore_id)
 			fd_path, lcore_id);
 	fd = open(fd_path, O_RDWR);
 	if (fd < 0) {
-		RTE_LOG(ERR, GUEST_CHANNEL, "Unable to to connect to '%s' with error "
+		RTE_LOG(ERR, GUEST_CHANNEL, "Unable to connect to '%s' with error "
 				"%s\n", fd_path, strerror(errno));
 		return -1;
 	}
-- 
2.35.1

[PATCH v2 03/20] remove repeated word 'is'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/common/sfc_efx/base/efx_regs_mcdi.h | 2 +-
 lib/net/rte_ether.h                         | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/common/sfc_efx/base/efx_regs_mcdi.h b/drivers/common/sfc_efx/base/efx_regs_mcdi.h
index 2daf825a366e..f3ec456864f6 100644
--- a/drivers/common/sfc_efx/base/efx_regs_mcdi.h
+++ b/drivers/common/sfc_efx/base/efx_regs_mcdi.h
@@ -7992,7 +7992,7 @@
 #define	MC_CMD_SENSOR_SET_LIMS_IN_SENSOR_LEN 4
 /*            Enum values, see field(s): */
 /*               MC_CMD_SENSOR_INFO/MC_CMD_SENSOR_INFO_OUT/MASK */
-/* interpretation is is sensor-specific. */
+/* interpretation is sensor-specific. */
 #define	MC_CMD_SENSOR_SET_LIMS_IN_LOW0_OFST 4
 #define	MC_CMD_SENSOR_SET_LIMS_IN_LOW0_LEN 4
 /* interpretation is is sensor-specific. */
diff --git a/lib/net/rte_ether.h b/lib/net/rte_ether.h
index bf8a55ba06ca..b35c72c7b0e0 100644
--- a/lib/net/rte_ether.h
+++ b/lib/net/rte_ether.h
@@ -350,7 +350,7 @@ static inline int rte_vlan_strip(struct rte_mbuf *m)
  *   The packet mbuf.
  * @return
  *   - 0: On success
- *   -EPERM: mbuf is is shared overwriting would be unsafe
+ *   -EPERM: mbuf is shared overwriting would be unsafe
  *   -ENOSPC: not enough headroom in mbuf
  */
 static inline int rte_vlan_insert(struct rte_mbuf **m)
-- 
2.35.1

[PATCH v2 04/20] remove repeated word 'same'

[Stephen Hemminger]

The word 'same' is duplicated in comment.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Liron Himi <lironh@marvell.com>
---
 drivers/net/mvneta/mvneta_ethdev.c | 2 +-
 drivers/net/mvpp2/mrvl_ethdev.c    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/mvneta/mvneta_ethdev.c b/drivers/net/mvneta/mvneta_ethdev.c
index eef016aa0b65..fc13b2547f31 100644
--- a/drivers/net/mvneta/mvneta_ethdev.c
+++ b/drivers/net/mvneta/mvneta_ethdev.c
@@ -350,7 +350,7 @@ mvneta_dev_start(struct rte_eth_dev *dev)
 	mvneta_stats_reset(dev);
 
 	/*
-	 * In case there are some some stale uc/mc mac addresses flush them
+	 * In case there are some stale uc/mc mac addresses flush them
 	 * here. It cannot be done during mvneta_dev_close() as port information
 	 * is already gone at that point (due to neta_ppio_deinit() in
 	 * mvneta_dev_stop()).
diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c
index 735efb6cfc06..19a4e3b8c329 100644
--- a/drivers/net/mvpp2/mrvl_ethdev.c
+++ b/drivers/net/mvpp2/mrvl_ethdev.c
@@ -858,7 +858,7 @@ mrvl_dev_start(struct rte_eth_dev *dev)
 	}
 
 	/*
-	 * In case there are some some stale uc/mc mac addresses flush them
+	 * In case there are some stale uc/mc mac addresses flush them
 	 * here. It cannot be done during mrvl_dev_close() as port information
 	 * is already gone at that point (due to pp2_ppio_deinit() in
 	 * mrvl_dev_stop()).
-- 
2.35.1

[PATCH v2 05/20] remove repeated word 'on'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/bonding/rte_eth_bond_8023ad.h   | 2 +-
 examples/vm_power_manager/channel_monitor.h | 2 +-
 examples/vm_power_manager/oob_monitor.h     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.h b/drivers/net/bonding/rte_eth_bond_8023ad.h
index 7eb392f8c8a1..7ad8d6d00bd5 100644
--- a/drivers/net/bonding/rte_eth_bond_8023ad.h
+++ b/drivers/net/bonding/rte_eth_bond_8023ad.h
@@ -271,7 +271,7 @@ rte_eth_bond_8023ad_ext_slowtx(uint16_t port_id, uint16_t slave_id,
 		struct rte_mbuf *lacp_pkt);
 
 /**
- * Enable dedicated hw queues for 802.3ad control plane traffic on on slaves
+ * Enable dedicated hw queues for 802.3ad control plane traffic on slaves
  *
  * This function creates an additional tx and rx queue on each slave for
  * dedicated 802.3ad control plane traffic . A flow filtering rule is
diff --git a/examples/vm_power_manager/channel_monitor.h b/examples/vm_power_manager/channel_monitor.h
index 2b38c554b5cd..ab69524af52c 100644
--- a/examples/vm_power_manager/channel_monitor.h
+++ b/examples/vm_power_manager/channel_monitor.h
@@ -41,7 +41,7 @@ extern "C" {
 int channel_monitor_init(void);
 
 /**
- * Run the channel monitor, loops forever on on epoll_wait.
+ * Run the channel monitor, loops forever on epoll_wait.
  *
  *
  * @return
diff --git a/examples/vm_power_manager/oob_monitor.h b/examples/vm_power_manager/oob_monitor.h
index b96e08df782c..2389c1151956 100644
--- a/examples/vm_power_manager/oob_monitor.h
+++ b/examples/vm_power_manager/oob_monitor.h
@@ -20,7 +20,7 @@ extern "C" {
 int branch_monitor_init(void);
 
 /**
- * Run the OOB branch monitor, loops forever on on epoll_wait.
+ * Run the OOB branch monitor, loops forever on epoll_wait.
  *
  *
  * @return
-- 
2.35.1

[PATCH v2 06/20] remove repeated word 'in'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/common/sfc_efx/base/efx_types.h | 2 +-
 drivers/event/sw/sw_evdev.c             | 2 +-
 drivers/net/hns3/hns3_ethdev.c          | 2 +-
 drivers/net/mlx5/mlx5_flow.c            | 2 +-
 drivers/net/sfc/sfc_ef10_tx.c           | 2 +-
 drivers/net/sfc/sfc_tso.c               | 2 +-
 lib/mbuf/rte_mbuf_core.h                | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/common/sfc_efx/base/efx_types.h b/drivers/common/sfc_efx/base/efx_types.h
index 12ae1084d83a..a6123962f976 100644
--- a/drivers/common/sfc_efx/base/efx_types.h
+++ b/drivers/common/sfc_efx/base/efx_types.h
@@ -399,7 +399,7 @@ extern int fix_lint;
  *
  *   (_element) << 4
  *
- * The result will contain the relevant bits filled in in the range
+ * The result will contain the relevant bits filled in the range
  * [0,high-low), with garbage in bits [high-low+1,...).
  */
 #define	EFX_EXTRACT_NATIVE(_element, _min, _max, _low, _high)		\
diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
index f93313b31b5c..7be9ac320963 100644
--- a/drivers/event/sw/sw_evdev.c
+++ b/drivers/event/sw/sw_evdev.c
@@ -244,7 +244,7 @@ qid_init(struct sw_evdev *sw, unsigned int idx, int type,
 	if (qid->type == RTE_SCHED_TYPE_ORDERED) {
 		uint32_t window_size;
 
-		/* rte_ring and window_size_mask require require window_size to
+		/* rte_ring and window_size_mask require window_size to
 		 * be a power-of-2.
 		 */
 		window_size = rte_align32pow2(
diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c
index 6b1d1a5fb191..29cff1946932 100644
--- a/drivers/net/hns3/hns3_ethdev.c
+++ b/drivers/net/hns3/hns3_ethdev.c
@@ -3904,7 +3904,7 @@ hns3_dev_promiscuous_enable(struct rte_eth_dev *dev)
 
 	/*
 	 * When promiscuous mode was enabled, disable the vlan filter to let
-	 * all packets coming in in the receiving direction.
+	 * all packets coming in the receiving direction.
 	 */
 	offloads = dev->data->dev_conf.rxmode.offloads;
 	if (offloads & RTE_ETH_RX_OFFLOAD_VLAN_FILTER) {
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 8c93a3f2e5ac..674dc31cadd0 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -4816,7 +4816,7 @@ flow_mreg_del_default_copy_action(struct rte_eth_dev *dev)
 }
 
 /**
- * Add the default copy action in in RX_CP_TBL.
+ * Add the default copy action in RX_CP_TBL.
  *
  * This functions is called in the mlx5_dev_start(). No thread safe
  * is guaranteed.
diff --git a/drivers/net/sfc/sfc_ef10_tx.c b/drivers/net/sfc/sfc_ef10_tx.c
index 5403a60707d1..116229382b68 100644
--- a/drivers/net/sfc/sfc_ef10_tx.c
+++ b/drivers/net/sfc/sfc_ef10_tx.c
@@ -503,7 +503,7 @@ sfc_ef10_xmit_tso_pkt(struct sfc_ef10_txq * const txq, struct rte_mbuf *m_seg,
 
 	/*
 	 * Tx prepare has debug-only checks that offload flags are correctly
-	 * filled in in TSO mbuf. Use zero IPID if there is no IPv4 flag.
+	 * filled in TSO mbuf. Use zero IPID if there is no IPv4 flag.
 	 * If the packet is still IPv4, HW will simply start from zero IPID.
 	 */
 	if (first_m_seg->ol_flags & RTE_MBUF_F_TX_IPV4)
diff --git a/drivers/net/sfc/sfc_tso.c b/drivers/net/sfc/sfc_tso.c
index 927e351a6ed4..a0827d1c0dd6 100644
--- a/drivers/net/sfc/sfc_tso.c
+++ b/drivers/net/sfc/sfc_tso.c
@@ -149,7 +149,7 @@ sfc_efx_tso_do(struct sfc_efx_txq *txq, unsigned int idx,
 
 	/*
 	 * Handle IP header. Tx prepare has debug-only checks that offload flags
-	 * are correctly filled in in TSO mbuf. Use zero IPID if there is no
+	 * are correctly filled in TSO mbuf. Use zero IPID if there is no
 	 * IPv4 flag. If the packet is still IPv4, HW will simply start from
 	 * zero IPID.
 	 */
diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h
index 3d6ddd6773d2..b1c10cccc252 100644
--- a/lib/mbuf/rte_mbuf_core.h
+++ b/lib/mbuf/rte_mbuf_core.h
@@ -42,7 +42,7 @@ extern "C" {
 
 /**
  * The RX packet is a 802.1q VLAN packet, and the tci has been
- * saved in in mbuf->vlan_tci.
+ * saved in mbuf->vlan_tci.
  * If the flag RTE_MBUF_F_RX_VLAN_STRIPPED is also present, the VLAN
  * header has been stripped from mbuf data, else it is still
  * present.
-- 
2.35.1

[PATCH v2 07/20] remove repeated word 'this'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/ring/rte_ring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/ring/rte_ring.c b/lib/ring/rte_ring.c
index cddaf6b2876f..a42767b75d9c 100644
--- a/lib/ring/rte_ring.c
+++ b/lib/ring/rte_ring.c
@@ -280,7 +280,7 @@ rte_ring_create_elem(const char *name, unsigned int esize, unsigned int count,
 
 	/* reserve a memory zone for this ring. If we can't get rte_config or
 	 * we are secondary process, the memzone_reserve function will set
-	 * rte_errno for us appropriately - hence no check in this this function */
+	 * rte_errno for us appropriately - hence no check in this function */
 	mz = rte_memzone_reserve_aligned(mz_name, ring_size, socket_id,
 					 mz_flags, __alignof__(*r));
 	if (mz != NULL) {
-- 
2.35.1

[PATCH v2 08/20] remove repeated word 'then'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/i40e/i40e_fdir.c   | 2 +-
 drivers/net/igc/base/igc_mac.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c
index 8caedea14eaa..3b7714217405 100644
--- a/drivers/net/i40e/i40e_fdir.c
+++ b/drivers/net/i40e/i40e_fdir.c
@@ -377,7 +377,7 @@ i40e_init_flx_pld(struct i40e_pf *pf)
 	if ((flex_pit2).src_offset < \
 		(flex_pit1).src_offset + (flex_pit1).size) { \
 		PMD_DRV_LOG(ERR, "src_offset should be not" \
-			" less than than previous offset" \
+			" less than previous offset" \
 			" + previous FSIZE."); \
 		return -EINVAL; \
 	} \
diff --git a/drivers/net/igc/base/igc_mac.c b/drivers/net/igc/base/igc_mac.c
index 3cd6506e5e60..0822ffe7c37c 100644
--- a/drivers/net/igc/base/igc_mac.c
+++ b/drivers/net/igc/base/igc_mac.c
@@ -587,7 +587,7 @@ void igc_update_mc_addr_list_generic(struct igc_hw *hw,
  *  @hw: pointer to the HW structure
  *
  *  In certain situations, a system BIOS may report that the PCIx maximum
- *  memory read byte count (MMRBC) value is higher than than the actual
+ *  memory read byte count (MMRBC) value is higher than the actual
  *  value. We check the PCIx command register with the current PCIx status
  *  register.
  **/
-- 
2.35.1

[PATCH v2 09/20] remove repeated word 'only'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/bnx2x/bnx2x.c      | 2 +-
 drivers/net/pcap/pcap_ethdev.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
index 74e3018eab6f..29c16bb207c7 100644
--- a/drivers/net/bnx2x/bnx2x.c
+++ b/drivers/net/bnx2x/bnx2x.c
@@ -5929,7 +5929,7 @@ static uint8_t bnx2x_trylock_hw_lock(struct bnx2x_softc *sc, uint32_t resource)
 
 /*
  * Get the recovery leader resource id according to the engine this function
- * belongs to. Currently only only 2 engines is supported.
+ * belongs to. Currently only 2 engines are supported.
  */
 static int bnx2x_get_leader_lock_resource(struct bnx2x_softc *sc)
 {
diff --git a/drivers/net/pcap/pcap_ethdev.c b/drivers/net/pcap/pcap_ethdev.c
index ec29fd6bc53c..bcb02ca0638e 100644
--- a/drivers/net/pcap/pcap_ethdev.c
+++ b/drivers/net/pcap/pcap_ethdev.c
@@ -1336,7 +1336,7 @@ eth_from_pcaps(struct rte_vdev_device *vdev,
 		internals->if_index =
 			osdep_iface_index_get(rx_queues->queue[0].name);
 
-		/* phy_mac arg is applied only only if "iface" devarg is provided */
+		/* phy_mac arg is applied only if "iface" devarg is provided */
 		if (rx_queues->phy_mac) {
 			if (eth_pcap_update_mac(rx_queues->queue[0].name,
 					eth_dev, vdev->device.numa_node) == 0)
-- 
2.35.1

[PATCH v2 10/20] remove repeated word 'worker'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/distributor/rte_distributor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/distributor/rte_distributor.c b/lib/distributor/rte_distributor.c
index 3035b7a99925..967e27d35a49 100644
--- a/lib/distributor/rte_distributor.c
+++ b/lib/distributor/rte_distributor.c
@@ -575,7 +575,7 @@ rte_distributor_process(struct rte_distributor *d,
 					}
 				}
 
-				/* Add to current worker worker */
+				/* Add to current worker */
 				unsigned int idx = bl->count++;
 
 				bl->tags[idx] = new_tag;
-- 
2.35.1

[PATCH v2 11/20] remove repeated word 'or'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/cxgbe/sge.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/cxgbe/sge.c b/drivers/net/cxgbe/sge.c
index 5d91355c9ab1..1a767dabf59c 100644
--- a/drivers/net/cxgbe/sge.c
+++ b/drivers/net/cxgbe/sge.c
@@ -65,7 +65,7 @@ static inline void ship_tx_pkt_coalesce_wr(struct adapter *adap,
  * for DMA, but this is of course never sent to the hardware and is only used
  * to prevent double unmappings.  All of the above requires that the Free List
  * Buffers which we allocate have the bottom 5 bits free (0) -- i.e. are
- * 32-byte or or a power of 2 greater in alignment.  Since the SGE's minimal
+ * 32-byte or a power of 2 greater in alignment.  Since the SGE's minimal
  * Free List Buffer alignment is 32 bytes, this works out for us ...
  */
 enum {
-- 
2.35.1

[PATCH v2 12/20] remove repeated word 'table'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/ixgbe/ixgbe_ipsec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ixgbe/ixgbe_ipsec.c b/drivers/net/ixgbe/ixgbe_ipsec.c
index c353ae33b4f8..3d479011bea1 100644
--- a/drivers/net/ixgbe/ixgbe_ipsec.c
+++ b/drivers/net/ixgbe/ixgbe_ipsec.c
@@ -310,7 +310,7 @@ ixgbe_crypto_remove_sa(struct rte_eth_dev *dev,
 			return -1;
 		}
 
-		/* Disable and clear Rx SPI and key table table entries*/
+		/* Disable and clear Rx SPI and key table entries*/
 		reg_val = IPSRXIDX_WRITE | IPSRXIDX_TABLE_SPI | (sa_index << 3);
 		IXGBE_WRITE_REG(hw, IXGBE_IPSRXSPI, 0);
 		IXGBE_WRITE_REG(hw, IXGBE_IPSRXIPIDX, 0);
-- 
2.35.1

[PATCH v2 13/20] remove repeated word 'that'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/nfp/nfp_ctrl.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/nfp/nfp_ctrl.h b/drivers/net/nfp/nfp_ctrl.h
index 372d53746243..2327d4eb7646 100644
--- a/drivers/net/nfp/nfp_ctrl.h
+++ b/drivers/net/nfp/nfp_ctrl.h
@@ -182,7 +182,7 @@
  * Reuse spare address to contain the offset from the start of
  * the host buffer where the first byte of the received frame
  * will land.  Any metadata will come prior to that offset.  If the
- * value in this field is 0, it means that that the metadata will
+ * value in this field is 0, it means that the metadata will
  * always land starting at the first byte of the host buffer and
  * packet data will immediately follow the metadata.  As always,
  * the RX descriptor indicates the presence or absence of metadata
-- 
2.35.1

[PATCH v2 14/20] remove repeated word 'override'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
index 8444f1a7950d..0721fdd3f0d7 100644
--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
@@ -191,7 +191,7 @@ build_proto_compound_sg_fd(dpaa2_sec_session *sess,
 	if (sess->ctxt_type == DPAA2_SEC_PDCP && sess->pdcp.hfn_ovd) {
 		uint32_t hfn_ovd = *(uint32_t *)((uint8_t *)op +
 					sess->pdcp.hfn_ovd_offset);
-		/*enable HFN override override */
+		/* enable HFN override */
 		DPAA2_SET_FLE_INTERNAL_JD(ip_fle, hfn_ovd);
 		DPAA2_SET_FLE_INTERNAL_JD(op_fle, hfn_ovd);
 		DPAA2_SET_FD_INTERNAL_JD(fd, hfn_ovd);
@@ -267,7 +267,7 @@ build_proto_compound_fd(dpaa2_sec_session *sess,
 	if (sess->ctxt_type == DPAA2_SEC_PDCP && sess->pdcp.hfn_ovd) {
 		uint32_t hfn_ovd = *(uint32_t *)((uint8_t *)op +
 					sess->pdcp.hfn_ovd_offset);
-		/*enable HFN override override */
+		/* enable HFN override */
 		DPAA2_SET_FLE_INTERNAL_JD(ip_fle, hfn_ovd);
 		DPAA2_SET_FLE_INTERNAL_JD(op_fle, hfn_ovd);
 		DPAA2_SET_FD_INTERNAL_JD(fd, hfn_ovd);
-- 
2.35.1

[PATCH v2 15/20] remove repeated word 'groups'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 app/test/test_ipsec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test/test_ipsec.c b/app/test/test_ipsec.c
index 7047e1796091..8d208c526a49 100644
--- a/app/test/test_ipsec.c
+++ b/app/test/test_ipsec.c
@@ -968,7 +968,7 @@ crypto_ipsec_4grp(uint32_t pkt_num)
 {
 	uint32_t sa_ind;
 
-	/* group packets in 4 different size groups groups, 2 per SA */
+	/* group packets in 4 different size groups, 2 per SA */
 	if (pkt_num < PKT_4)
 		sa_ind = 0;
 	else if (pkt_num < PKT_12)
-- 
2.35.1

[PATCH v2 16/20] remove repeated word 'page'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/bnx2x/ecore_fw_defs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bnx2x/ecore_fw_defs.h b/drivers/net/bnx2x/ecore_fw_defs.h
index 6fc1fce7e29c..ab1abf6b34b3 100644
--- a/drivers/net/bnx2x/ecore_fw_defs.h
+++ b/drivers/net/bnx2x/ecore_fw_defs.h
@@ -341,7 +341,7 @@
 #define TOE_STATE (TOE_CONNECTION_TYPE << PROTOCOL_STATE_BIT_OFFSET)
 #define RDMA_STATE (RDMA_CONNECTION_TYPE << PROTOCOL_STATE_BIT_OFFSET)
 
-/* microcode fixed page page size 4K (chains and ring segments) */
+/* microcode fixed page size 4K (chains and ring segments) */
 #define MC_PAGE_SIZE 4096
 
 /* Number of indices per slow-path SB */
-- 
2.35.1

[PATCH v2 17/20] remove repeated word 'individual'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/cxgbe/cxgbe_filter.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/cxgbe/cxgbe_filter.h b/drivers/net/cxgbe/cxgbe_filter.h
index 46ebf833381e..6e099a5c1cfc 100644
--- a/drivers/net/cxgbe/cxgbe_filter.h
+++ b/drivers/net/cxgbe/cxgbe_filter.h
@@ -28,7 +28,7 @@
  * (value, mask) tuples.  The associated ingress packet field matches the
  * tuple when ((field & mask) == value).  (Thus a wildcard "don't care" field
  * rule can be constructed by specifying a tuple of (0, 0).)  A filter rule
- * matches an ingress packet when all of the individual individual field
+ * matches an ingress packet when all of the individual field
  * matching rules are true.
  *
  * Partial field masks are always valid, however, while it may be easy to
-- 
2.35.1

[PATCH v2 18/20] remove repeated word 'expected'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/bpf/rte_bpf_ethdev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/bpf/rte_bpf_ethdev.h b/lib/bpf/rte_bpf_ethdev.h
index 135062c9e13c..1cca2e6c95a2 100644
--- a/lib/bpf/rte_bpf_ethdev.h
+++ b/lib/bpf/rte_bpf_ethdev.h
@@ -99,7 +99,7 @@ rte_bpf_eth_rx_elf_load(uint16_t port, uint16_t queue,
  * @param prm
  *  Parameters used to create and initialise the BPF execution context.
  * @param flags
- *  Flags that define expected expected behavior of the loaded filter
+ *  Flags that define expected behavior of the loaded filter
  *  (i.e. jited/non-jited version to use).
  * @return
  *   Zero on successful completion or negative error code otherwise.
-- 
2.35.1

[PATCH v2 19/20] remove repeated word 'be'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/qede/qede_filter.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/qede/qede_filter.c b/drivers/net/qede/qede_filter.c
index ca3165d97210..24035b64e7a1 100644
--- a/drivers/net/qede/qede_filter.c
+++ b/drivers/net/qede/qede_filter.c
@@ -560,7 +560,7 @@ qede_udp_dst_port_del(struct rte_eth_dev *eth_dev,
 
 		qdev->vxlan.udp_port = udp_port;
 		/* If the request is to delete UDP port and if the number of
-		 * VXLAN filters have reached 0 then VxLAN offload can be be
+		 * VXLAN filters have reached 0 then VxLAN offload can be
 		 * disabled.
 		 */
 		if (qdev->vxlan.enable && qdev->vxlan.num_filters == 0)
@@ -589,7 +589,7 @@ qede_udp_dst_port_del(struct rte_eth_dev *eth_dev,
 
 		qdev->vxlan.udp_port = udp_port;
 		/* If the request is to delete UDP port and if the number of
-		 * GENEVE filters have reached 0 then GENEVE offload can be be
+		 * GENEVE filters have reached 0 then GENEVE offload can be
 		 * disabled.
 		 */
 		if (qdev->geneve.enable && qdev->geneve.num_filters == 0)
-- 
2.35.1

[PATCH v2 20/20] remove repeated word 'all'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/bnx2x/ecore_sp.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bnx2x/ecore_sp.h b/drivers/net/bnx2x/ecore_sp.h
index 1f4d5a3ebe29..c0b4d431c879 100644
--- a/drivers/net/bnx2x/ecore_sp.h
+++ b/drivers/net/bnx2x/ecore_sp.h
@@ -787,7 +787,7 @@ struct ecore_vlan_mac_obj {
 	/**
 	*  Delete all configured elements having the given
 	*  vlan_mac_flags specification. Assumes no pending for
-	*  execution commands. Will schedule all all currently
+	*  execution commands. Will schedule all currently
 	*  configured MACs/VLANs/VLAN-MACs matching the vlan_mac_flags
 	*  specification for deletion and will use the given
 	*  ramrod_flags for the last DEL operation.
-- 
2.35.1

Re: [PATCH v2 13/20] remove repeated word 'that'

[Niklas Soderlund]

Hi Stephen,

Thanks for your work.

On 2022-07-25 20:34:56 -0700, Stephen Hemminger wrote:
> Found by doing duplicate word scan.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>

> ---
>  drivers/net/nfp/nfp_ctrl.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/nfp/nfp_ctrl.h b/drivers/net/nfp/nfp_ctrl.h
> index 372d53746243..2327d4eb7646 100644
> --- a/drivers/net/nfp/nfp_ctrl.h
> +++ b/drivers/net/nfp/nfp_ctrl.h
> @@ -182,7 +182,7 @@
>   * Reuse spare address to contain the offset from the start of
>   * the host buffer where the first byte of the received frame
>   * will land.  Any metadata will come prior to that offset.  If the
> - * value in this field is 0, it means that that the metadata will
> + * value in this field is 0, it means that the metadata will
>   * always land starting at the first byte of the host buffer and
>   * packet data will immediately follow the metadata.  As always,
>   * the RX descriptor indicates the presence or absence of metadata
> -- 
> 2.35.1
> 

-- 
Kind Regards,
Niklas Söderlund

RE: [EXT] [PATCH v2 19/20] remove repeated word 'be'

[Devendra Singh Rawat]

> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Tuesday, July 26, 2022 9:05 AM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; Rasesh Mody
> <rmody@marvell.com>; Devendra Singh Rawat <dsinghrawat@marvell.com>
> Subject: [EXT] [PATCH v2 19/20] remove repeated word 'be'
> 
> External Email
> 
> ----------------------------------------------------------------------
> Found by doing duplicate word scan.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  drivers/net/qede/qede_filter.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/qede/qede_filter.c b/drivers/net/qede/qede_filter.c
> index ca3165d97210..24035b64e7a1 100644
> --- a/drivers/net/qede/qede_filter.c
> +++ b/drivers/net/qede/qede_filter.c
> @@ -560,7 +560,7 @@ qede_udp_dst_port_del(struct rte_eth_dev *eth_dev,
> 
>  		qdev->vxlan.udp_port = udp_port;
>  		/* If the request is to delete UDP port and if the number of
> -		 * VXLAN filters have reached 0 then VxLAN offload can be be
> +		 * VXLAN filters have reached 0 then VxLAN offload can be
>  		 * disabled.
>  		 */
>  		if (qdev->vxlan.enable && qdev->vxlan.num_filters == 0)
> @@ -589,7 +589,7 @@ qede_udp_dst_port_del(struct rte_eth_dev *eth_dev,
> 
>  		qdev->vxlan.udp_port = udp_port;
>  		/* If the request is to delete UDP port and if the number of
> -		 * GENEVE filters have reached 0 then GENEVE offload can be
> be
> +		 * GENEVE filters have reached 0 then GENEVE offload can be
>  		 * disabled.
>  		 */
>  		if (qdev->geneve.enable && qdev->geneve.num_filters == 0)
> --
> 2.35.1

Acked-by: Devendra Singh Rawat <dsinghrawat@marvell.com>

Thanks

RE: [EXT] [PATCH v2 09/20] remove repeated word 'only'

[Rasesh Mody]

> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Tuesday, July 26, 2022 9:05 AM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; Rasesh Mody
> <rmody@marvell.com>; Shahed Shaikh <shshaikh@marvell.com>
> Subject: [EXT] [PATCH v2 09/20] remove repeated word 'only'
> 
> Found by doing duplicate word scan.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Acked-by: Rasesh Mody <rmody@marvell.com>

Thanks!
-Rasesh
> ---
>  drivers/net/bnx2x/bnx2x.c      | 2 +-
>  drivers/net/pcap/pcap_ethdev.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index
> 74e3018eab6f..29c16bb207c7 100644
> --- a/drivers/net/bnx2x/bnx2x.c
> +++ b/drivers/net/bnx2x/bnx2x.c
> @@ -5929,7 +5929,7 @@ static uint8_t bnx2x_trylock_hw_lock(struct
> bnx2x_softc *sc, uint32_t resource)
> 
>  /*
>   * Get the recovery leader resource id according to the engine this function
> - * belongs to. Currently only only 2 engines is supported.
> + * belongs to. Currently only 2 engines are supported.
>   */
>  static int bnx2x_get_leader_lock_resource(struct bnx2x_softc *sc)  { diff --
> git a/drivers/net/pcap/pcap_ethdev.c b/drivers/net/pcap/pcap_ethdev.c
> index ec29fd6bc53c..bcb02ca0638e 100644
> --- a/drivers/net/pcap/pcap_ethdev.c
> +++ b/drivers/net/pcap/pcap_ethdev.c
> @@ -1336,7 +1336,7 @@ eth_from_pcaps(struct rte_vdev_device *vdev,
>  		internals->if_index =
>  			osdep_iface_index_get(rx_queues-
> >queue[0].name);
> 
> -		/* phy_mac arg is applied only only if "iface" devarg is
> provided */
> +		/* phy_mac arg is applied only if "iface" devarg is provided */
>  		if (rx_queues->phy_mac) {
>  			if (eth_pcap_update_mac(rx_queues-
> >queue[0].name,
>  					eth_dev, vdev->device.numa_node)
> == 0)
> --
> 2.35.1

RE: [EXT] [PATCH v2 19/20] remove repeated word 'be'

[Rasesh Mody]

> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Tuesday, July 26, 2022 9:05 AM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; Rasesh Mody
> <rmody@marvell.com>; Devendra Singh Rawat <dsinghrawat@marvell.com>
> Subject: [EXT] [PATCH v2 19/20] remove repeated word 'be'
> 
> Found by doing duplicate word scan.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Acked-by: Rasesh Mody <rmody@marvell.com>

Thanks!
-Rasesh
> ---
>  drivers/net/qede/qede_filter.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/qede/qede_filter.c b/drivers/net/qede/qede_filter.c
> index ca3165d97210..24035b64e7a1 100644
> --- a/drivers/net/qede/qede_filter.c
> +++ b/drivers/net/qede/qede_filter.c
> @@ -560,7 +560,7 @@ qede_udp_dst_port_del(struct rte_eth_dev
> *eth_dev,
> 
>  		qdev->vxlan.udp_port = udp_port;
>  		/* If the request is to delete UDP port and if the number of
> -		 * VXLAN filters have reached 0 then VxLAN offload can be
> be
> +		 * VXLAN filters have reached 0 then VxLAN offload can be
>  		 * disabled.
>  		 */
>  		if (qdev->vxlan.enable && qdev->vxlan.num_filters == 0)
> @@ -589,7 +589,7 @@ qede_udp_dst_port_del(struct rte_eth_dev
> *eth_dev,
> 
>  		qdev->vxlan.udp_port = udp_port;
>  		/* If the request is to delete UDP port and if the number of
> -		 * GENEVE filters have reached 0 then GENEVE offload can be
> be
> +		 * GENEVE filters have reached 0 then GENEVE offload can be
>  		 * disabled.
>  		 */
>  		if (qdev->geneve.enable && qdev->geneve.num_filters ==
> 0)
> --
> 2.35.1

[PATCH v3 00/20] Remove repeated words in comments and messages

[Stephen Hemminger]

This is a cleanup of comments and messages. Done by an ugly
pcregrep across sources and skipping lots of false positives

The idea is based of what some maintainers have been doing in netdev.

Series-acked-by: Bruce Richardson <bruce.richardson@intel.com> 

v3
  - fix some small checkpatch complaints

v2
  - reword ethdev comment rather than just fix typo
  - catch more repeated words
  - make messages consistent


Stephen Hemminger (20):
  ethdev: reword dev_info_get description.
  remove repeated word 'to'
  remove repeated word 'is'
  remove repeated word 'same'
  remove repeated word 'on'
  remove repeated word 'in'
  remove repeated word 'this'
  remove repeated word 'then'
  remove repeated word 'only'
  remove repeated word 'worker'
  remove repeated word 'or'
  remove repeated word 'table'
  remove repeated word 'that'
  remove repeated word 'override'
  remove repeated word 'groups'
  remove repeated word 'page'
  remove repeated word 'individual'
  remove repeated word 'expected'
  remove repeated word 'be'
  remove repeated word 'all'

 app/test/test_ipsec.c                       |  2 +-
 app/test/test_resource.c                    |  2 +-
 drivers/common/sfc_efx/base/efx_regs_mcdi.h |  2 +-
 drivers/common/sfc_efx/base/efx_types.h     |  2 +-
 drivers/common/sfc_efx/base/siena_nvram.c   |  2 +-
 drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c |  4 +--
 drivers/event/sw/sw_evdev.c                 |  2 +-
 drivers/net/bnx2x/bnx2x.c                   |  2 +-
 drivers/net/bnx2x/ecore_fw_defs.h           |  2 +-
 drivers/net/bnx2x/ecore_sp.h                |  2 +-
 drivers/net/bonding/rte_eth_bond_8023ad.h   |  2 +-
 drivers/net/cxgbe/cxgbe_filter.h            |  2 +-
 drivers/net/cxgbe/sge.c                     |  2 +-
 drivers/net/hns3/hns3_ethdev.c              |  2 +-
 drivers/net/i40e/i40e_fdir.c                |  2 +-
 drivers/net/igc/base/igc_mac.c              |  2 +-
 drivers/net/ixgbe/ixgbe_ipsec.c             |  2 +-
 drivers/net/mlx5/mlx5_flow.c                |  2 +-
 drivers/net/mvneta/mvneta_ethdev.c          |  2 +-
 drivers/net/mvpp2/mrvl_ethdev.c             |  2 +-
 drivers/net/nfp/nfp_ctrl.h                  |  2 +-
 drivers/net/pcap/pcap_ethdev.c              |  2 +-
 drivers/net/qede/qede_filter.c              |  4 +--
 drivers/net/sfc/sfc_ef10_tx.c               |  2 +-
 drivers/net/sfc/sfc_tso.c                   |  2 +-
 examples/vm_power_manager/channel_monitor.h |  2 +-
 examples/vm_power_manager/oob_monitor.h     |  2 +-
 lib/bpf/rte_bpf_ethdev.h                    |  2 +-
 lib/distributor/rte_distributor.c           |  2 +-
 lib/ethdev/rte_ethdev.h                     | 33 ++++-----------------
 lib/mbuf/rte_mbuf_core.h                    |  2 +-
 lib/net/rte_ether.h                         |  2 +-
 lib/pipeline/rte_swx_ctl.c                  |  2 +-
 lib/power/guest_channel.c                   |  2 +-
 lib/ring/rte_ring.c                         |  3 +-
 35 files changed, 42 insertions(+), 64 deletions(-)

-- 
2.35.1

[PATCH v3 01/20] ethdev: reword dev_info_get description.

[Stephen Hemminger]

The original comment was redundant and had duplicate word 'of'.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/ethdev/rte_ethdev.h | 33 +++++----------------------------
 1 file changed, 5 insertions(+), 28 deletions(-)

diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
index de9e970d4d11..d2eff20b8917 100644
--- a/lib/ethdev/rte_ethdev.h
+++ b/lib/ethdev/rte_ethdev.h
@@ -3356,34 +3356,11 @@ int rte_eth_macaddrs_get(uint16_t port_id, struct rte_ether_addr *ma,
 /**
  * Retrieve the contextual information of an Ethernet device.
  *
- * As part of this function, a number of of fields in dev_info will be
- * initialized as follows:
- *
- * rx_desc_lim = lim
- * tx_desc_lim = lim
- *
- * Where lim is defined within the rte_eth_dev_info_get as
- *
- *  const struct rte_eth_desc_lim lim = {
- *      .nb_max = UINT16_MAX,
- *      .nb_min = 0,
- *      .nb_align = 1,
- *	.nb_seg_max = UINT16_MAX,
- *	.nb_mtu_seg_max = UINT16_MAX,
- *  };
- *
- * device = dev->device
- * min_mtu = RTE_ETHER_MIN_LEN - RTE_ETHER_HDR_LEN - RTE_ETHER_CRC_LEN
- * max_mtu = UINT16_MAX
- *
- * The following fields will be populated if support for dev_infos_get()
- * exists for the device and the rte_eth_dev 'dev' has been populated
- * successfully with a call to it:
- *
- * driver_name = dev->device->driver->name
- * nb_rx_queues = dev->data->nb_rx_queues
- * nb_tx_queues = dev->data->nb_tx_queues
- * dev_flags = &dev->data->dev_flags
+ * The device information about driver, descriptors limits,
+ * capabilities, flags,  and queues is returned.
+ *
+ * The fields are populated with generic values that then are
+ * overridden by the device driver specific values.
  *
  * @param port_id
  *   The port identifier of the Ethernet device.
-- 
2.35.1

[PATCH v3 02/20] remove repeated word 'to'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 app/test/test_resource.c                  | 2 +-
 drivers/common/sfc_efx/base/siena_nvram.c | 2 +-
 lib/pipeline/rte_swx_ctl.c                | 2 +-
 lib/power/guest_channel.c                 | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/app/test/test_resource.c b/app/test/test_resource.c
index 8f41e3babdc5..05c27db203cc 100644
--- a/app/test/test_resource.c
+++ b/app/test/test_resource.c
@@ -45,7 +45,7 @@ static int test_resource_c(void)
 			r->name);
 
 	TEST_ASSERT_SUCCESS(resource_fwrite_file(r, "test_resource.c"),
-			"Failed to to write file %s", r->name);
+			"Failed to write file %s", r->name);
 
 	f = fopen("test_resource.c", "r");
 	TEST_ASSERT_NOT_NULL(f,
diff --git a/drivers/common/sfc_efx/base/siena_nvram.c b/drivers/common/sfc_efx/base/siena_nvram.c
index 05ca4bd83dc9..ebcd3487b631 100644
--- a/drivers/common/sfc_efx/base/siena_nvram.c
+++ b/drivers/common/sfc_efx/base/siena_nvram.c
@@ -532,7 +532,7 @@ siena_nvram_partn_get_version(
 			: MC_CMD_NVRAM_TYPE_DYNAMIC_CFG_PORT1;
 		/*
 		 * Ingore missing partitions on port 2, assuming they're due
-		 * to to running on a single port part.
+		 * to running on a single port part.
 		 */
 		if ((1 << dcfg_partn) &  ~enp->en_u.siena.enu_partn_mask) {
 			if (entry->port == 2)
diff --git a/lib/pipeline/rte_swx_ctl.c b/lib/pipeline/rte_swx_ctl.c
index 710e89a46a26..9b7bf5e0fb01 100644
--- a/lib/pipeline/rte_swx_ctl.c
+++ b/lib/pipeline/rte_swx_ctl.c
@@ -1582,7 +1582,7 @@ rte_swx_ctl_pipeline_table_entry_delete(struct rte_swx_ctl_pipeline *ctl,
 	CHECK(!table_entry_check(ctl, table_id, entry, 1, 0), EINVAL);
 
 	/* The entry is found in the table->entries list:
-	 * - Move the existing entry from the table->entries list to to the
+	 * - Move the existing entry from the table->entries list to the
 	 *   table->pending_delete list.
 	 */
 	existing_entry = table_entries_find(table, entry);
diff --git a/lib/power/guest_channel.c b/lib/power/guest_channel.c
index 969a9e5aaa06..7b2ae0b6506f 100644
--- a/lib/power/guest_channel.c
+++ b/lib/power/guest_channel.c
@@ -74,7 +74,7 @@ guest_channel_host_connect(const char *path, unsigned int lcore_id)
 			fd_path, lcore_id);
 	fd = open(fd_path, O_RDWR);
 	if (fd < 0) {
-		RTE_LOG(ERR, GUEST_CHANNEL, "Unable to to connect to '%s' with error "
+		RTE_LOG(ERR, GUEST_CHANNEL, "Unable to connect to '%s' with error "
 				"%s\n", fd_path, strerror(errno));
 		return -1;
 	}
-- 
2.35.1

[PATCH v3 03/20] remove repeated word 'is'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/common/sfc_efx/base/efx_regs_mcdi.h | 2 +-
 lib/net/rte_ether.h                         | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/common/sfc_efx/base/efx_regs_mcdi.h b/drivers/common/sfc_efx/base/efx_regs_mcdi.h
index 2daf825a366e..f3ec456864f6 100644
--- a/drivers/common/sfc_efx/base/efx_regs_mcdi.h
+++ b/drivers/common/sfc_efx/base/efx_regs_mcdi.h
@@ -7992,7 +7992,7 @@
 #define	MC_CMD_SENSOR_SET_LIMS_IN_SENSOR_LEN 4
 /*            Enum values, see field(s): */
 /*               MC_CMD_SENSOR_INFO/MC_CMD_SENSOR_INFO_OUT/MASK */
-/* interpretation is is sensor-specific. */
+/* interpretation is sensor-specific. */
 #define	MC_CMD_SENSOR_SET_LIMS_IN_LOW0_OFST 4
 #define	MC_CMD_SENSOR_SET_LIMS_IN_LOW0_LEN 4
 /* interpretation is is sensor-specific. */
diff --git a/lib/net/rte_ether.h b/lib/net/rte_ether.h
index bf8a55ba06ca..b35c72c7b0e0 100644
--- a/lib/net/rte_ether.h
+++ b/lib/net/rte_ether.h
@@ -350,7 +350,7 @@ static inline int rte_vlan_strip(struct rte_mbuf *m)
  *   The packet mbuf.
  * @return
  *   - 0: On success
- *   -EPERM: mbuf is is shared overwriting would be unsafe
+ *   -EPERM: mbuf is shared overwriting would be unsafe
  *   -ENOSPC: not enough headroom in mbuf
  */
 static inline int rte_vlan_insert(struct rte_mbuf **m)
-- 
2.35.1

[PATCH v3 04/20] remove repeated word 'same'

[Stephen Hemminger]

The word 'same' is duplicated in comment.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Liron Himi <lironh@marvell.com>
---
 drivers/net/mvneta/mvneta_ethdev.c | 2 +-
 drivers/net/mvpp2/mrvl_ethdev.c    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/mvneta/mvneta_ethdev.c b/drivers/net/mvneta/mvneta_ethdev.c
index eef016aa0b65..fc13b2547f31 100644
--- a/drivers/net/mvneta/mvneta_ethdev.c
+++ b/drivers/net/mvneta/mvneta_ethdev.c
@@ -350,7 +350,7 @@ mvneta_dev_start(struct rte_eth_dev *dev)
 	mvneta_stats_reset(dev);
 
 	/*
-	 * In case there are some some stale uc/mc mac addresses flush them
+	 * In case there are some stale uc/mc mac addresses flush them
 	 * here. It cannot be done during mvneta_dev_close() as port information
 	 * is already gone at that point (due to neta_ppio_deinit() in
 	 * mvneta_dev_stop()).
diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c
index 735efb6cfc06..19a4e3b8c329 100644
--- a/drivers/net/mvpp2/mrvl_ethdev.c
+++ b/drivers/net/mvpp2/mrvl_ethdev.c
@@ -858,7 +858,7 @@ mrvl_dev_start(struct rte_eth_dev *dev)
 	}
 
 	/*
-	 * In case there are some some stale uc/mc mac addresses flush them
+	 * In case there are some stale uc/mc mac addresses flush them
 	 * here. It cannot be done during mrvl_dev_close() as port information
 	 * is already gone at that point (due to pp2_ppio_deinit() in
 	 * mrvl_dev_stop()).
-- 
2.35.1

[PATCH v3 05/20] remove repeated word 'on'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/bonding/rte_eth_bond_8023ad.h   | 2 +-
 examples/vm_power_manager/channel_monitor.h | 2 +-
 examples/vm_power_manager/oob_monitor.h     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.h b/drivers/net/bonding/rte_eth_bond_8023ad.h
index 7eb392f8c8a1..7ad8d6d00bd5 100644
--- a/drivers/net/bonding/rte_eth_bond_8023ad.h
+++ b/drivers/net/bonding/rte_eth_bond_8023ad.h
@@ -271,7 +271,7 @@ rte_eth_bond_8023ad_ext_slowtx(uint16_t port_id, uint16_t slave_id,
 		struct rte_mbuf *lacp_pkt);
 
 /**
- * Enable dedicated hw queues for 802.3ad control plane traffic on on slaves
+ * Enable dedicated hw queues for 802.3ad control plane traffic on slaves
  *
  * This function creates an additional tx and rx queue on each slave for
  * dedicated 802.3ad control plane traffic . A flow filtering rule is
diff --git a/examples/vm_power_manager/channel_monitor.h b/examples/vm_power_manager/channel_monitor.h
index 2b38c554b5cd..ab69524af52c 100644
--- a/examples/vm_power_manager/channel_monitor.h
+++ b/examples/vm_power_manager/channel_monitor.h
@@ -41,7 +41,7 @@ extern "C" {
 int channel_monitor_init(void);
 
 /**
- * Run the channel monitor, loops forever on on epoll_wait.
+ * Run the channel monitor, loops forever on epoll_wait.
  *
  *
  * @return
diff --git a/examples/vm_power_manager/oob_monitor.h b/examples/vm_power_manager/oob_monitor.h
index b96e08df782c..2389c1151956 100644
--- a/examples/vm_power_manager/oob_monitor.h
+++ b/examples/vm_power_manager/oob_monitor.h
@@ -20,7 +20,7 @@ extern "C" {
 int branch_monitor_init(void);
 
 /**
- * Run the OOB branch monitor, loops forever on on epoll_wait.
+ * Run the OOB branch monitor, loops forever on epoll_wait.
  *
  *
  * @return
-- 
2.35.1

[PATCH v3 06/20] remove repeated word 'in'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/common/sfc_efx/base/efx_types.h | 2 +-
 drivers/event/sw/sw_evdev.c             | 2 +-
 drivers/net/hns3/hns3_ethdev.c          | 2 +-
 drivers/net/mlx5/mlx5_flow.c            | 2 +-
 drivers/net/sfc/sfc_ef10_tx.c           | 2 +-
 drivers/net/sfc/sfc_tso.c               | 2 +-
 lib/mbuf/rte_mbuf_core.h                | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/common/sfc_efx/base/efx_types.h b/drivers/common/sfc_efx/base/efx_types.h
index 12ae1084d83a..a6123962f976 100644
--- a/drivers/common/sfc_efx/base/efx_types.h
+++ b/drivers/common/sfc_efx/base/efx_types.h
@@ -399,7 +399,7 @@ extern int fix_lint;
  *
  *   (_element) << 4
  *
- * The result will contain the relevant bits filled in in the range
+ * The result will contain the relevant bits filled in the range
  * [0,high-low), with garbage in bits [high-low+1,...).
  */
 #define	EFX_EXTRACT_NATIVE(_element, _min, _max, _low, _high)		\
diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
index f93313b31b5c..7be9ac320963 100644
--- a/drivers/event/sw/sw_evdev.c
+++ b/drivers/event/sw/sw_evdev.c
@@ -244,7 +244,7 @@ qid_init(struct sw_evdev *sw, unsigned int idx, int type,
 	if (qid->type == RTE_SCHED_TYPE_ORDERED) {
 		uint32_t window_size;
 
-		/* rte_ring and window_size_mask require require window_size to
+		/* rte_ring and window_size_mask require window_size to
 		 * be a power-of-2.
 		 */
 		window_size = rte_align32pow2(
diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c
index 6b1d1a5fb191..29cff1946932 100644
--- a/drivers/net/hns3/hns3_ethdev.c
+++ b/drivers/net/hns3/hns3_ethdev.c
@@ -3904,7 +3904,7 @@ hns3_dev_promiscuous_enable(struct rte_eth_dev *dev)
 
 	/*
 	 * When promiscuous mode was enabled, disable the vlan filter to let
-	 * all packets coming in in the receiving direction.
+	 * all packets coming in the receiving direction.
 	 */
 	offloads = dev->data->dev_conf.rxmode.offloads;
 	if (offloads & RTE_ETH_RX_OFFLOAD_VLAN_FILTER) {
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 8c93a3f2e5ac..674dc31cadd0 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -4816,7 +4816,7 @@ flow_mreg_del_default_copy_action(struct rte_eth_dev *dev)
 }
 
 /**
- * Add the default copy action in in RX_CP_TBL.
+ * Add the default copy action in RX_CP_TBL.
  *
  * This functions is called in the mlx5_dev_start(). No thread safe
  * is guaranteed.
diff --git a/drivers/net/sfc/sfc_ef10_tx.c b/drivers/net/sfc/sfc_ef10_tx.c
index 5403a60707d1..116229382b68 100644
--- a/drivers/net/sfc/sfc_ef10_tx.c
+++ b/drivers/net/sfc/sfc_ef10_tx.c
@@ -503,7 +503,7 @@ sfc_ef10_xmit_tso_pkt(struct sfc_ef10_txq * const txq, struct rte_mbuf *m_seg,
 
 	/*
 	 * Tx prepare has debug-only checks that offload flags are correctly
-	 * filled in in TSO mbuf. Use zero IPID if there is no IPv4 flag.
+	 * filled in TSO mbuf. Use zero IPID if there is no IPv4 flag.
 	 * If the packet is still IPv4, HW will simply start from zero IPID.
 	 */
 	if (first_m_seg->ol_flags & RTE_MBUF_F_TX_IPV4)
diff --git a/drivers/net/sfc/sfc_tso.c b/drivers/net/sfc/sfc_tso.c
index 927e351a6ed4..a0827d1c0dd6 100644
--- a/drivers/net/sfc/sfc_tso.c
+++ b/drivers/net/sfc/sfc_tso.c
@@ -149,7 +149,7 @@ sfc_efx_tso_do(struct sfc_efx_txq *txq, unsigned int idx,
 
 	/*
 	 * Handle IP header. Tx prepare has debug-only checks that offload flags
-	 * are correctly filled in in TSO mbuf. Use zero IPID if there is no
+	 * are correctly filled in TSO mbuf. Use zero IPID if there is no
 	 * IPv4 flag. If the packet is still IPv4, HW will simply start from
 	 * zero IPID.
 	 */
diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h
index 3d6ddd6773d2..b1c10cccc252 100644
--- a/lib/mbuf/rte_mbuf_core.h
+++ b/lib/mbuf/rte_mbuf_core.h
@@ -42,7 +42,7 @@ extern "C" {
 
 /**
  * The RX packet is a 802.1q VLAN packet, and the tci has been
- * saved in in mbuf->vlan_tci.
+ * saved in mbuf->vlan_tci.
  * If the flag RTE_MBUF_F_RX_VLAN_STRIPPED is also present, the VLAN
  * header has been stripped from mbuf data, else it is still
  * present.
-- 
2.35.1

[PATCH v3 07/20] remove repeated word 'this'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/ring/rte_ring.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/ring/rte_ring.c b/lib/ring/rte_ring.c
index cddaf6b2876f..8ed455043dee 100644
--- a/lib/ring/rte_ring.c
+++ b/lib/ring/rte_ring.c
@@ -280,7 +280,8 @@ rte_ring_create_elem(const char *name, unsigned int esize, unsigned int count,
 
 	/* reserve a memory zone for this ring. If we can't get rte_config or
 	 * we are secondary process, the memzone_reserve function will set
-	 * rte_errno for us appropriately - hence no check in this this function */
+	 * rte_errno for us appropriately - hence no check in this function
+	 */
 	mz = rte_memzone_reserve_aligned(mz_name, ring_size, socket_id,
 					 mz_flags, __alignof__(*r));
 	if (mz != NULL) {
-- 
2.35.1

[PATCH v3 08/20] remove repeated word 'then'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/i40e/i40e_fdir.c   | 2 +-
 drivers/net/igc/base/igc_mac.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c
index 8caedea14eaa..3b7714217405 100644
--- a/drivers/net/i40e/i40e_fdir.c
+++ b/drivers/net/i40e/i40e_fdir.c
@@ -377,7 +377,7 @@ i40e_init_flx_pld(struct i40e_pf *pf)
 	if ((flex_pit2).src_offset < \
 		(flex_pit1).src_offset + (flex_pit1).size) { \
 		PMD_DRV_LOG(ERR, "src_offset should be not" \
-			" less than than previous offset" \
+			" less than previous offset" \
 			" + previous FSIZE."); \
 		return -EINVAL; \
 	} \
diff --git a/drivers/net/igc/base/igc_mac.c b/drivers/net/igc/base/igc_mac.c
index 3cd6506e5e60..0822ffe7c37c 100644
--- a/drivers/net/igc/base/igc_mac.c
+++ b/drivers/net/igc/base/igc_mac.c
@@ -587,7 +587,7 @@ void igc_update_mc_addr_list_generic(struct igc_hw *hw,
  *  @hw: pointer to the HW structure
  *
  *  In certain situations, a system BIOS may report that the PCIx maximum
- *  memory read byte count (MMRBC) value is higher than than the actual
+ *  memory read byte count (MMRBC) value is higher than the actual
  *  value. We check the PCIx command register with the current PCIx status
  *  register.
  **/
-- 
2.35.1

[PATCH v3 09/20] remove repeated word 'only'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Rasesh Mody <rmody@marvell.com>
---
 drivers/net/bnx2x/bnx2x.c      | 2 +-
 drivers/net/pcap/pcap_ethdev.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
index 74e3018eab6f..29c16bb207c7 100644
--- a/drivers/net/bnx2x/bnx2x.c
+++ b/drivers/net/bnx2x/bnx2x.c
@@ -5929,7 +5929,7 @@ static uint8_t bnx2x_trylock_hw_lock(struct bnx2x_softc *sc, uint32_t resource)
 
 /*
  * Get the recovery leader resource id according to the engine this function
- * belongs to. Currently only only 2 engines is supported.
+ * belongs to. Currently only 2 engines are supported.
  */
 static int bnx2x_get_leader_lock_resource(struct bnx2x_softc *sc)
 {
diff --git a/drivers/net/pcap/pcap_ethdev.c b/drivers/net/pcap/pcap_ethdev.c
index ec29fd6bc53c..bcb02ca0638e 100644
--- a/drivers/net/pcap/pcap_ethdev.c
+++ b/drivers/net/pcap/pcap_ethdev.c
@@ -1336,7 +1336,7 @@ eth_from_pcaps(struct rte_vdev_device *vdev,
 		internals->if_index =
 			osdep_iface_index_get(rx_queues->queue[0].name);
 
-		/* phy_mac arg is applied only only if "iface" devarg is provided */
+		/* phy_mac arg is applied only if "iface" devarg is provided */
 		if (rx_queues->phy_mac) {
 			if (eth_pcap_update_mac(rx_queues->queue[0].name,
 					eth_dev, vdev->device.numa_node) == 0)
-- 
2.35.1

[PATCH v3 10/20] remove repeated word 'worker'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/distributor/rte_distributor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/distributor/rte_distributor.c b/lib/distributor/rte_distributor.c
index 3035b7a99925..967e27d35a49 100644
--- a/lib/distributor/rte_distributor.c
+++ b/lib/distributor/rte_distributor.c
@@ -575,7 +575,7 @@ rte_distributor_process(struct rte_distributor *d,
 					}
 				}
 
-				/* Add to current worker worker */
+				/* Add to current worker */
 				unsigned int idx = bl->count++;
 
 				bl->tags[idx] = new_tag;
-- 
2.35.1

[PATCH v3 11/20] remove repeated word 'or'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/cxgbe/sge.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/cxgbe/sge.c b/drivers/net/cxgbe/sge.c
index 5d91355c9ab1..1a767dabf59c 100644
--- a/drivers/net/cxgbe/sge.c
+++ b/drivers/net/cxgbe/sge.c
@@ -65,7 +65,7 @@ static inline void ship_tx_pkt_coalesce_wr(struct adapter *adap,
  * for DMA, but this is of course never sent to the hardware and is only used
  * to prevent double unmappings.  All of the above requires that the Free List
  * Buffers which we allocate have the bottom 5 bits free (0) -- i.e. are
- * 32-byte or or a power of 2 greater in alignment.  Since the SGE's minimal
+ * 32-byte or a power of 2 greater in alignment.  Since the SGE's minimal
  * Free List Buffer alignment is 32 bytes, this works out for us ...
  */
 enum {
-- 
2.35.1

[PATCH v3 12/20] remove repeated word 'table'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/ixgbe/ixgbe_ipsec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ixgbe/ixgbe_ipsec.c b/drivers/net/ixgbe/ixgbe_ipsec.c
index c353ae33b4f8..3d479011bea1 100644
--- a/drivers/net/ixgbe/ixgbe_ipsec.c
+++ b/drivers/net/ixgbe/ixgbe_ipsec.c
@@ -310,7 +310,7 @@ ixgbe_crypto_remove_sa(struct rte_eth_dev *dev,
 			return -1;
 		}
 
-		/* Disable and clear Rx SPI and key table table entries*/
+		/* Disable and clear Rx SPI and key table entries*/
 		reg_val = IPSRXIDX_WRITE | IPSRXIDX_TABLE_SPI | (sa_index << 3);
 		IXGBE_WRITE_REG(hw, IXGBE_IPSRXSPI, 0);
 		IXGBE_WRITE_REG(hw, IXGBE_IPSRXIPIDX, 0);
-- 
2.35.1

[PATCH v3 13/20] remove repeated word 'that'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
---
 drivers/net/nfp/nfp_ctrl.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/nfp/nfp_ctrl.h b/drivers/net/nfp/nfp_ctrl.h
index 372d53746243..2327d4eb7646 100644
--- a/drivers/net/nfp/nfp_ctrl.h
+++ b/drivers/net/nfp/nfp_ctrl.h
@@ -182,7 +182,7 @@
  * Reuse spare address to contain the offset from the start of
  * the host buffer where the first byte of the received frame
  * will land.  Any metadata will come prior to that offset.  If the
- * value in this field is 0, it means that that the metadata will
+ * value in this field is 0, it means that the metadata will
  * always land starting at the first byte of the host buffer and
  * packet data will immediately follow the metadata.  As always,
  * the RX descriptor indicates the presence or absence of metadata
-- 
2.35.1

[PATCH v3 14/20] remove repeated word 'override'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
index 8444f1a7950d..0721fdd3f0d7 100644
--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
@@ -191,7 +191,7 @@ build_proto_compound_sg_fd(dpaa2_sec_session *sess,
 	if (sess->ctxt_type == DPAA2_SEC_PDCP && sess->pdcp.hfn_ovd) {
 		uint32_t hfn_ovd = *(uint32_t *)((uint8_t *)op +
 					sess->pdcp.hfn_ovd_offset);
-		/*enable HFN override override */
+		/* enable HFN override */
 		DPAA2_SET_FLE_INTERNAL_JD(ip_fle, hfn_ovd);
 		DPAA2_SET_FLE_INTERNAL_JD(op_fle, hfn_ovd);
 		DPAA2_SET_FD_INTERNAL_JD(fd, hfn_ovd);
@@ -267,7 +267,7 @@ build_proto_compound_fd(dpaa2_sec_session *sess,
 	if (sess->ctxt_type == DPAA2_SEC_PDCP && sess->pdcp.hfn_ovd) {
 		uint32_t hfn_ovd = *(uint32_t *)((uint8_t *)op +
 					sess->pdcp.hfn_ovd_offset);
-		/*enable HFN override override */
+		/* enable HFN override */
 		DPAA2_SET_FLE_INTERNAL_JD(ip_fle, hfn_ovd);
 		DPAA2_SET_FLE_INTERNAL_JD(op_fle, hfn_ovd);
 		DPAA2_SET_FD_INTERNAL_JD(fd, hfn_ovd);
-- 
2.35.1

[PATCH v3 15/20] remove repeated word 'groups'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 app/test/test_ipsec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test/test_ipsec.c b/app/test/test_ipsec.c
index 7047e1796091..8d208c526a49 100644
--- a/app/test/test_ipsec.c
+++ b/app/test/test_ipsec.c
@@ -968,7 +968,7 @@ crypto_ipsec_4grp(uint32_t pkt_num)
 {
 	uint32_t sa_ind;
 
-	/* group packets in 4 different size groups groups, 2 per SA */
+	/* group packets in 4 different size groups, 2 per SA */
 	if (pkt_num < PKT_4)
 		sa_ind = 0;
 	else if (pkt_num < PKT_12)
-- 
2.35.1

[PATCH v3 16/20] remove repeated word 'page'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/bnx2x/ecore_fw_defs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bnx2x/ecore_fw_defs.h b/drivers/net/bnx2x/ecore_fw_defs.h
index 6fc1fce7e29c..ab1abf6b34b3 100644
--- a/drivers/net/bnx2x/ecore_fw_defs.h
+++ b/drivers/net/bnx2x/ecore_fw_defs.h
@@ -341,7 +341,7 @@
 #define TOE_STATE (TOE_CONNECTION_TYPE << PROTOCOL_STATE_BIT_OFFSET)
 #define RDMA_STATE (RDMA_CONNECTION_TYPE << PROTOCOL_STATE_BIT_OFFSET)
 
-/* microcode fixed page page size 4K (chains and ring segments) */
+/* microcode fixed page size 4K (chains and ring segments) */
 #define MC_PAGE_SIZE 4096
 
 /* Number of indices per slow-path SB */
-- 
2.35.1

[PATCH v3 17/20] remove repeated word 'individual'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/cxgbe/cxgbe_filter.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/cxgbe/cxgbe_filter.h b/drivers/net/cxgbe/cxgbe_filter.h
index 46ebf833381e..6e099a5c1cfc 100644
--- a/drivers/net/cxgbe/cxgbe_filter.h
+++ b/drivers/net/cxgbe/cxgbe_filter.h
@@ -28,7 +28,7 @@
  * (value, mask) tuples.  The associated ingress packet field matches the
  * tuple when ((field & mask) == value).  (Thus a wildcard "don't care" field
  * rule can be constructed by specifying a tuple of (0, 0).)  A filter rule
- * matches an ingress packet when all of the individual individual field
+ * matches an ingress packet when all of the individual field
  * matching rules are true.
  *
  * Partial field masks are always valid, however, while it may be easy to
-- 
2.35.1

[PATCH v3 18/20] remove repeated word 'expected'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/bpf/rte_bpf_ethdev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/bpf/rte_bpf_ethdev.h b/lib/bpf/rte_bpf_ethdev.h
index 135062c9e13c..1cca2e6c95a2 100644
--- a/lib/bpf/rte_bpf_ethdev.h
+++ b/lib/bpf/rte_bpf_ethdev.h
@@ -99,7 +99,7 @@ rte_bpf_eth_rx_elf_load(uint16_t port, uint16_t queue,
  * @param prm
  *  Parameters used to create and initialise the BPF execution context.
  * @param flags
- *  Flags that define expected expected behavior of the loaded filter
+ *  Flags that define expected behavior of the loaded filter
  *  (i.e. jited/non-jited version to use).
  * @return
  *   Zero on successful completion or negative error code otherwise.
-- 
2.35.1

[PATCH v3 19/20] remove repeated word 'be'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Devendra Singh Rawat <dsinghrawat@marvell.com>
Acked-by: Rasesh Mody <rmody@marvell.com>
---
 drivers/net/qede/qede_filter.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/qede/qede_filter.c b/drivers/net/qede/qede_filter.c
index ca3165d97210..24035b64e7a1 100644
--- a/drivers/net/qede/qede_filter.c
+++ b/drivers/net/qede/qede_filter.c
@@ -560,7 +560,7 @@ qede_udp_dst_port_del(struct rte_eth_dev *eth_dev,
 
 		qdev->vxlan.udp_port = udp_port;
 		/* If the request is to delete UDP port and if the number of
-		 * VXLAN filters have reached 0 then VxLAN offload can be be
+		 * VXLAN filters have reached 0 then VxLAN offload can be
 		 * disabled.
 		 */
 		if (qdev->vxlan.enable && qdev->vxlan.num_filters == 0)
@@ -589,7 +589,7 @@ qede_udp_dst_port_del(struct rte_eth_dev *eth_dev,
 
 		qdev->vxlan.udp_port = udp_port;
 		/* If the request is to delete UDP port and if the number of
-		 * GENEVE filters have reached 0 then GENEVE offload can be be
+		 * GENEVE filters have reached 0 then GENEVE offload can be
 		 * disabled.
 		 */
 		if (qdev->geneve.enable && qdev->geneve.num_filters == 0)
-- 
2.35.1

[PATCH v3 20/20] remove repeated word 'all'

[Stephen Hemminger]

Found by doing duplicate word scan.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/bnx2x/ecore_sp.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bnx2x/ecore_sp.h b/drivers/net/bnx2x/ecore_sp.h
index 1f4d5a3ebe29..c0b4d431c879 100644
--- a/drivers/net/bnx2x/ecore_sp.h
+++ b/drivers/net/bnx2x/ecore_sp.h
@@ -787,7 +787,7 @@ struct ecore_vlan_mac_obj {
 	/**
 	*  Delete all configured elements having the given
 	*  vlan_mac_flags specification. Assumes no pending for
-	*  execution commands. Will schedule all all currently
+	*  execution commands. Will schedule all currently
 	*  configured MACs/VLANs/VLAN-MACs matching the vlan_mac_flags
 	*  specification for deletion and will use the given
 	*  ramrod_flags for the last DEL operation.
-- 
2.35.1

RE: [PATCH v3 14/20] remove repeated word 'override'

[Hemant Agrawal]

> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Tuesday, July 26, 2022 10:00 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; Gagandeep Singh
> <G.Singh@nxp.com>; Hemant Agrawal <hemant.agrawal@nxp.com>
> Subject: [PATCH v3 14/20] remove repeated word 'override'
> Importance: High
> 
> Found by doing duplicate word scan.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com