From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 95AA8A00BE;
	Sun, 26 Apr 2020 21:56:53 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 692DC1C190;
	Sun, 26 Apr 2020 21:56:52 +0200 (CEST)
Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com
 [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 728C71C12C
 for <dev@dpdk.org>; Sun, 26 Apr 2020 21:56:50 +0200 (CEST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47])
 by mailout.west.internal (Postfix) with ESMTP id AD32250F;
 Sun, 26 Apr 2020 15:56:46 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute7.internal (MEProxy); Sun, 26 Apr 2020 15:56:47 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm1; bh=
 WR0HoDAbyV6bxaPbHE/xFPIE/Zrz1K3WkgHYEmZt0q0=; b=fsE4OPoefE7nCiJR
 WB/2s7BIdppPQs3zLrN5jrpjAeYXdncJrn4KqPQ4WPL1HGapeEBp0B5EPgp5H1Zd
 jTPas+UxaqA1d9nnZpdII3Yu3ZsTXf/Ma785LlkTKnKmIRMcf7aQzC7Vg7U/RcCV
 UUrevM+nbokD44VEUZexBrhuMtiYfQCrfSn2xmXV35FVPDMtM7apu8BlD8xL1mDE
 57jnyzOOjGpNwWvAk7fGoA0Hfw8SHYfFXbwILPLFU8e8aFfzgiLQc6TxcHQ19fMU
 rFc0nhrtlP6z2hLu4jeG7AYyZva79lRwnmh7OA/PDH5I/f3eU2KUoKrJhsIVyTcx
 uSW53Q==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=WR0HoDAbyV6bxaPbHE/xFPIE/Zrz1K3WkgHYEmZt0
 q0=; b=mFDCcAUOqh9WjceSgBDDG5jWaef0VGKfE3J6rQG7gvRahWUAbr6032eLq
 qyU0jiRrtOU9uF38RGXwbqOn+6sMiANQi4jlCRAKf6TOkPrnlRP9DvbE8SxuKD5T
 8a7rmjGQyM9ChiIminGVr8wmDtUlHvsRV2VJi1V9n4QEu9e55PI7IOfeRizjCbER
 oX7vjK1puvdPXD5RxEK1WLmwp7RISmQn6lAEL2Fvc7tAK436V2J7Fc/HzwKwSMHt
 GlTlJL3cFxJTVwto12lxGty4QubZ7XhYzN2LpJwsxV2zRbQDaLbxkzhYJvNj74nj
 CJSTjjrj7c7vlBwgVJ07stRsd3n/A==
X-ME-Sender: <xms:feelXorHH0TmNsLjIfbN5BK4XjeHpuR41YClcVS6ZJQMBR-arHgKkg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrheejgddugeefucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff
 homhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrddvtdefrddukeegnecu
 vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrg
 hssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:feelXvGnpz_PuJCkxFbwyi7wbnofbW9_WF5VlqPsPxB5EwtoXJ4iGw>
 <xmx:feelXt4DeFRWlXGDxB7E7_MAjysfNTM-tsM8UmHU1Z0MSaO751jIvQ>
 <xmx:feelXncAB1ezUJ0Fc2BQIirIjrx3kRp5EBSEUl8NqY116j-8tkt1ew>
 <xmx:fuelXnmhIbphawXOhqvuZ7rf2XnYi-P3OEAlwwH2Oz8q-yk3tage8A>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 67AA63280064;
 Sun, 26 Apr 2020 15:56:45 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Jerin Jacob <jerinjacobk@gmail.com>
Cc: Jerin Jacob <jerinj@marvell.com>, dpdk-dev <dev@dpdk.org>,
 Olivier Matz <olivier.matz@6wind.com>
Date: Sun, 26 Apr 2020 21:56:44 +0200
Message-ID: <2638871.7x91mkYCy2@thomas>
In-Reply-To: <CALBAE1PyGB+6x6i6gwegerV=_TMijv5OCy6vf6j166AgUWhhEA@mail.gmail.com>
References: <20200121080021.2835490-1-jerinj@marvell.com>
 <4168892.bm5RmrZB5H@thomas>
 <CALBAE1PyGB+6x6i6gwegerV=_TMijv5OCy6vf6j166AgUWhhEA@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] bus/pci: set boot-up log prints to absolute
	minimum
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

26/04/2020 20:48, Jerin Jacob:
> On Sun, Apr 26, 2020 at 11:37 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > 26/04/2020 19:42, Jerin Jacob:
> > > On Sun, Apr 26, 2020 at 1:42 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> > > > 06/02/2020 15:36, Jerin Jacob:
> > > > > On Thu, Feb 6, 2020 at 7:44 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > > > > > 21/01/2020 09:00, jerinj@marvell.com:
> > > > > > > From: Jerin Jacob <jerinj@marvell.com>
> > > > > > >
> > > > > > > Some machines may have a lot of PCI devices, logs from PCI probe
> > > > > > > creates a lot of clutter on boot-up, typically one needs
> > > > > > > to scroll the screen to find other issues in boot-up.
> > > > > > >
> > > > > > > This patch changes the loglevel of PCI probes to `debug`
> > > > > > > to reduce the clutter on default boot-up logs
> > > > > >
> > > > > > I think the PCI probe informations are... informational.
> > > > > > Maybe you are just not interested in info logs.
> > > > > > If this is the case, I suggest to change the log level at runtime.
> > > > >
> > > > > I am wondering, what would be the right balance, Following is DPDK
> > > > > startup output from octeontx2[1]
> > > > > It creates a lot of clutter in the "default" boot up. Why not enable
> > > > > below prints using log level at runtime?
> > > > > I believe it comes as a debug category, i.e information required to
> > > > > debug if something is not working,
> > > > > dpdk bind script already lists what is bound to DPDK.
> > > > >
> > > > > Suggestion to remove clutter?
> > > >
> > > > I suggest using dynamic log level in the PCI driver.
> > > > Unfortunately a lot of old DPDK code is still using the old log macros.
> > > > Some cleanup work is needed here.
> > >
> > > Sent an alternative fix to skip probing the devices with RTE_KDRV_NONE.
> >
> > No, a PCI PMD can work without a known kernel driver.
> > This is the case of mlx4/mlx5.
> 
> Yes. it can work with UNKNOWN, But It not with NONE.
> 
> > > I think that is the source of the problem.
> > > http://patches.dpdk.org/patch/69351/
> >
> > The source of the problem is just changing log levels dynamically
> > is not possible currently with PCI driver logs.
> 
> Assuming if we add, dynamic stuff what would the default log level for
> RTE_LOG(INFO, EAL, "PCI device "PCI_PRI_FMT" on NUMA socket %i\n",
> 
> If it is INFO, Still the problem persist in the default bootup. Right?

Yes

We need to know in INFO level which devices are successfully probed.
You want to decrease to DEBUG the level of logs announcing a probe.
I think it would be OK if adding an INFO log after probe success.