* [PATCH] net/i40e: reduce the ITR interval of multi-driver mode @ 2022-12-16 3:11 Qiming Yang 2022-12-26 5:50 ` Zhang, Qi Z 0 siblings, 1 reply; 4+ messages in thread From: Qiming Yang @ 2022-12-16 3:11 UTC (permalink / raw) To: dev, beilei.xing; +Cc: Qiming Yang This patch change the interrupt interval from 8160us to 32us to improve the performance of multi-driver mode. Signed-off-by: Qiming Yang <qiming.yang@intel.com> --- drivers/net/i40e/i40e_ethdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev.h b/drivers/net/i40e/i40e_ethdev.h index fe943a45ff..7c4cc44a27 100644 --- a/drivers/net/i40e/i40e_ethdev.h +++ b/drivers/net/i40e/i40e_ethdev.h @@ -1497,7 +1497,7 @@ i40e_calc_itr_interval(bool is_pf, bool is_multi_drv) uint16_t interval = 0; if (is_multi_drv) { - interval = I40E_QUEUE_ITR_INTERVAL_MAX; + interval = I40E_QUEUE_ITR_INTERVAL_DEFAULT; } else { if (is_pf) interval = I40E_QUEUE_ITR_INTERVAL_DEFAULT; -- 2.25.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] net/i40e: reduce the ITR interval of multi-driver mode 2022-12-16 3:11 [PATCH] net/i40e: reduce the ITR interval of multi-driver mode Qiming Yang @ 2022-12-26 5:50 ` Zhang, Qi Z 2023-02-22 16:49 ` Kevin Traynor 0 siblings, 1 reply; 4+ messages in thread From: Zhang, Qi Z @ 2022-12-26 5:50 UTC (permalink / raw) To: Yang, Qiming, dev, Xing, Beilei; +Cc: Yang, Qiming > -----Original Message----- > From: Qiming Yang <qiming.yang@intel.com> > Sent: Friday, December 16, 2022 11:12 AM > To: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com> > Cc: Yang, Qiming <qiming.yang@intel.com> > Subject: [PATCH] net/i40e: reduce the ITR interval of multi-driver mode > > This patch change the interrupt interval from 8160us to 32us to improve the > performance of multi-driver mode. > > Signed-off-by: Qiming Yang <qiming.yang@intel.com> Acked-by: Qi Zhang <qi.z.zhang@intel.com> Applied to dpdk-next-net-intel. The patch also looks good for backporting, so added Cc stable tag. Thanks Qi > --- > drivers/net/i40e/i40e_ethdev.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/i40e/i40e_ethdev.h b/drivers/net/i40e/i40e_ethdev.h > index fe943a45ff..7c4cc44a27 100644 > --- a/drivers/net/i40e/i40e_ethdev.h > +++ b/drivers/net/i40e/i40e_ethdev.h > @@ -1497,7 +1497,7 @@ i40e_calc_itr_interval(bool is_pf, bool is_multi_drv) > uint16_t interval = 0; > > if (is_multi_drv) { > - interval = I40E_QUEUE_ITR_INTERVAL_MAX; > + interval = I40E_QUEUE_ITR_INTERVAL_DEFAULT; > } else { > if (is_pf) > interval = I40E_QUEUE_ITR_INTERVAL_DEFAULT; > -- > 2.25.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net/i40e: reduce the ITR interval of multi-driver mode 2022-12-26 5:50 ` Zhang, Qi Z @ 2023-02-22 16:49 ` Kevin Traynor 2023-02-23 4:34 ` Zhang, Qi Z 0 siblings, 1 reply; 4+ messages in thread From: Kevin Traynor @ 2023-02-22 16:49 UTC (permalink / raw) To: Zhang, Qi Z, Yang, Qiming, dev, Xing, Beilei, Xueming(Steven) Li, Luca Boccassi On 26/12/2022 05:50, Zhang, Qi Z wrote: > > >> -----Original Message----- >> From: Qiming Yang <qiming.yang@intel.com> >> Sent: Friday, December 16, 2022 11:12 AM >> To: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com> >> Cc: Yang, Qiming <qiming.yang@intel.com> >> Subject: [PATCH] net/i40e: reduce the ITR interval of multi-driver mode >> >> This patch change the interrupt interval from 8160us to 32us to improve the >> performance of multi-driver mode. >> >> Signed-off-by: Qiming Yang <qiming.yang@intel.com> > > Acked-by: Qi Zhang <qi.z.zhang@intel.com> > > Applied to dpdk-next-net-intel. > > The patch also looks good for backporting, so added Cc stable tag. > Hi. This looks like it is not fixing anything and it is changing a behaviour, so I won't take for 21.11.4. thanks, Kevin. > Thanks > Qi > > >> --- >> drivers/net/i40e/i40e_ethdev.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/i40e/i40e_ethdev.h b/drivers/net/i40e/i40e_ethdev.h >> index fe943a45ff..7c4cc44a27 100644 >> --- a/drivers/net/i40e/i40e_ethdev.h >> +++ b/drivers/net/i40e/i40e_ethdev.h >> @@ -1497,7 +1497,7 @@ i40e_calc_itr_interval(bool is_pf, bool is_multi_drv) >> uint16_t interval = 0; >> >> if (is_multi_drv) { >> - interval = I40E_QUEUE_ITR_INTERVAL_MAX; >> + interval = I40E_QUEUE_ITR_INTERVAL_DEFAULT; >> } else { >> if (is_pf) >> interval = I40E_QUEUE_ITR_INTERVAL_DEFAULT; >> -- >> 2.25.1 > ^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] net/i40e: reduce the ITR interval of multi-driver mode 2023-02-22 16:49 ` Kevin Traynor @ 2023-02-23 4:34 ` Zhang, Qi Z 0 siblings, 0 replies; 4+ messages in thread From: Zhang, Qi Z @ 2023-02-23 4:34 UTC (permalink / raw) To: Kevin Traynor, Yang, Qiming, dev, Xing, Beilei, Xueming(Steven) Li, Luca Boccassi > -----Original Message----- > From: Kevin Traynor <ktraynor@redhat.com> > Sent: Thursday, February 23, 2023 12:49 AM > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming > <qiming.yang@intel.com>; dev@dpdk.org; Xing, Beilei > <beilei.xing@intel.com>; Xueming(Steven) Li <xuemingl@nvidia.com>; Luca > Boccassi <bluca@debian.org> > Subject: Re: [PATCH] net/i40e: reduce the ITR interval of multi-driver mode > > On 26/12/2022 05:50, Zhang, Qi Z wrote: > > > > > >> -----Original Message----- > >> From: Qiming Yang <qiming.yang@intel.com> > >> Sent: Friday, December 16, 2022 11:12 AM > >> To: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com> > >> Cc: Yang, Qiming <qiming.yang@intel.com> > >> Subject: [PATCH] net/i40e: reduce the ITR interval of multi-driver > >> mode > >> > >> This patch change the interrupt interval from 8160us to 32us to > >> improve the performance of multi-driver mode. > >> > >> Signed-off-by: Qiming Yang <qiming.yang@intel.com> > > > > Acked-by: Qi Zhang <qi.z.zhang@intel.com> > > > > Applied to dpdk-next-net-intel. > > > > The patch also looks good for backporting, so added Cc stable tag. > > > > Hi. This looks like it is not fixing anything and it is changing a behaviour, so I > won't take for 21.11.4. This comes from customer issue, it does fix for the usage when latency is critical, will be nice if it can be applied, thanks. > > thanks, > Kevin. > > > Thanks > > Qi > > > > > >> --- > >> drivers/net/i40e/i40e_ethdev.h | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/net/i40e/i40e_ethdev.h > >> b/drivers/net/i40e/i40e_ethdev.h index fe943a45ff..7c4cc44a27 100644 > >> --- a/drivers/net/i40e/i40e_ethdev.h > >> +++ b/drivers/net/i40e/i40e_ethdev.h > >> @@ -1497,7 +1497,7 @@ i40e_calc_itr_interval(bool is_pf, bool > is_multi_drv) > >> uint16_t interval = 0; > >> > >> if (is_multi_drv) { > >> - interval = I40E_QUEUE_ITR_INTERVAL_MAX; > >> + interval = I40E_QUEUE_ITR_INTERVAL_DEFAULT; > >> } else { > >> if (is_pf) > >> interval = I40E_QUEUE_ITR_INTERVAL_DEFAULT; > >> -- > >> 2.25.1 > > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-23 4:34 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-12-16 3:11 [PATCH] net/i40e: reduce the ITR interval of multi-driver mode Qiming Yang 2022-12-26 5:50 ` Zhang, Qi Z 2023-02-22 16:49 ` Kevin Traynor 2023-02-23 4:34 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).