From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, "Bruce Richardson" <bruce.richardson@intel.com>,
"Robin Jarry" <robin.jarry@6wind.com>,
"Luca Boccassi" <bluca@debian.org>,
"Juraj Linkeš" <juraj.linkes@pantheon.tech>,
"Honnappa Nagarahalli" <honnappa.nagarahalli@arm.com>,
"Ruifeng Wang" <ruifeng.wang@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2] build: fix drivers config with no python interpreter
Date: Fri, 07 May 2021 15:45:41 +0200 [thread overview]
Message-ID: <2640340.5Zs37zTcB1@thomas> (raw)
In-Reply-To: <20210507115404.19828-1-david.marchand@redhat.com>
07/05/2021 13:54, David Marchand:
> If no enable_drivers option is passed, the default is to build the
> drivers list by calling list-dir-globs.py.
>
> But if no python interpreter is installed, no error is reported and all
> drivers end up being disabled.
>
> Example on a minimal FreeBSD vm:
>
> dpdk@freebsd:~/dpdk $ meson setup build
> ...
> drivers:
> common/cpt: not in enabled drivers build config
> common/dpaax: not in enabled drivers build config
> common/iavf: not in enabled drivers build config
> common/mvep: not in enabled drivers build config
> common/octeontx: not in enabled drivers build config
> common/octeontx2: not in enabled drivers build config
> bus/dpaa: not in enabled drivers build config
> bus/fslmc: not in enabled drivers build config
> ...
>
> dpdk@freebsd:~/dpdk $ cd drivers/
> dpdk@freebsd:~/dpdk/drivers $ ~/dpdk/buildtools/list-dir-globs.py */*
> env: python3: No such file or directory
>
> Rely on meson internal interpreter.
> Check return code when calling this script.
>
> Fixes: ab9407c3addd ("build: allow using wildcards to disable drivers")
> Fixes: 2e33309ebe03 ("config: enable/disable drivers in Arm builds")
+Cc: stable
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks
prev parent reply other threads:[~2021-05-07 13:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 9:21 [dpdk-dev] [PATCH] " David Marchand
2021-05-07 9:50 ` Bruce Richardson
2021-05-07 10:01 ` David Marchand
2021-05-07 11:54 ` [dpdk-dev] [PATCH v2] " David Marchand
2021-05-07 13:45 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2640340.5Zs37zTcB1@thomas \
--to=thomas@monjalon.net \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=honnappa.nagarahalli@arm.com \
--cc=juraj.linkes@pantheon.tech \
--cc=robin.jarry@6wind.com \
--cc=ruifeng.wang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).