From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CCF7843A3A; Tue, 6 Feb 2024 23:31:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6A013402E1; Tue, 6 Feb 2024 23:31:41 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id E996C402CE for ; Tue, 6 Feb 2024 23:31:39 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6EEDC5C00DA; Tue, 6 Feb 2024 17:31:39 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 06 Feb 2024 17:31:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1707258699; x=1707345099; bh=zlpo6Rq7N5C1pLkISfGFGC5SzB++fW3uHPb9ARC+4FA=; b= h8garNl/ZgrVPZSRANyToCLIdDCvMR2jXfcWsbl2RqnTyIm4lcadM+aFUM0k+GF3 5929A4aJ19oP5Lm+p7GEUf3T6bUUrwYlFaXoQFQWQeG8ZFvQxK3ruBOdvoe3qzTt VIAuJtp8i1aI1othfjF+RFqlvozVL44BFILG3IHWQi0gZ/fzCYbnSuatB8B77No1 gcx1WEkR53XS4mWZWrQKloxYUBxiFvK/2E3jW3x/izK0L23CkdpAwy7V2NljwTFG I6cl3L/HrWt6/Jz/BtGlO4AHva/bHUooFDMYIurZeEbqIBWeO647rCzW1nB2oo/h X8vrc6jYrTlWryyAoEHxzA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1707258699; x= 1707345099; bh=zlpo6Rq7N5C1pLkISfGFGC5SzB++fW3uHPb9ARC+4FA=; b=X iEoj36EGfE3Kb/rtOU0QAvzJnpSd67Cs0EV4vClMJFtUUHxa7fSUcPwK9DIKQPRl IK/rYV5r2Zys3nvIiuCP6AsrnqB+JGN7O2ENM2q8G2YM/chX8eAJcJ0E1aFB2Prz oGRJ4Xv+HwG+qn369ZeDDcuEuf1r+0RDH7COYV4zyHiqN2zEbGwINlvt+8Bi/lUz wJkkWe4YQvfIIPvpemLKUYhLbfU1YkeX2zGlGCs+1ldWKRG+lxtdVGjpq06OLeUZ dBOxuPi2u/VHUUhKt3DDlLZXVKWaXLGpefGDrvvqrZLgDLPRIbgP+QoglQW1eUVi DyJufB++4b/Jm11hPpPqQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrtddtgddufeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 6 Feb 2024 17:31:38 -0500 (EST) From: Thomas Monjalon To: Gregory Etelson Cc: dev@dpdk.org, mkashani@nvidia.com, Ori Kam , Aman Singh , Yuying Zhang , Ferruh Yigit , Andrew Rybchenko Subject: Re: [PATCH v2] ethdev: add template table resize API Date: Tue, 06 Feb 2024 23:31:36 +0100 Message-ID: <2641325.k3LOHGUjKi@thomas> In-Reply-To: <20240131095938.177493-1-getelson@nvidia.com> References: <20231217093205.321082-1-getelson@nvidia.com> <20240131095938.177493-1-getelson@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 31/01/2024 10:59, Gregory Etelson: > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > #define RTE_FLOW_TABLE_SPECIALIZE_TRANSFER_VPORT_ORIG RTE_BIT32(1) > +/** > + * Specialize table for resize. > + */ > +#define RTE_FLOW_TABLE_SPECIALIZE_RESIZABLE_TABLE RTE_BIT32(2) I'm not sure about the repeating "TABLE" at the end of this flag name. [...] > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change without prior notice. > + * > + * Query if a table can be resized s/if/whether/ A dot is missing. > + * > + * @param port_id > + * Port identifier of Ethernet device. > + * @param tbl_attr > + * Template table Every lines should end with a dot in Doxygen for consistency. > + * > + * @return > + * True if the table can be resized. > + */ > +static __rte_always_inline bool Why is it inline? In general we avoid inline except for few performance sensitive ones. > +rte_flow_table_resizable(__rte_unused uint16_t port_id, > + const struct rte_flow_template_table_attr *tbl_attr) > +{ > + return (tbl_attr->specialize & > + RTE_FLOW_TABLE_SPECIALIZE_RESIZABLE_TABLE) != 0; > +} [...] > + # added in 24.03 > + rte_flow_template_table_resize; > + rte_flow_async_update_resized; > + rte_flow_template_table_resize_complete; I like the idea of these 3 new functions. The scenario should be described in doc/guides/prog_guide/rte_flow.rst