From: Thomas Monjalon <thomas@monjalon.net>
To: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [dpdk-dev] [PATCH] event/dsw: avoid supplying -Wno-format-nonliteral to icc
Date: Thu, 04 Oct 2018 18:09:13 +0200 [thread overview]
Message-ID: <2641514.GnYxfkIzXT@xps> (raw)
In-Reply-To: <37910565-67d7-ff1e-aaea-65418be890a7@intel.com>
03/10/2018 21:18, Ferruh Yigit:
> On 10/3/2018 9:13 AM, Mattias Rönnblom wrote:
> > Make the -Wno-format-nonliteral flag conditional, and only set in
> > clang and gcc builds, since this flag is not supported (nor needed)
> > when building with icc.
> >
> > Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
>
> perhaps simply: "event/dsw: fix icc build"
>
> Fixes: 46a186b1f0c5 ("event/dsw: add device registration and build system")
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
next prev parent reply other threads:[~2018-10-04 16:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 8:13 Mattias Rönnblom
2018-10-03 19:18 ` Ferruh Yigit
2018-10-04 16:09 ` Thomas Monjalon [this message]
2018-10-04 16:30 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2641514.GnYxfkIzXT@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=mattias.ronnblom@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).