* [dpdk-dev] [PATCH] net/mlx5: fix flow tables double release
@ 2021-09-28 4:08 Bing Zhao
2021-09-29 7:55 ` Matan Azrad
0 siblings, 1 reply; 3+ messages in thread
From: Bing Zhao @ 2021-09-28 4:08 UTC (permalink / raw)
To: viacheslavo, matan; +Cc: dev, rasland, stable, matan
In the function mlx5_alloc_shared_dr(), there are various reasons
to result in a failure and error clean up process. While in the
caller of mlx5_dev_spawn(), once there is a error occurring after
the mlx5_alloc_shared_dr(), the mlx5_os_free_shared_dr() is called
to release all the resources.
To prevent a double release, the pointers of the resources should
be checked before the releasing and set to NULL after done.
In the mlx5_free_table_hash_list(), after the releasing, the pointer
was missed to set to NULL and a double release may cause a crash.
By setting the tables pointer to NULL as done for other resources,
the double release and crash could be solved.
Fixes: 54534725d2f3 ("net/mlx5: fix flow table hash list conversion")
Cc: matan@mellanox.com
Cc: stable@dpdk.org
Signed-off-by: Bing Zhao <bingz@nvidia.com>
---
drivers/net/mlx5/mlx5.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index 02ea2e781e..3c10f186e6 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -1369,6 +1369,7 @@ mlx5_free_table_hash_list(struct mlx5_priv *priv)
if (!sh->flow_tbls)
return;
mlx5_hlist_destroy(sh->flow_tbls);
+ sh->flow_tbls = NULL;
}
/**
--
2.27.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix flow tables double release
2021-09-28 4:08 [dpdk-dev] [PATCH] net/mlx5: fix flow tables double release Bing Zhao
@ 2021-09-29 7:55 ` Matan Azrad
2021-09-29 20:46 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Matan Azrad @ 2021-09-29 7:55 UTC (permalink / raw)
To: Bing Zhao, Slava Ovsiienko; +Cc: dev, Raslan Darawsheh, stable
From: Bing Zhao
> In the function mlx5_alloc_shared_dr(), there are various reasons to result in
> a failure and error clean up process. While in the caller of mlx5_dev_spawn(),
> once there is a error occurring after the mlx5_alloc_shared_dr(), the
> mlx5_os_free_shared_dr() is called to release all the resources.
>
> To prevent a double release, the pointers of the resources should be
> checked before the releasing and set to NULL after done.
>
> In the mlx5_free_table_hash_list(), after the releasing, the pointer was
> missed to set to NULL and a double release may cause a crash.
>
> By setting the tables pointer to NULL as done for other resources, the double
> release and crash could be solved.
>
> Fixes: 54534725d2f3 ("net/mlx5: fix flow table hash list conversion")
> Cc: matan@mellanox.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Bing Zhao <bingz@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix flow tables double release
2021-09-29 7:55 ` Matan Azrad
@ 2021-09-29 20:46 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2021-09-29 20:46 UTC (permalink / raw)
To: Bing Zhao; +Cc: Slava Ovsiienko, dev, Raslan Darawsheh, stable, Matan Azrad
29/09/2021 09:55, Matan Azrad:
> From: Bing Zhao
> > In the function mlx5_alloc_shared_dr(), there are various reasons to result in
> > a failure and error clean up process. While in the caller of mlx5_dev_spawn(),
> > once there is a error occurring after the mlx5_alloc_shared_dr(), the
> > mlx5_os_free_shared_dr() is called to release all the resources.
> >
> > To prevent a double release, the pointers of the resources should be
> > checked before the releasing and set to NULL after done.
> >
> > In the mlx5_free_table_hash_list(), after the releasing, the pointer was
> > missed to set to NULL and a double release may cause a crash.
> >
> > By setting the tables pointer to NULL as done for other resources, the double
> > release and crash could be solved.
> >
> > Fixes: 54534725d2f3 ("net/mlx5: fix flow table hash list conversion")
> > Cc: matan@mellanox.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Bing Zhao <bingz@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
Applied in next-net-mlx, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-29 20:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-28 4:08 [dpdk-dev] [PATCH] net/mlx5: fix flow tables double release Bing Zhao
2021-09-29 7:55 ` Matan Azrad
2021-09-29 20:46 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).