From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE175A0032; Wed, 29 Sep 2021 22:46:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CF00B410F2; Wed, 29 Sep 2021 22:46:32 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 6BAEA410EF; Wed, 29 Sep 2021 22:46:31 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0A4795C014F; Wed, 29 Sep 2021 16:46:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 29 Sep 2021 16:46:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= V5vgmtOOdDg3cUVUnaqZBozIjZIV5DjuberCSMhllnk=; b=fur32FTq1b1KIczU HPBbG8ZemGT2mj2i6HDZKkV+wzYGWvCrcVRlBt5FnxF+c2yBXAiNpCcwPuf9uHM0 v29okys5VMGeSaK+qESEkKjZSf3lE8iw5PJI9pUukxRB3mF1zkTp4BODyxJWqX5w /grTjR2CidMMbceXPNzFbPmX/fOGFtpgml0ZT75K9z9+l/3JsRCsnnNSeknAnqDN YcPYL1E7Zqw3TsTUbPDq7VMttEJ2Uo/SpmQT25qDEl/kBCZKh5cdyU/PgKmJMpto 8x39A+te4eUwFTktTefSbMURuJodP7JxK0oktQ9pks+OUvVrLenld14vF9jlmvty R1xukQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=V5vgmtOOdDg3cUVUnaqZBozIjZIV5DjuberCSMhll nk=; b=oDEuqOCBML+B3bYZitRpixZI5aAMNsEdSxn4wQ7w00+mCvdQyBIO/TkiK OegX4GGzwQnC0bHP6F8y2YPYsT3Pw01Ed/G4bzI/Ujk/HKW7UZ85u3fsFUWpE8IW 1vLSbj59lDlWnAC8iqBsrEfjAwdir1mOvnE7uwN4L6QQXDys5GSm2eAGaTuFwhSZ lSB7sFB1MakdN/WB8/Ax5k3TcMfzTjeEX0OkCtqNtzFzsym7g8ir+5QOAuK0YO3s 5PBkmKoCcwDWwqRF0A01c/gh9IWtcVj/P5m8FYkweEGhRWkFSO2ZVUjw1jC4jHOL N53qIINgFB0fTHk8vykbee6j2d9pQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudekvddgudehtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 29 Sep 2021 16:46:27 -0400 (EDT) From: Thomas Monjalon To: Bing Zhao Cc: Slava Ovsiienko , dev@dpdk.org, Raslan Darawsheh , "stable@dpdk.org" , Matan Azrad Date: Wed, 29 Sep 2021 22:46:26 +0200 Message-ID: <2644582.ixtJruUp4O@thomas> In-Reply-To: References: <20210928040851.56636-1-bingz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix flow tables double release X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/09/2021 09:55, Matan Azrad: > From: Bing Zhao > > In the function mlx5_alloc_shared_dr(), there are various reasons to result in > > a failure and error clean up process. While in the caller of mlx5_dev_spawn(), > > once there is a error occurring after the mlx5_alloc_shared_dr(), the > > mlx5_os_free_shared_dr() is called to release all the resources. > > > > To prevent a double release, the pointers of the resources should be > > checked before the releasing and set to NULL after done. > > > > In the mlx5_free_table_hash_list(), after the releasing, the pointer was > > missed to set to NULL and a double release may cause a crash. > > > > By setting the tables pointer to NULL as done for other resources, the double > > release and crash could be solved. > > > > Fixes: 54534725d2f3 ("net/mlx5: fix flow table hash list conversion") > > Cc: matan@mellanox.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Bing Zhao > Acked-by: Matan Azrad Applied in next-net-mlx, thanks.