From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 2EA354CE4 for ; Fri, 20 Jan 2017 15:57:30 +0100 (CET) Received: by mail-wm0-f53.google.com with SMTP id c206so47494195wme.0 for ; Fri, 20 Jan 2017 06:57:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=BcRGTlJcZwhWQ0Jnj95qlh/Esk1GXMJWD1hJMIosn/o=; b=ZEwf46lIvifr0RwWh4SaXM1TlC8Y6bqaIIi+DdGLLNZ+Q+njKsWEktTIA1Lv8NjBb8 sa4SNp+rbQjVM9YO8gzt6wCo2AcZLNfwMlkcHFvN7ErSwUtOBQX9wsXBDS2mVUuWLuFQ K2YhJc+GU1L6AmcpR1hwfgs8mV85ChhrZfyD7z1e0rYEX/QSf2lfvpLfvICgK+mOM8TJ jN5dnKnKOthgNJKpTvkmbFDKgvafN8Ply3iTyNDB8M+4pjRT/lZTNO3eJKR1gNeuplHn lBca11mWEzFa2J56plWmpraghIJw4xtX4mONMh1UjNjCXvIAz0KIx5vvWmKC8cj/L46V S9RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=BcRGTlJcZwhWQ0Jnj95qlh/Esk1GXMJWD1hJMIosn/o=; b=asuIURbOGt5YHIYoF0KBQJRRHiq3yfb+JQKq9QZo0wjInRdRcSFmpSWtioy46GXQjt r/h6cr243sR+QkXg4GWu3lVfuOtvYRUQ4UZNN/upPa1dIHyUsNZt4G1ZOyGR1kFm6Cel 8DZHW7MjkhgkwEydyRbFfLyPn9MJOs5fzESEpZVtC+g23+8lhT6VLmJBygg6eIlROizq LjStwZfqrBA3x6i8DDOGL5GuwpdhwPfsZG9ra17uRR3IRNv4Sbk5Ae2QWRqFSPwr/uYR stqh/O1TiK1U3SMyxhT3348GFM0mWeZnwjEB+ZIgx+fZ4NHaxA60ELBDNZEm8z41YWxk 16Fg== X-Gm-Message-State: AIkVDXIDl0pZ+EhzsjjIJmFJtGle6w0YlmMeSuvEuaIh2Jo2+m6KEnERbBTRoiVSD8akMhf4 X-Received: by 10.28.163.3 with SMTP id m3mr4072531wme.85.1484924250562; Fri, 20 Jan 2017 06:57:30 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id r129sm6584174wmd.8.2017.01.20.06.57.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Jan 2017 06:57:29 -0800 (PST) From: Thomas Monjalon To: "Lu, Wenzhuo" , Adrien Mazarguil Cc: "Liu, Yong" , dev@dpdk.org Date: Fri, 20 Jan 2017 15:57:28 +0100 Message-ID: <2644957.VYUMgdHQjR@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B55C21C@shsmsx102.ccr.corp.intel.com> References: <1484804043-50156-1-git-send-email-yong.liu@intel.com> <20170119184552.GB3779@6wind.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B55C21C@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for cloud filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2017 14:57:31 -0000 2017-01-20 02:14, Lu, Wenzhuo: > Hi Adrien, Thomas, Yong, > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Adrien Mazarguil > > Sent: Friday, January 20, 2017 2:46 AM > > To: Thomas Monjalon > > Cc: Liu, Yong; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI change for cloud filter > > > > On Thu, Jan 19, 2017 at 10:06:34AM +0100, Thomas Monjalon wrote: > > > 2017-01-19 13:34, Yong Liu: > > > > +* ABI changes are planned for 17.05: structure > > > > +``rte_eth_tunnel_filter_conf`` > > > > + will be extended with a new member ``vf_id`` in order to enable > > > > +cloud filter > > > > + on VF device. > > > > > > I think we should stop rely on this API, and migrate to rte_flow instead. > > > Adrien any thought? > > > > I'm all for using rte_flow in any case. I've already documented an approach to > > convert TUNNEL filter rules to rte_flow rules [1], although it may be > > incomplete due to my limited experience with this filter type. We already > > know several tunnel item types must be added (currently only VXLAN is > > defined). > > > > I understand ixgbe/i40e currently map rte_flow on top of the legacy > > framework, therefore extending this structure might still be needed in the > > meantime. Not sure we should prevent this change as long as such rules can be > > configured through rte_flow as well. > > > > [1] http://dpdk.org/doc/guides/prog_guide/rte_flow.html#tunnel-to-eth-ipv4- > > ipv6-vxlan-or-other-queue > The problem is we haven't finished transferring all the functions from the regular filters to the generic filters. > For example, igb, fm10k and enic haven't support generic filters yet. Ixgbe and i40e have supported the basic functions, but some advance features are not transferred to generic filters yet. > Seems it's not the time to remove the regular filters. Yong, I suggest to support both generic filter and regular filter in parallel. > So, we need to announce ABI change for the regular filter, until someday we remove the regular filter API. I disagree. There is a new API framework (rte_flow) and we must focus on this transition. It means we must stop any work on the legacy API.