From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id 345615949 for ; Wed, 22 Jul 2015 15:48:24 +0200 (CEST) Received: by wibud3 with SMTP id ud3so173500127wib.0 for ; Wed, 22 Jul 2015 06:48:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=+rVarVvyo60SyEzPiPa7XlbgHpJqEExms6SI2Fj/8yY=; b=Xow1YUK1d16aaB+EiuZzvP4A12chnFqtdH1LFsB4zFZNxV3xkGly8xDcDLO80ixLjK pOuBFDbT6HVSIFGJOCJQTtNwFlJv3dFlby6dOasa/DOJBQKis1+WKdISmwFaqvCCnVd1 2WV/CP5dDPIv6fWib5nmDYFLn10K6mx5VT/T/0COcX3J033xLZdtvArSflNK8+yYdgis aysaaGrQ9ypao4f0hpl0koAj+rEYrnnwVnTRj6V5aGjlbDrCrUQ5haJ9tXReB0NuetYZ l98BEto76mYgxE4vmUtXhmL6l2MPJnv7ig4NPBeI36HSfFZNzLGmSRtuBEmYO+1hnK9o S4VA== X-Gm-Message-State: ALoCoQmukCUtHpeKVzf6w/1KLpXlwMqgnRW0N4USBbsH8wknj/kew7Q0OaK6kGK2itjj9JSO7gtL X-Received: by 10.181.29.100 with SMTP id jv4mr6738215wid.4.1437572903882; Wed, 22 Jul 2015 06:48:23 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id c11sm22181643wib.1.2015.07.22.06.48.22 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Jul 2015 06:48:23 -0700 (PDT) From: Thomas Monjalon To: "Richardson, Bruce" Date: Wed, 22 Jul 2015 15:47:10 +0200 Message-ID: <2646761.JxpPTaGeqc@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <59AF69C657FD0841A61C55336867B5B03457D2BE@IRSMSX103.ger.corp.intel.com> References: <1437492307-29754-1-git-send-email-bruce.richardson@intel.com> <55AF9875.7010001@linaro.org> <59AF69C657FD0841A61C55336867B5B03457D2BE@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: fix check for split packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2015 13:48:24 -0000 2015-07-22 13:35, Richardson, Bruce: > From: Zoltan Kiss [mailto:zoltan.kiss@linaro.org] > > On 22/07/15 10:59, Bruce Richardson wrote: > > > The vector PMD always works off a fixed 32 burst size. Any change to > > > that will lead to many changes in the code, so I don't believe a loop is > > necessary. > > > > Ok, then I suggest to make a comment around RTE_IXGBE_VPMD_RX_BURST that > > changing it needs a lot of other changes in the code elsewhere, e.g in > > this split_flags check. > > Btw. vPMD was a bit misleading abbreviation for me, it took me a while > > until I realized 'v' stands for 'vector', not 'virtualization' as in most > > cases nowadays. > > Good idea. I'll try to submit a patch to add a comment if I get the chance > - otherwise feel free to do so yourself. Why not do it in this patch? Is it not enough related? > As for the naming, yes, I suppose it can be confusing. :-) We possibly need > to start calling these pieces of code SSE or AVX rather than just vector, > since for some we may end up with multiple vector versions. +1 for SSE/AVX naming